Re: Opus codec developments

2012-07-27 Thread Magnus Holmgren
On 2012-07-27 18:00, Rafaël Carré wrote: A call to codec_set_replaygain() when starting a new track should be enough. It looks like the existing tag parsing code is used; if so Replaygain tags are already handled. I think the tags are not read at all from the file: http://git.videolan.org/?p=

Re: Opus codec developments

2012-07-27 Thread Rafaël Carré
Le 2012-07-27 15:24, Bertrik Sikken a écrit : > On 26-7-2012 8:25, Rafaël Carré wrote: >> Le 2012-07-26 14:08, Bertrik Sikken a écrit : >> Ideally we should go and replace malloc() by static buffers using worst >> case possibilities when possible. > > The mallocs still being done, are done only a

Re: Opus codec developments

2012-07-27 Thread Rafaël Carré
Le 2012-07-27 15:32, Magnus Holmgren a écrit : > On 2012-07-27 15:24, Bertrik Sikken wrote: > * Applying global gain from the opus audio file is not implemented (not sure if replaygain is working) >>> >>> Fixed (it's part of the codec, not related to replaygain although we >>> might w

Re: Opus codec developments

2012-07-27 Thread Magnus Holmgren
On 2012-07-27 15:24, Bertrik Sikken wrote: * Applying global gain from the opus audio file is not implemented (not sure if replaygain is working) Fixed (it's part of the codec, not related to replaygain although we might want to implement replaygain for e.g. vorbis too). Thanks. (Replayg

Re: Opus codec developments

2012-07-27 Thread Bertrik Sikken
On 26-7-2012 8:25, Rafaël Carré wrote: > Le 2012-07-26 14:08, Bertrik Sikken a écrit : >> Stuff that still needs work: >> * Memory allocation in the codec main is not fully consistent yet (probably >> leaking some memory), so playing several files in sequence may not work > > What do you mean by