Re: Hotkey patch

2010-03-29 Thread Gareth Schakel
On 3/29/2010 7:52 PM, Rafaël Carré wrote: On Mon, 29 Mar 2010 18:34:32 -0500 Paul Louden wrote: On 3/29/2010 6:19 PM, Jeff Goode wrote: It is an optional feature, same as many others. If a knowledgeable developer wants to switch it on for his target of choice, I've made it very eas

Re: Hotkey patch

2010-03-29 Thread Rafaël Carré
On Mon, 29 Mar 2010 18:34:32 -0500 Paul Louden wrote: > On 3/29/2010 6:19 PM, Jeff Goode wrote: > > It is an optional feature, same as many others. If a knowledgeable > > developer wants to switch it on for his target of choice, I've made > > it very easy to do so. At the same time, my patch c

Re: Hotkey patch

2010-03-29 Thread Jeff Goode
On 3/29/2010 19:34, Paul Louden wrote: On 3/29/2010 6:19 PM, Jeff Goode wrote: It is an optional feature, same as many others. If a knowledgeable developer wants to switch it on for his target of choice, I've made it very easy to do so. At the same time, my patch consumes no resources and ch

Re: Hotkey patch

2010-03-29 Thread Paul Louden
On 3/29/2010 6:19 PM, Jeff Goode wrote: It is an optional feature, same as many others. If a knowledgeable developer wants to switch it on for his target of choice, I've made it very easy to do so. At the same time, my patch consumes no resources and changes nothing if it isn't switched on.

Re: Hotkey patch

2010-03-29 Thread Jeff Goode
On 3/29/2010 18:19, Paul Louden wrote: Well, there's that, but I still don't know much about other targets. I mean, I looked over the keymaps and can avoid duplicates and whatnot, but until you live with the actual physical object for a while, you still don't really know how friendly it is t

Re: Hotkey patch

2010-03-29 Thread Paul Louden
Well, there's that, but I still don't know much about other targets. I mean, I looked over the keymaps and can avoid duplicates and whatnot, but until you live with the actual physical object for a while, you still don't really know how friendly it is to use. I'd rather not futz with someth

Re: Hotkey patch

2010-03-29 Thread Jeff Goode
On 3/29/2010 17:41, Alex Parker wrote: On 29/03/10 23:21, Jeff Goode wrote: BTW, the patch works in the associated sim also, so it's not player only. So I think that his point was that if this is to be committed, the sims should be used to implement it for other players first. Alex Wel

Re: Hotkey patch

2010-03-29 Thread Alex Parker
On 29/03/10 23:21, Jeff Goode wrote: BTW, the patch works in the associated sim also, so it's not player only. So I think that his point was that if this is to be committed, the sims should be used to implement it for other players first. Alex

Re: Hotkey patch

2010-03-29 Thread Jeff Goode
On 3/29/2010 11:28, Paul Louden wrote: Since you vanished from IRC before I got to respond: Do you intend to add the other keymaps to this, or just leave it as a feature only e200s get and hope someone else will add them in later? It seems like something you should be able to accomplish via t

Re: Hotkey patch

2010-03-29 Thread Paul Louden
Since you vanished from IRC before I got to respond: Do you intend to add the other keymaps to this, or just leave it as a feature only e200s get and hope someone else will add them in later? It seems like something you should be able to accomplish via the sims rather than leaving this a play

Re: Hotkey patch

2010-03-28 Thread Jeff Goode
On 3/27/2010 19:49, Paul Louden wrote: On 3/27/2010 6:46 PM, Jeff Goode wrote: In a couple of different screens, the button I'm using was already assigned. But in one, the bookmark menu, it acts the same as before, with a delete prompt. It's not assignable, just internally renamed. In the o

RE: Hotkey patch

2010-03-28 Thread Scott Berry
e] On Behalf Of Paul Louden Sent: Saturday, March 27, 2010 18:49 To: Rockbox development Subject: Re: Hotkey patch On 3/27/2010 6:46 PM, Jeff Goode wrote: In a couple of different screens, the button I'm using was already assigned. But in one, the bookmark menu, it acts the same as befo

Re: Hotkey patch

2010-03-27 Thread Paul Louden
On 3/27/2010 6:46 PM, Jeff Goode wrote: In a couple of different screens, the button I'm using was already assigned. But in one, the bookmark menu, it acts the same as before, with a delete prompt. It's not assignable, just internally renamed. In the other, the WPS, the button was hardcoded

Re: Hotkey patch

2010-03-27 Thread Jeff Goode
On 3/25/2010 04:22, Alex Parker wrote: On 24 March 2010 18:08, Jeff Goode <mailto:jef...@gmail.com>> wrote: Another hotkey patch is at FS#11081. The code is now completely transparent unless the HOTKEY define is explicitly stated in the target config file. And hotkey ta

Re: Hotkey patch

2010-03-25 Thread Alex Parker
On 24 March 2010 18:08, Jeff Goode wrote: > > Another hotkey patch is at FS#11081. The code is now completely transparent > unless the HOTKEY define is explicitly stated in the target config file. And > hotkey targets now have a lower binsize increase. The e200 is about 900 > bytes

Re: Hotkey patch

2010-03-24 Thread Jeff Goode
It's not 100% ready for commitment, mostly because a couple of strings aren't in english.lang yet. But I'd like to polish it up a bit and commit it soon. I'd also like more targets to be added. I'd appreciate any feedback. Thanks, Jeff Another hotkey pa

Re: Hotkey patch

2010-03-23 Thread Jeff Goode
On 3/23/2010 00:54, Jonathan Gordon wrote: On 23 March 2010 03:01, Jeff Goode wrote: Hi, A working patch for an assignable hotkey is available at FS#11081. It's transparent if the target doesn't have HOTKEY defined in its config file. So far its functions are limited but the framework is i

Re: Hotkey patch

2010-03-22 Thread Jonathan Gordon
On 23 March 2010 03:01, Jeff Goode wrote: > Hi, > > A working patch for an assignable hotkey is available at FS#11081. It's > transparent if the target doesn't have HOTKEY defined in its config file. So > far its functions are limited but the framework is in place and it can be > easily expanded.

Hotkey patch

2010-03-22 Thread Jeff Goode
Hi, A working patch for an assignable hotkey is available at FS#11081. It's transparent if the target doesn't have HOTKEY defined in its config file. So far its functions are limited but the framework is in place and it can be easily expanded. It's not 100% ready for commitment, mostly becau