Re: Please help test gerrit#890

On 7 July 2014 05:18, Thomas Martitz wrote: > Am 05.07.2014 10:30, schrieb Jonathan Gordon: > > What you are proposing to add is the exact opposite what we did a few > years back, when we all happily agreed that the offset-approach is better > for the skin engine. Please clear me up on why you wa

Re: Please help test gerrit#890

Am 05.07.2014 13:12, schrieb Dave Hooper: +1 . The benefits of being alerted to bugs that are otherwise occurring passively with random effects, with the bonus of actually smaller footprint, sounds compelling. What's not to want there? I would agree too, if only this was actually true. But

Re: Please help test gerrit#890

Am 05.07.2014 10:30, schrieb Jonathan Gordon: On 4 July 2014 16:21, Thomas Martitz > wrote: Why do you except this to fix skin issues? It only _adds_ fragile pointer management. What's wrong with the current aproach? What's wrong with the current approach i

Re: Please help test gerrit#890

On 06/07/14 10:22, Jonathan Gordon wrote: Thanks! This is fixed, please retry with the updated patch. Yep, nice one, that fixes it.

Re: Please help test gerrit#890

On 6 July 2014 05:28, Richard Quirk wrote: > > Please let me know if you find any crashes - or even better if this fixes >> any crashes with your troublesome skins! >> >> > I didn't see any crashes, but the clock_lock2 theme I use on the WPS > didn't work any more. This is on the sansa clip zip,

Re: Please help test gerrit#890

On 6 July 2014 05:28, Richard Quirk wrote: > > Please let me know if you find any crashes - or even better if this fixes >> any crashes with your troublesome skins! >> >> > I didn't see any crashes, but the clock_lock2 theme I use on the WPS > didn't work any more. This is on the sansa clip zip,

Re: Please help test gerrit#890

Please let me know if you find any crashes - or even better if this fixes any crashes with your troublesome skins! I didn't see any crashes, but the clock_lock2 theme I use on the WPS didn't work any more. This is on the sansa clip zip, here's a link to the theme: http://themes.rockbox.o

Re: Please help test gerrit#890

+1 . The benefits of being alerted to bugs that are otherwise occurring passively with random effects, with the bonus of actually smaller footprint, sounds compelling. What's not to want there?

Re: Please help test gerrit#890

On 4 July 2014 16:21, Thomas Martitz wrote: > > Why do you except this to fix skin issues? It only _adds_ fragile pointer > management. What's wrong with the current aproach? > > What's wrong with the current approach is that it is extremely difficult to track down bugs when they happen, and that

Re: Please help test gerrit#890

For what it’s worth, I updated my iriver to latest master (+ my still unreviewed patch) yesterday. If everything flows as usual in the next days, I can give it a shot to test your code, although I never experienced skin bugs, as far as I can tell. regards, Jonas On 03.07.2014 15:21, Jonathan Gord

Re: Please help test gerrit#890

Am 03.07.2014 15:21, schrieb Jonathan Gordon: Hi all, Over the last few days I've been working on redoing how the skin engine manages its buffers. My goal is to finally get rid of all the semi-random skin issues and this is the first step. Why do you except this to fix skin issues? It onl

Please help test gerrit#890

Hi all, Over the last few days I've been working on redoing how the skin engine manages its buffers. My goal is to finally get rid of all the semi-random skin issues and this is the first step. http://gerrit.rockbox.org/r/#/c/890/ This patch adds some error handling and will also make any issues