Re: USB charge buttons

2011-05-17 Thread Michael Sparmann
Am 17.05.2011 02:08, schrieb Jonathan Gordon: > On 17 May 2011 06:29, Mike Giacomelli wrote: >> I wonder how hard it would be to add a menu option to the top level menus >> when in charge mode that would enter UMS mode. Would make an option to >> enter charge mode by default a lot more practical

Re: USB charge buttons

2011-05-16 Thread Jonathan Gordon
On 17 May 2011 06:29, Mike Giacomelli wrote: > I wonder how hard it would be to add a menu option to the top level menus > when in charge mode that would enter UMS mode.  Would make an option to > enter charge mode by default a lot more practical I think.  Android does it, > but I'm not sure if ou

RE: USB charge buttons

2011-05-16 Thread Mike Giacomelli
Sounds good. Committed in Revision 29889. Please report any problems created by this change. > > I'd like to commit this: > > > > http://www.rockbox.org/tracker/task/11769 > > I'd love to see this in. Like pondlife, I have a preference for having > the option to reverse the behavior (default

Re: USB charge buttons

2011-05-16 Thread Paul Louden
Just to chime in, I too like "any button does it" (as per the patch) and "make available the option to reverse the behaviour" and "leave the default as USB file access."

Re: USB charge buttons

2011-05-16 Thread Alex Parker
On 16 May 2011 13:18, Frank Gevaerts wrote: > On Mon, May 16, 2011 at 08:30:50AM +0100, pondlife wrote: > > Gets my vote. I'm in favour of the "any button" approach, although would > > prefer the option to charge by default (i.e. button press to connect) as > per > > FS#10198. > > I wouldn't min

Re: USB charge buttons

2011-05-16 Thread Frank Gevaerts
On Mon, May 16, 2011 at 08:30:50AM +0100, pondlife wrote: > Gets my vote. I'm in favour of the "any button" approach, although would > prefer the option to charge by default (i.e. button press to connect) as per > FS#10198. I wouldn't mind having a setting for the default mode, but: * I think t

Re: USB charge buttons

2011-05-16 Thread Alex Parker
On 16 May 2011 12:29, sideral wrote: > Mike Giacomelli writes: > > > I'd like to commit this: > > > > http://www.rockbox.org/tracker/task/11769 > > I'd love to see this in. Like pondlife, I have a preference for having > the option to reverse the behavior (default to charge only, any button > p

Re: USB charge buttons

2011-05-16 Thread sideral
Mike Giacomelli writes: > I'd like to commit this: > > http://www.rockbox.org/tracker/task/11769 I'd love to see this in. Like pondlife, I have a preference for having the option to reverse the behavior (default to charge only, any button press to connect), but I don't care particularly deeply.

Re: USB charge buttons

2011-05-16 Thread Michael Sparmann
Am 16.05.2011 09:30, schrieb pondlife: > Gets my vote. I'm in favour of the "any button" approach, although would > prefer the option to charge by default (i.e. button press to connect) as per > FS#10198. +1 for both of these from me. And I should finally get around to making charger detection

Re: USB charge buttons

2011-05-16 Thread pondlife
Gets my vote. I'm in favour of the "any button" approach, although would prefer the option to charge by default (i.e. button press to connect) as per FS#10198. pondlife