Updates on our gerrit instance

In no particular order: * As of a week or so ago, we're _finally_ running a still-currently-supported version. (3.1.x) * As of today, GitLab authentication _finally_ works! So currently, generic OpenID, Google, GitHub, and GitLab can all be used. * The SSH host key used by gerr

Re: Google authentication on the Gerrit site is broken

On Sun, Nov 15, 2020 at 02:06:33AM -0500, Solomon Peachy via rockbox-dev wrote: > * Google config was fixed, but due to the change in URL it requires someone >at google to "validate" the changes, which can supposedly take >"up to 4-6 weeks" -- WTF. Google-based authentication once again

Google authentication on the Gerrit site is broken

On Sat, Nov 14, 2020 at 09:12:01PM -0500, Solomon Peachy via rockbox-dev wrote: > FYI, I just completed the upgrade to v2.16.23. > > In other news, I also fixed a longstanding configuration error that only > seemed to cause issues when trying to use the new PolyGerrit UI. Unfortunately, a side

Re: Gerrit instance scheduled for an upgrade 2020-10-22 @ 12:00 US-Eastern

On Thu, Oct 22, 2020 at 12:18:14PM -0400, Solomon Peachy via rockbox-dev wrote: > I'll probably do the 2.16 upgrade sooner rather than later FYI, I just completed the upgrade to v2.16.23. We're now only one major release behind being on an actively-supported release! In other news, I also fix

Re: Gerrit instance scheduled for an upgrade 2020-10-22 @ 12:00 US-Eastern

On Tue, Oct 20, 2020 at 08:53:52PM -0400, Solomon Peachy via rockbox-dev wrote: > Downtime shouldn't be more than 15 minutes; I've already done a couple > of dry-run upgrades and don't anticipate any issues. It's back online after a downtime of just 14 minutes. No apparent issues. I'll probably

Gerrit instance scheduled for an upgrade 2020-10-22 @ 12:00 US-Eastern

I'm going to upgrade our gerrit instance from v2.14.20 (EOL'd) to v2.15.19 (also EOL'd) Downtime shouldn't be more than 15 minutes; I've already done a couple of dry-run upgrades and don't anticipate any issues. Why upgrade? Security fixes are the main reason th

Gerrit ssh keys

Hi devs. It has been brought to my attention that some of you may have ssh-dss keys registered for access to Gerrit and since a server update a while ago you are now denied access, while getting error messages that give very few clues. The reason for the problem is that ssh-dss has been found

Gerrit is operational

Hi folks, thanks to Bjorn, Gerrit is now fully operational again: - OAuth and OpenID login are back, if you have several accounts you can merge them using the UI - anonymous browing - checkout/cherry-pick commands are in the Download menu of the patchset Happy hacking ! Amaury

Gerrit / git-review

Hi again, as you may be aware, with the recent version of Gerrit and following the OpenStack trend, git gained a new plugin called git-review which is used to manage patchset and can be used with gerrit. It is included in most distribution (apt-get install git-review) and is very easy ot use

Gerrit is working again

Hi fellows developpers, thanks to Björn and others, we now have Gerrit working again properly which means that: * you can authenticate with OpenID * you can recover your old google account thanks to the automatic OpenID > OAuth migration To make this work, simply reach at http://gerrit.rockbox.

Re: gerrit

Am 14.06.2015 um 22:22 schrieb Marcin Bukat via rockbox-dev: Google pulled the plug from openid 2.0. This means no gerrit access for many who used google account to authenticate. Are there any plans to remedy this situation? I guess upgrading gerrit should bring new, supported by bigG

Re: gerrit

On 14 Jun 2015 22:24, "Marcin Bukat via rockbox-dev" < rockbox-dev@cool.haxx.se> wrote: > > Google pulled the plug from openid 2.0. This means no gerrit access for many who used google account to authenticate. Are there any plans to remedy this situation? I guess upgrading g

Re: gerrit

Am Sun, 14 Jun 2015 22:22:23 +0200 schrieb Marcin Bukat via rockbox-dev : > Google pulled the plug from openid 2.0. This means no gerrit access for > many who used google account to authenticate. Are there any plans to remedy > this situation? I guess upgrading gerrit should bring new,

gerrit

Google pulled the plug from openid 2.0. This means no gerrit access for many who used google account to authenticate. Are there any plans to remedy this situation? I guess upgrading gerrit should bring new, supported by bigG authentication methods. wodz

Completed extended metronome plugin (gerrit #887)

Hi, after a few prototypes I have pushed my (first) final version of an extended metronome plugin to Gerrit: http://gerrit.rockbox.org/r/#/c/887/ Testing and eventually merging of that into rockbox proper would be welcome. This replaces the existing metronome plugin now, as all the

Re: Please help test gerrit#890

On 7 July 2014 05:18, Thomas Martitz wrote: > Am 05.07.2014 10:30, schrieb Jonathan Gordon: > > What you are proposing to add is the exact opposite what we did a few > years back, when we all happily agreed that the offset-approach is better > for the skin engine. Please clear me up on why you wa

Re: Please help test gerrit#890

Am 05.07.2014 13:12, schrieb Dave Hooper: +1 . The benefits of being alerted to bugs that are otherwise occurring passively with random effects, with the bonus of actually smaller footprint, sounds compelling. What's not to want there? I would agree too, if only this was actually true. But

Re: Please help test gerrit#890

Am 05.07.2014 10:30, schrieb Jonathan Gordon: On 4 July 2014 16:21, Thomas Martitz > wrote: Why do you except this to fix skin issues? It only _adds_ fragile pointer management. What's wrong with the current aproach? What's wrong with the current approach i

Re: Please help test gerrit#890

On 06/07/14 10:22, Jonathan Gordon wrote: Thanks! This is fixed, please retry with the updated patch. Yep, nice one, that fixes it.

Re: Please help test gerrit#890

On 6 July 2014 05:28, Richard Quirk wrote: > > Please let me know if you find any crashes - or even better if this fixes >> any crashes with your troublesome skins! >> >> > I didn't see any crashes, but the clock_lock2 theme I use on the WPS > didn't work any more. This is on the sansa clip zip,

Re: Please help test gerrit#890

On 6 July 2014 05:28, Richard Quirk wrote: > > Please let me know if you find any crashes - or even better if this fixes >> any crashes with your troublesome skins! >> >> > I didn't see any crashes, but the clock_lock2 theme I use on the WPS > didn't work any more. This is on the sansa clip zip,

Re: Please help test gerrit#890

Please let me know if you find any crashes - or even better if this fixes any crashes with your troublesome skins! I didn't see any crashes, but the clock_lock2 theme I use on the WPS didn't work any more. This is on the sansa clip zip, here's a link to the theme: http://themes.rockbox.o

Re: Please help test gerrit#890

+1 . The benefits of being alerted to bugs that are otherwise occurring passively with random effects, with the bonus of actually smaller footprint, sounds compelling. What's not to want there?

Re: Please help test gerrit#890

On 4 July 2014 16:21, Thomas Martitz wrote: > > Why do you except this to fix skin issues? It only _adds_ fragile pointer > management. What's wrong with the current aproach? > > What's wrong with the current approach is that it is extremely difficult to track down bugs when they happen, and that

Re: Please help test gerrit#890

For what it’s worth, I updated my iriver to latest master (+ my still unreviewed patch) yesterday. If everything flows as usual in the next days, I can give it a shot to test your code, although I never experienced skin bugs, as far as I can tell. regards, Jonas On 03.07.2014 15:21, Jonathan Gord

Re: Please help test gerrit#890

Am 03.07.2014 15:21, schrieb Jonathan Gordon: Hi all, Over the last few days I've been working on redoing how the skin engine manages its buffers. My goal is to finally get rid of all the semi-random skin issues and this is the first step. Why do you except this to fix skin issues? It onl

Please help test gerrit#890

Hi all, Over the last few days I've been working on redoing how the skin engine manages its buffers. My goal is to finally get rid of all the semi-random skin issues and this is the first step. http://gerrit.rockbox.org/r/#/c/890/ This patch adds some error handling and will also make any issues

G#697: New Volume Limiter feature for Rockbox (gerrit reviews and codes improvements needed)

To prevent some unexpected volume change, I implement a Volume Limiter feature. I add a "volume limit" parameter to the configuration file. Each time when WPS_VOL_UP or setvol() is excuted, Rockbox will check if the global_settings.volume value larger than global_settings.volume_limit. If l

Sansa Clip Zip manual: screenshots at gerrit

Hello all! Two days ago I posted on gerrit a (binary) patch to give the screenshots to the Sansa Clip Zip manual. It's located at http://gerrit.rockbox.org/r/#/c/357/ (so I'm asking for a review, which shouldn't be problematic, given that there is no code modification involve

Re: Reminder: Use Gerrit to submit patches/translation fixes, not flyspray

Patches" link in the website menu > should point to Gerrit instead of Flyspray. It might be better for it to point to UsingGit instead, since patches in Gerrit are not particularly discoverable and there is no way to actually upload a patch there. :) -- Torne Wuff to...@wolfpuppy.org.uk

Re: Reminder: Use Gerrit to submit patches/translation fixes, not flyspray

On Fri, Mar 2, 2012 at 12:03 AM, Paul Louden wrote: > Shouldn't we remove the "patches" category on Flyspray then, much like > we did "Feature Requests?" Maybe, but more importantly the "Patches" link in the website menu should point to Gerrit instead of Flyspray. - Dominik

Re: Reminder: Use Gerrit to submit patches/translation fixes, not flyspray

On 2 March 2012 09:56, Jonathan Gordon wrote: > Hi all, > > Please remember we have mostly switched to gerrit for patch tracking > and would like to only use flyspray for bugs. If your patches > (translations especially) are submitted to gerrit it is much more > likely they will

Re: Reminder: Use Gerrit to submit patches/translation fixes, not flyspray

Shouldn't we remove the "patches" category on Flyspray then, much like we did "Feature Requests?"

Reminder: Use Gerrit to submit patches/translation fixes, not flyspray

Hi all, Please remember we have mostly switched to gerrit for patch tracking and would like to only use flyspray for bugs. If your patches (translations especially) are submitted to gerrit it is much more likely they will be merged quickly (they can be done wih a single click from the website

Re: Call for testers for gerrit#120

- Original Message - From: "Jonathan Gordon" To: "Rockbox development" ; "Rockbox" Sent: Thursday, February 23, 2012 7:03 PM Subject: Call for testers for gerrit#120 Hi all, http://gerrit.rockbox.org/r/#/c/120/ changes the way lcd drivers work inte

Re: Call for testers for gerrit#120

Sorry I only have the sansa clip+. But I guess sansa clip+ can be considered as a colorless screen since the screen is composed of 2 monochrome screens (yellow & blue). Yohan >> Please download for your targets and use it for a bit to see if there > >> is any issues with the LCD (redrawing, scr

Re: Call for testers for gerrit#120

On 26 February 2012 20:53, Yohan LEE-TIN-YIEN wrote: >> Please download for your targets and use it for a bit to see if there >> is any issues with the LCD (redrawing, screen updates, etc). > > > I've been testing on Sansa Clip+ for 2 days now, and basically what I > experienced is : > - everythin

Re: Call for testers for gerrit#120

> > Please download for your targets and use it for a bit to see if there > is any issues with the LCD (redrawing, screen updates, etc). > I've been testing on Sansa Clip+ for 2 days now, and basically what I experienced is : - everything works fine : menu, wps, rds, demos (all), games (only a few

Re: Call for testers for gerrit#120

> Please download for your targets and use it for a bit to see if there > is any issues with the LCD (redrawing, screen updates, etc). MPIO HD300 works (tested general navigation, wps, a few demo plugins).

Call for testers for gerrit#120

Hi all, http://gerrit.rockbox.org/r/#/c/120/ changes the way lcd drivers work internally and every single target needs testing (or at least a few to make sure it probably works for all of them). gevaerts has kindly built and hosted builds at http://rockbox.hostname.be/lcd-test/ Please download fo

Code reviews now available on gerrit

Hi again everyone, I have enabled code reviews on Gerrit. This means that you can now upload changes for review, even if you are not a committer. We expect that in the future, people will use this rather than uploading patches to Flyspray. The documentation on how to do this is available at http

Git/gerrit migration progress

On 6 September 2011 15:40, Torne Wuff wrote: > 1) We need to move Gerrit and the repositories it's hosting onto our > infrastructure, at git.rockbox.org. This in itself won't change > anything; it will still be a svn mirror and it won't immediately > replace the curr

Re: Git/gerrit migration status and next steps

On 25 September 2011 16:21, Thomas Martitz wrote: > Is there any update on this? I would love to see the git transition happen > asap :) Apologies; we haven't made any more progress on this because I've just been in California for two weeks working and thus have been in an inconvenient timezone t

Re: Git/gerrit migration status and next steps

Am 06.09.2011 16:40, schrieb Torne Wuff: Hi folks, [...] Comments? Questions? Is there any update on this? I would love to see the git transition happen asap :) Best regards.

Re: Git/gerrit migration status and next steps

On Tue, Sep 6, 2011 at 4:40 PM, Torne Wuff wrote: > Comments? Questions? I think it would be good to ask people to follow some kind of commit message template (and start so doing now). Per default git doesn't wrap long lines in commit messages, and we do have long lines in commit messages even th

Re: Git/gerrit migration status and next steps

itter pushes a patch for review through gerrit. I'm with Torne on requiring reviews for release branches, but for trunk I don't see that working. And I also agree that it makes sense to make one change at a time. - Dominik

Re: Git/gerrit migration status and next steps

On Wed, Sep 7, 2011 at 9:59 AM, Jonathan Gordon wrote: > This isn't about people doing the wrong thing. This is about trying to get > code quality. And yes it will be a minor pain sometimes, but a small fix has If we want to improve code quality (which I'm all for) we should start working on more

RE: Git/gerrit migration status and next steps

ges. But that's just a guess and as i said i would > find > it interesting. > > Nils I'm not sure I agree - when people have large and or contentious changes at the moment, they put them up as a flyspray patch - which in the future world will be analogous to putting t

Re: Git/gerrit migration status and next steps

On 7 September 2011 21:38, Nils Wallménius wrote: > > I guess we will see if people use the review stuff voluontarily but i > expect not as it's easier to just push directly (as we do it now). If > everyone has to get their changes reviewed i think that would make > people more inclined to review

Re: Git/gerrit migration status and next steps

On Wed, Sep 7, 2011 at 1:12 PM, wrote: >> >> That's the whole point of a test, to see how it works out, you seem certain >> that it *can't* work which i find overly negative. Of course we can't force >> people to do anything but i think this will encourage people to review, if it >> turns out it

Re: Git/gerrit migration status and next steps

On Wed, Sep 7, 2011 at 6:08 AM, Jonathan Gordon wrote: > On 7 September 2011 21:02, Nils Wallménius wrote: > I honestly have no idea how the whole blame shareing thing happened > either. anyone who does software engineering should know that "review" > means implementation review and not feautre r

RE: Git/gerrit migration status and next steps

> > That's the whole point of a test, to see how it works out, you seem certain > that it *can't* work which i find overly negative. Of course we can't force > people to do anything but i think this will encourage people to review, if it > turns out it doesn't work, we disable it. > > Nils I jus

Re: Git/gerrit migration status and next steps

On 7 September 2011 21:02, Nils Wallménius wrote: > On Wed, Sep 7, 2011 at 10:53 AM, Thomas Martitz wrote: >> Am 07.09.2011 10:29, schrieb Nils Wallménius: >>> >>> I think it could be interesting to test it actually. >>> >>> >> >> Testing it will probably show that it works in the beginning, but

Re: Git/gerrit migration status and next steps

On Wed, Sep 7, 2011 at 10:53 AM, Thomas Martitz wrote: > Am 07.09.2011 10:29, schrieb Nils Wallménius: >> >> I think it could be interesting to test it actually. >> >> > > Testing it will probably show that it works in the beginning, but it will > not show that this way degrades to clicking away c

Re: Git/gerrit migration status and next steps

ithout any chance to actually test things > out is going to cause a lot of unhappiness. Okay, I sent that kinda prematurely, here's a few more things: My primary goal in introducing Gerrit was to make it easier for people *without* commit access to get their changes looked at and submitted, by

Re: Git/gerrit migration status and next steps

On 7 September 2011 08:48, Thomas Jarosch wrote: > Second this. Can gerrit be configured to request a review optionally? > Let's say one touches an unfamiliar area of the code (f.e. tagcache), > then it would be nice to request a review. That's how I am intending to configure

Re: Git/gerrit migration status and next steps

I'm with Bryan too. Reviews are of course useful, and gerrit makes this easier than what we have today, but reviews are not mandatory today and I don't think they should be mandatory going forward either.

Re: Git/gerrit migration status and next steps

Am 07.09.2011 10:29, schrieb Nils Wallménius: I think it could be interesting to test it actually. Testing it will probably show that it works in the beginning, but it will not show that this way degrades to clicking away commits like ads (without even looking) in the long (or even short) t

Re: Git/gerrit migration status and next steps

> This isn't about people doing the wrong thing. This is about trying to get > code quality. And yes it will be a minor pain sometimes, but a small fix has > just as much fuck-up-ability as a big one and is *easier* to sanity check > then the required debugging later. > > T

Re: Git/gerrit migration status and next steps

I think it could be interesting to test it actually. Nils

Re: Git/gerrit migration status and next steps

o sanity check > then the required debugging later. > > This is something gerrit makes easy and we should absolutly do it. Remember > that you push directly to gerrit, this doesn't require you to open your > browser. That isn't the problem. The problem is that we wou

Re: Git/gerrit migration status and next steps

On 07/09/11 08:42, bryan.chi...@rbs.com wrote: Do we really want to allow commits directly? so little of our code ever gets reviewed so I would quite happily force everyone to go through gerrit and require someone else to OK it. It isnt hard to get someone else in IRC to have a quick look and

RE: Git/gerrit migration status and next steps

On Sep 7, 2011 5:43 PM, wrote: > > > Do we really want to allow commits directly? so little of our code ever gets > > reviewed so I would quite happily force everyone to go through gerrit and > > require someone else to OK it. It isnt hard to get someone else in IRC to have

RE: Git/gerrit migration status and next steps

>> Do we really want to allow commits directly? so little of our code ever >> gets >> reviewed so I would quite happily force everyone to go through gerrit >> and >> require someone else to OK it. It isnt hard to get someone else in IRC >> to have

Re: Git/gerrit migration status and next steps

On Wed, Sep 7, 2011 at 2:36 AM, Jonathan Gordon wrote: > Why? Just come in irc and ask someone to press the button. They don't need > to do a full blown revue Why do we need that step if they aren't even expected to review the code? What do we gain from "ask someone to press a button without revi

Re: Git/gerrit migration status and next steps

On Wednesday, 7. September 2011 09:42:12 bryan.chi...@rbs.com wrote: > > Do we really want to allow commits directly? so little of our code ever > > gets reviewed so I would quite happily force everyone to go through > > gerrit and require someone else to OK it. It isnt h

RE: Git/gerrit migration status and next steps

> Do we really want to allow commits directly? so little of our code ever gets > reviewed so I would quite happily force everyone to go through gerrit and > require someone else to OK it. It isnt hard to get someone else in IRC to have > a quick look and push the button. Absolu

Re: Git/gerrit migration status and next steps

On Sep 7, 2011 5:32 PM, "Marcin Bukat" wrote: > > 2011/9/7 Jonathan Gordon : > > On 7 September 2011 00:40, Torne Wuff wrote: > >> > >> 4) We write up policies and documentation on how to use git via > >> gerrit, though only two parts are crucial

Re: Git/gerrit migration status and next steps

2011/9/7 Jonathan Gordon : > On 7 September 2011 00:40, Torne Wuff > wrote: >> >> 4) We write up policies and documentation on how to use git via >> gerrit, though only two parts are crucial at this point: how to clone >> the repositories, and how committers

Re: Git/gerrit migration status and next steps

On 7 September 2011 00:40, Torne Wuff wrote: > > 4) We write up policies and documentation on how to use git via > gerrit, though only two parts are crucial at this point: how to clone > the repositories, and how committers can commit directly to master. > Do we really want t

Re: Git/gerrit migration status and next steps

Am 06.09.2011 16:40, schrieb Torne Wuff: Next steps (pretty much in this order): Sounds like a really great plan, looking forward to it. FWIW, just wanted to share the experience of someone else experimenting with svn to git conversion (using svn2git): http://lists.uvena.de/geany-devel/2011

Git/gerrit migration status and next steps

Hi folks, Apologies for not doing anything about this for a while; I have been very busy with other stuff (and/or lazy). I want to sum up where we are now and what the next steps are, and give people a chance to comment on those next steps if needed. Current status: 1) Gerrit is running on a

Re: Git migration: try out Gerrit!

On Tue, Jun 21, 2011 at 10:30:43AM -0600, Leif Andersen wrote: > Yes, that did work. Perhaps a note about that should be added to the wiki, > unless that's widely known and I was just out of the loop. Already done, and I've reported a bug to Gerrit[1]. [1] http://code.google.com

Re: Git migration: try out Gerrit!

gt; There is a little discrepancy between the wiki page and the actual > process, > > when creating the account. The wiki page says: > > > > You can run your own if you think that's a good idea; Gerrit doesn't care > > > where your OpenID?< >

Re: Git migration: try out Gerrit!

On Tue, Jun 21, 2011 at 10:10:25AM -0600, Leif Andersen wrote: > There is a little discrepancy between the wiki page and the actual process, > when creating the account. The wiki page says: > > You can run your own if you think that's a good idea; Gerrit doesn't care >

Re: Git migration: try out Gerrit!

There is a little discrepancy between the wiki page and the actual process, when creating the account. The wiki page says: You can run your own if you think that's a good idea; Gerrit doesn't care > where your > OpenID?<http://www.rockbox.org/wiki/bin/edit/Main

Git migration: try out Gerrit!

Hi folks, We're looking at how to host the Rockbox git repository and currently Gerrit seems like a good choice for that and also for hosting code reviews. However, I want to make sure committers and other contributors have a chance to try it out and provide feedback before we go ahea