use case is: I have restart sleep timer when switching on set to yes,
and reset timer when touching any buttons set to yes. At night, I set the
sleep timer to 15 minutes, and fall asleep at some point listening to music
(maybe switching it back on if I don't fall asleep right away
://gerrit.rockbox.org/327
http://gerrit.rockbox.org/328
My use case is: I have restart sleep timer when switching on set to yes,
and reset timer when touching any buttons set to yes. At night, I set the
sleep timer to 15 minutes, and fall asleep at some point listening to music
(maybe switching it back on if I
On Sat, Oct 6, 2012 at 2:16 PM, Richard Quirk richard.qu...@gmail.com wrote:
Thanks for reviewing that. Unfortunately I missed a set_sleep_timer in 327,
but did not spot the compiler output as I had 327 and 328 staged on the same
branch. Clean up here http://gerrit.rockbox.org/329 :-(
Too
On 10/06/2012 03:22 PM, Dominik Riebeling wrote:
On Sat, Oct 6, 2012 at 2:16 PM, Richard Quirk richard.qu...@gmail.com wrote:
Thanks for reviewing that. Unfortunately I missed a set_sleep_timer in 327,
but did not spot the compiler output as I had 327 and 328 staged on the same
branch. Clean up
On 16/04/2012 12:32, Richard Fröhning wrote:
So I reverted the sleeptimer duration to an int menu and added a menu
point Run Sleep Timer (bool),
which starts/stops the timer duration and resets it - if started, and
runs the the StartOnBootTimer if enabled
Now you can easily add every single
Am 17.04.2012 09:34, schrieb Nick Peskett:
On 16/04/2012 12:32, Richard Fröhning wrote:
So I reverted the sleeptimer duration to an int menu and added a menu
point Run Sleep Timer (bool),
which starts/stops the timer duration and resets it - if started, and
runs the the StartOnBootTimer
with the way I'd split it, if a user was
always choosing different sleep timer durations, it would be two menu
options instead of one.
first I liked your idea to integrate the sleeptimer and cancel and show
the time left into one menu line.
Only later I saw you cant add this function to the quick
was
always choosing different sleep timer durations, it would be two menu
options instead of one.
I might have imagined it though, I just bookmarked the logs at the time
and haven't gone back through them since.
I've submitted a version of the original split for review.
http://gerrit.rockbox.org/201
Hi,
This wasnt caught when the sleep timer changes were commited, and its
not really a big deal but it should be changed.
IIUC the sleep timer is now broken into a few different settings:
1) set timer on boot
2) restart timer on keypress
3) start the timer with the chosen minutes value
On 28 March 2012 01:05, Nick Peskett rock...@peskett.co.uk wrote:
Unfortunately this has been the case with the callback since 2007;
http://svn.rockbox.org/viewvc.cgi/trunk/apps/menus/main_menu.c?view=diffpathrev=30777r1=12548r2=12549
As you move through the menu items the sleep timer
On 21/12/2011 17:44, Al Le wrote:
On 21.12.2011 16:17, Al Le wrote:
I would interpret the spirit (if not the letter) of Al Le's comment
to be a
vote for Startup/Shutdown rather than System.. :-)
Correct :-) I was just not brave enough to propose a new submenu.
Actually, I don't care where
So depending on whether the consensus is (1) a new sleep timer option
(my preference), (2) permanently restarting on keypress or (2) no patch
applied at all, what do people think about the following?
1;
Settings
...
Playback Settings
General Settings
System
Rather than putting these under System settings (which I kindof feel should
be reserved for things like hardware disk/battery/limits things), how about
a new Startup/Shutdown menu, to contain all of those items? (And leaving
the RTC Time/Date settings in their own Time/Date menu still)
By 'all those items ', i mean: start screen, idle power off, sleep timer,
alarm (iff device has RTC)
On 22 December 2011 00:31, Nick Peskett rock...@peskett.co.uk wrote:
The root of what I'd like to change; only clock related options having a
stonking great clock embedded at top of the menu, all non-RTC options having
a permanent home.
yeah, the system settings submenu :)
On 21/12/2011 13:43, Jonathan Gordon wrote:
On 22 December 2011 00:31, Nick Peskettrock...@peskett.co.uk wrote:
The root of what I'd like to change; only clock related options having a
stonking great clock embedded at top of the menu, all non-RTC options having
a permanent home.
yeah, the
I would interpret the spirit (if not the letter) of Al Le's comment to be a
vote for Startup/Shutdown rather than System.. :-)
On 21.12.2011 16:17, Al Le wrote:
I would interpret the spirit (if not the letter) of Al Le's comment to be a
vote for Startup/Shutdown rather than System.. :-)
Correct :-) I was just not brave enough to propose a new submenu.
Actually, I don't care where exactly it is as long as it is in
Hi,
There's currently a couple of sleep timer options, one to start/ cancel
the timer, one to start it at boot.
If there's a RTC (real time clock) they live in the Time Date sub menu;
Settings
...
Recording Settings
Time Date
Set Time/Date
Sleep Timer
Start Sleep Timer
May I propose a 3rd alternative, instead?
As you mentioned, the sleep timer has more in common with the idle
poweroff. So, for your new feature, how about merging idle power off and
sleep timer to an inactivity timer, with the additional option of
whether to run during playback (yes
On 20/12/2011 14:26, Thomas Martitz wrote:
May I propose a 3rd alternative, instead?
As you mentioned, the sleep timer has more in common with the idle
poweroff. So, for your new feature, how about merging idle power off and
sleep timer to an inactivity timer, with the additional option
On 13 October 2011 19:48, Thomas Martitz ku...@rockbox.org wrote:
Am 13.10.2011 10:42, schrieb Thomas Martitz:
Alright, thanks for the comments discussion. I'll commit part 1) (move TD
to settings) and 3) (the actual sleep timer remake) and leave the
System-About rename out for now
Jonathan Gordon wrote:
So one objection isnt enough? commit the sleep timer rework by all
means, but dont move td unless the rest of the discusison is settled.
Your objection as I understood it was that the patch does less than you'd like,
not that what it does is wrong
On 15 October 2011 20:53, Björn Stenberg bj...@haxx.se wrote:
Jonathan Gordon wrote:
So one objection isnt enough? commit the sleep timer rework by all
means, but dont move td unless the rest of the discusison is settled.
Your objection as I understood it was that the patch does less than
Am 15.10.2011 12:01, schrieb Jonathan Gordon:
Your objection as I understood it was that the patch does less than you'd like,
not that what it does is wrong. If that is a misunderstanding, could you please
clarify your stance?
--
Björn
No, that's correct.
I would like to commit it
Jonathan Gordon wrote:
Your objection as I understood it was that the patch does less than you'd
like, not that what it does is wrong.
No, that's correct.
Then I think the commit can go ahead. This might only be a small part of what
some of us want to do, but the other parts (total menu
discussion. I'll commit part 1) (move
TD to settings) and 3) (the actual sleep timer remake) and leave the
System-About rename out for now.
Best regards.
Am 13.10.2011 10:42, schrieb Thomas Martitz:
Alright, thanks for the comments discussion. I'll commit part 1) (move
TD to settings) and 3) (the actual sleep timer remake) and leave the
System-About rename out for now.
That is, in a few hours if there's no further objection.
Am 10.10.2011 00:31, schrieb Jonathan Gordon:
Is this a strong objection, or just stating that the patches don't go far
enough in your opinion?
Best regards.
My position since the start of this thread has not changed. Any patch
which doesnt remove either settings or system from the top level
Thomas Martitz wrote:
I find an about menu in the main menu a nice fit.
It's rather unorthodox though. About is usually an option in the Help menu,
showing version and some basic credits. It's not where you find system or debug
information.
I think the time and timer setting changes are fine.
Am 10.10.2011 09:17, schrieb Björn Stenberg:
I think the time and timer setting changes are fine. But I don't see
how the System - About rename has any connection to it, and I would
prefer having that in a separate patch.
It is a separate patch, actually :)
Best regards.
Thomas Martitz wrote:
It is a separate patch, actually :)
I mean a separate patch discussion, and a separate commit.
--
Björn
About is the main menu is a whole bunch of wrong, in my opinion. It should
be a System/Settings (whatever it gets called) sub-menu.
I don't see it as being important enough to deserve a placement right off
the main menu, and I'm hoping I'm not the only one...
I wish I could count the times I
of a discssion, and a few people liked renaming to about.
But I won't fight for committing it as part of the td movement and
sleep timer patches, it's a really simple and independant patch that can
be dealt with later.
About is the main menu is a whole bunch of wrong, in my opinion. It
should
:
* Sleep Timer offers the last-used timer value as its default.
(This value is made persistent by way of the settings code.) When
the timer is running, the entry changes to Cancel Sleep Timer
(hh:mm), showing the remaining time.
* Add Start sleep timer on boot option after Alarm Wake
On 10 October 2011 01:38, Thomas Martitz ku...@rockbox.org wrote:
Bah,
Move the whole System menu into settings and call it whatever you
want. It really doesnt deserve such a high placement in the menu
system
Is this a strong objection, or just stating that the patches don't go far
enough
Am 23.08.2011 01:08, schrieb sideral:
So here's the plan:
* Move the entire Time Date menu out of System to Settings
* Rename System to About
* In the Time Date menu:
* Sleep Timer offers the last-used timer value as its default.
(This value is made persistent by way
On 9 October 2011 12:31, Thomas Martitz ku...@rockbox.org wrote:
Am 23.08.2011 01:08, schrieb sideral:
So here's the plan:
* Move the entire Time Date menu out of System to Settings
* Rename System to About
* In the Time Date menu:
* Sleep Timer offers the last-used timer value
Am 23.08.2011 01:08, schrieb sideral:
So here's the plan:
* Move the entire Time Date menu out of System to Settings
* Rename System to About
* In the Time Date menu:
* Sleep Timer offers the last-used timer value as its default.
(This value is made persistent by way of the settings
interested in the menu
layout, and I will not anticipate the result by committing any menu
change now.
Also, everyone agreed that the sleep-timer enhancements are not blocked
by any menu change, so the following part of the plan is still in place:
* In the Time Date menu:
* Sleep Timer offers
On 27/09/2011 09:21, Thomas Martitz wrote:
Am Di, 27.09.2011, 08:41 schrieb Nick Peskett:
It seems something unexpected came up in the last month...
Would anyone else mind checking the patch with a view to checking it in?
Thanks for reminding. I expected the countdown difficult to be to do
On Tuesday, 27. September 2011 10:36:33 Nick Peskett wrote:
I've a feeling if this has to be decided before it can go in, it'll
never happen.
That was exactly my point, too ;)
Thomas
it's
fine to do that change along with the proposed sleep-timer
extensions. [...]
So here's the plan:
* Move the entire Time Date menu out of System to Settings
* Rename System to About
[...]
I disagree with [...] this change.
After much IRC
On 28 August 2011 06:15, Thomas Martitz ku...@rockbox.org wrote:
Its unfortunate that you let the single hypocrite win. Really everyone else
agreed with moving td to settings.
Perhaps I'll just move it afterwards...just cause.
Best regards.
how to win friends and influence people (y)
the TD menu move) was wrong.
Discussions are still ongoing on how to change the menu in the short and
long term. Personally, I'm only marginally interested in the menu
layout, and I will not anticipate the result by committing any menu
change now.
Also, everyone agreed that the sleep-timer
alex wallis alexwallis...@googlemail.com writes:
all of the above sounds good, I do have a suggestion which I think
could be useful for the rockbox voice users such as myself.
I think its very good that the sleep timer menu will now show the
remaining time, but the sleep timer menu takes
I recall I asked some time ago why TimeDate is under System and not
Settings. The answer was that this is self changing parameter while
all others settings in rb are not. Still I think TimeDate belongs to
Settings and anyone is familiar with the fact that time passes away
and you can do nothing
On 23/08/11 00:08, sideral wrote:
Given that it looks like there's overwhelming support for (and little to
no concern about) moving Time Date to Settings, I now think it's fine
to do that change along with the proposed sleep-timer extensions. Also,
I'd like to pick up Thomas Martitz's proposal
On Mon, Aug 22, 2011 at 7:32 PM, Jonathan Gordon jdgo...@gmail.com
wrote:
What has how you set it got anything to do with it being a setting or
not? Time does not magically change when you give your DAP to your
sibling.
No, but it changes when you enter another time zone. Or daylight
snip
all of the above sounds good.
changes to Cancel Sleep Timer (hh:mm), showing the remaining
time.
all of the above sounds good, I do have a suggestion which I think could
be useful for the rockbox voice users such as myself.
I think its very good that the sleep timer menu will now show
Am 23.08.2011 01:08, schrieb sideral:
So here's the plan:
* Move the entire Time Date menu out of System to Settings
* Rename System to About
* In the Time Date menu:
* Sleep Timer offers the last-used timer value as its default.
(This value is made persistent by way of the settings
Given that it looks like there's overwhelming support for (and little to
no concern about) moving Time Date to Settings, I now think it's fine
to do that change along with the proposed sleep-timer extensions. Also,
I'd like to pick up Thomas Martitz's proposal and get rid of an explicit
setting
On 23 August 2011 09:08, sideral side...@rockbox.org wrote:
Given that it looks like there's overwhelming support for (and little to
no concern about) moving Time Date to Settings, I now think it's fine
to do that change along with the proposed sleep-timer extensions. Also,
I'd like to pick
On Mon, Aug 22, 2011 at 7:10 PM, Jonathan Gordon jdgo...@gmail.com wrote:
I disagree with the first part of this change.
Time date doesnt make any more sense in settings than it does in
system (or info if you want to rename it). timedate isnt a
setting. And it does make sense to keep
On 23 August 2011 10:27, Paul Louden paulthen...@gmail.com wrote:
On Mon, Aug 22, 2011 at 7:10 PM, Jonathan Gordon jdgo...@gmail.com wrote:
I disagree with the first part of this change.
Time date doesnt make any more sense in settings than it does in
system (or info if you want to rename
On Mon, Aug 22, 2011 at 7:32 PM, Jonathan Gordon jdgo...@gmail.com wrote:
What has how you set it got anything to do with it being a setting or
not? Time does not magically change when you give your DAP to your
sibling.
No, but it changes when you enter another time zone. Or daylight
savings
Am Dienstag, 16. August 2011, 21:00:19 schrieb Thomas Jarosch:
Here's another proposal: Commit the patch with the suggested changes (so
that manual sleep timer selection is still possible) and then discuss how
things should go further in the future (like renaming 'System' to 'About'
etc
change to it.
Here's another proposal: Commit the patch with the suggested changes (so that
manual sleep timer selection is still possible) and then discuss how things
should go further in the future (like renaming 'System' to 'About' etc.).
Best regards,
Thomas
the sleep timer stuff together?
How about this one:
*** Settings General System Sleep timer ***
Default sleep timer duration (time)
Start at boot (yes/no)
*** System (Date Time) menu ***
Start sleep timer - Brings back the old sleep timer selector
with the default sleep timer duration selected
to actually start it?
Can't we think of some way of having all the sleep timer stuff together?
How about this one:
*** Settings General System Sleep timer ***
Default sleep timer duration (time)
Start at boot (yes/no)
*** System (Date Time) menu ***
Start sleep timer - Brings back
Let me respond to three messages in this thread in just one reply.
Alex Parker parker.ale...@gmail.com writes:
Can't we think of some way of having all the sleep timer stuff
together?
That's a good question. Right now almost all functions have their
configuration sitting in the (separate
On 15/08/11 12:33, sideral wrote:
Thomas Jaroscht...@simonv.com writes:
How about this one:
*** Settings General System Sleep timer ***
Default sleep timer duration (time)
Start at boot (yes/no)
*** System (Date Time) menu ***
Start sleep timer - Brings back the old sleep timer
Am 15.08.2011 12:33, schrieb sideral:
Let me respond to three messages in this thread in just one reply.
Alex Parkerparker.ale...@gmail.com writes:
Can't we think of some way of having all the sleep timer stuff
together?
That's a good question. Right now almost all functions have
Am 15.08.2011 16:00, schrieb Menachem:
do you then have to re-cancel the current timer every time you start
the player again?
Only if you enabled the start sleep timer on boot setting.
Can anyone enlight me why one would want to enable that?
Best regards.
On 16/08/2011 2:09 AM, Thomas Martitz ku...@rockbox.org wrote:
Am 15.08.2011 16:00, schrieb Menachem:
do you then have to re-cancel the current timer every time you start the
player again?
Only if you enabled the start sleep timer on boot setting.
Can anyone enlight me why one would
Its speculation of course but I'd be reasonably willing to guess that
most new users would actually expect Time Date to be in Settings,
moving it out would also leave the System menu for System-esque things
that a normal user most likely won't touch in the course of normal
operation (Rockbox
FWIW, we might as well rename the System menu to About once we have
done this. This seems to be the name that most other programs use for a
menu with that kind of contents. Any thoughts?
That sounds like a good idea to me. It's maybe a bit odd to have Debug under
About, but not really an
On 16/08/2011 7:18 AM, Dave Hooper d...@beermex.com wrote:
FWIW, we might as well rename the System menu to About once we have
done this. This seems to be the name that most other programs use for a
menu with that kind of contents. Any thoughts?
That sounds like a good idea to me. It's
Thomas Martitz ku...@rockbox.org writes:
Am 15.08.2011 12:33, schrieb sideral:
I agree with most of what [Hayden] said, but I'd prefer to discuss
the best placement of the Time Date menu and the sleep timer
separately from the present patch.
Perhaps it would be a good idea to discuss
On 15/08/11 23:13, Mike Giacomelli wrote:
Thomas Martitz ku...@rockbox.org writes:
Am 15.08.2011 12:33, schrieb sideral:
I agree with most of what [Hayden] said, but I'd prefer to discuss
the best placement of the Time Date menu and the sleep timer
separately from the present
On 16/08/2011 8:55 AM, sideral side...@rockbox.org wrote:
By default, options for System functions belong into this
system-settings submenu. This is the settings submenu that comes up
when you long-select the System menu in the main menu.
You're aware this menu is a duplicate of Settings -
Am Sonntag, 14. August 2011, 01:05:38 schrieb sideral:
I'd like to commit FS#10849, which introduces two new features for the
sleep timer: The sleep duration is now a setting, so it's persistent
across reboots and doesn't have to be set each time the sleep timer is
used;
I'm testing
that to two:
Duration (time)
Sleep Timer (off/once/always)
where if sleep timer is set to once it will be activated, but on next
boot will be set to off again. If set to always it will always be
activated at boot.
I don't actually mind which way is used, and am just throwing the other
option out
), the latter is a function (found in the System [-
TimeDate]) menu.
What about condensing that to two:
Duration (time)
Sleep Timer (off/once/always)
where if sleep timer is set to once it will be activated, but on next
boot will be set to off again.
That won't work so nicely as the two menu entries
Thomas Jarosch t...@simonv.com writes:
I'm testing that exact patch since yesterday. The only big difference
in usage (for me) is the persistent sleep timer value: Until now I
always chose a value depending on how sleepy I was. So it was either
15 minutes or 30 minutes.
Thanks for your
rather irritating for those of us that set a different time
each time depending on circumstances - I now have to go into one menu to
set the time, then another to actually start it?
Can't we think of some way of having all the sleep timer stuff together?
Alex
rather irritating for those of us that set a different time
each time depending on circumstances - I now have to go into one menu to
set the time, then another to actually start it?
Can't we think of some way of having all the sleep timer stuff together?
Alex
Fellow Rockbox hackers,
I'd like to commit FS#10849, which introduces two new features for the
sleep timer: The sleep duration is now a setting, so it's persistent
across reboots and doesn't have to be set each time the sleep timer is
used; and an option to engage the sleep timer on each boot
On Sun, Aug 14, 2011 at 01:05:38AM +0200, sideral wrote:
I'd like to commit FS#10849
I don't use the sleep timer myself (in fact, I think I never even tried
it), so I'm not sure how much my opinion is worth here.
I think that the patch adds real functionality that's hard to achieve by
other
of the code relating to
the
sleep timer into /apps/settings_list.c out of main_menu.c it also adds an
int into settings.h
the things that I am not sure about when I am resyncing are an if
statement
that relates to if a target has an rtc, if I need to stick that in
/apps/settings_list.c
which is for r. 18277.
I would appreciate any advice. I can post the latest sync I do have to the
tracker if that would help. There are just a few lines that have been added
in since the last sync
As far as I can tell, fs#8630 simply moves most of the code relating to the
sleep timer into /apps
hi list, I have just been having a few thoughts about the sleep timer.
I was wondering,
is there any interest in reviving patch 8630 to allow the last used value of
the sleep timer to be saved to the cfg file?
I asked about this some time ago, and nobody liked the idea, but I don't think
anyone
alex wallis wrote:
hi list, I have just been having a few thoughts about the sleep timer.
I was wondering, is there any interest in reviving patch 8630 to allow the
last used value of the sleep timer to be saved to the cfg file?
I asked about this some time ago, and nobody liked the idea, but I
alex wallis wrote:
hi list, I have just been having a few thoughts about the sleep timer.
I was wondering, is there any interest in reviving patch 8630 to allow
the last used value of the sleep timer to be saved to the cfg file?
I asked about this some time ago, and nobody liked the idea
alex wallis wrote:
perhaps a solution for this could be that the player could automatically
pause the file you were listening to, say the voice message and then
resume playback.
You don't need a voice message for this. It's enough to wait a few seconds
(sth. like 10) after the music has
Linus Nielsen Feltzing wrote:
alex wallis wrote:
hi list, I have just been having a few thoughts about the sleep
timer.
I was wondering, is there any interest in reviving patch 8630 to
allow the last used value of the sleep timer to be saved to the cfg
file?
I asked about this some time
I can see the benefits of an LRU menu, but one potential problem
jumps out at me.
If you often use, errr, Bass and Treble and Mid
would you add all three to the LRU menu or would it be better to add
Sound to the LRU?
I still think that a user-config menu would be best (nothing new here)
My
Bluechip wrote:
I can see the benefits of an LRU menu, but one potential problem jumps
out at me.
If you often use, errr, Bass and Treble and Mid
would you add all three to the LRU menu or would it be better to add
Sound to the LRU?
Ok, thats a valid point. I think I'd put all three in,
if you have what it takes to compile the source code, just edit the
menu structure and put the functions you desire in the main menu :)
When 3.0 is released I will give consideration to upgrading
myself. If I do that, sleep timer will make it to root anyway and I
will also be up to date
Hello...
Bluechip wrote:
if you have what it takes to compile the source code, just edit the menu
structure and put the functions you desire in the main menu :)
I happen to have done a nasty patch that gives you another menu on the
F3-Key, which of course is less crowded than the F1-Menu...
I
90 matches
Mail list logo
