[Citadel Development] Re: [patch] inline images POC

2008-11-03 Thread IGnatius T Foobar
Sam: I'm afraid we can't accept this patch. Inline images are something we definitely want, but your patch integrates libtidy/libxslt/libxml into the system as well. As I mentioned before, we are not willing to add all of those new external dependencies to the Citadel system at this time. If

[Citadel Development] Re: [patch] inline images POC

2008-11-03 Thread samjam
Mon Nov 03 2008 09:26:06 EST from IGnatius T [EMAIL PROTECTED] Subject: Re: [patch] inline images POC Sam: I'm afraid we can't accept this patch. Inline images are something we definitely want, but your patch integrates libtidy/libxslt/libxml into the system as well. As I mentioned

[Citadel Development] Re: [patch] inline images POC

2008-11-03 Thread IGnatius T Foobar
Yeah... fair enough.(libtidy is NOT needed, just haven't taken it out) Thanks for understanding ... definitely don't take it personally, we'd love to have some of your code committed to the tree in the future. As for libtidy ... can it be used without an xml parser? I suppose you've

[Citadel Development] Re: [patch] inline images POC

2008-11-03 Thread samjam
Mon Nov 03 2008 10:04:33 EST from IGnatius T [EMAIL PROTECTED] Subject: Re: [patch] inline images POC Yeah... fair enough.(libtidy is NOT needed, just haven't taken it out) Thanks for understanding ... definitely don't take it personally, we'd love to have some of your code committed to

[Citadel Development] Re: [patch] inline images POC

2008-11-01 Thread samjam
I guess it would be nice for the image button dialog to allow uploading; it shouldn't be too hard; the upload handler would issue a redirect back to the image button dialog with thye uploaded image already selected. I don't think I'll have time to do that today; but I await feedback. I apologise