Re: [ros-dev] [ros-diffs] [hbelusca] 62662: [NTDLL_APITEST]: Add braces and remove an unneeded trace.

2014-04-06 Thread Thomas Faber
This will make any failure messages in the loop useless, since you won't know which test they're about. Just because the tests are succeeding now doesn't mean they always will. On 2014-04-06 17:51, hbelu...@svn.reactos.org wrote: > @@ -188,7 +190,6 @@ > > for (i = 0; i < TestCount; i++) >

Re: [ros-dev] [ros-diffs] [khornicek] 62665: [MAIN] - fix a copypasta - fix a possible buffer overrun (x5) - fix a negative array index access

2014-04-06 Thread Thomas Faber
You guys should consider replacing that stuff with strsafe functions while you're at it ;) On 2014-04-06 18:45, khorni...@svn.reactos.org wrote: > Author: khornicek > Date: Sun Apr 6 16:45:21 2014 > New Revision: 62665 > > URL: http://svn.reactos.org/svn/reactos?rev=62665&view=rev > Log: > [MAI

Re: [ros-dev] [ros-diffs] [hbelusca] 62662: [NTDLL_APITEST]: Add braces and remove an unneeded trace.

2014-04-06 Thread Hermès BÉLUSCA - MAÏTO
Ok so in fact, this think must be generalized to each time we have tests in form of a loop :) -Message d'origine- De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Thomas Faber Envoyé : dimanche 6 avril 2014 18:10 À : ros-dev@reactos.org Objet : Re: [ros-dev] [ros-diffs] [hbe

Re: [ros-dev] [ros-diffs] [hbelusca] 62662: [NTDLL_APITEST]: Add braces and remove an unneeded trace.

2014-04-06 Thread Thomas Faber
Yes, it's a common pattern. The nice way is just to have all ok() prints in the loop include the index. I'm sometimes too lazy for that though so I add traces like this one. On 2014-04-06 20:02, Hermès BÉLUSCA - MAÏTO wrote: > Ok so in fact, this think must be generalized to each time we have test

[ros-dev] Short announce: My Serial port-on-MMIO implementation works - allowing debug logging on laptops

2014-04-06 Thread Minas Abrahamyan
Hi all, With this few words I would like to share the joyous event of MMIO-based serial port implementation has finally worked for me. This is the equivalent of earlycon serial port implementation in Linux with some extension (so now it is even better then Linux one) Some work yet is needed to be

Re: [ros-dev] [ros-diffs] [khornicek] 62665: [MAIN] - fix a copypasta - fix a possible buffer overrun (x5) - fix a negative array index access

2014-04-06 Thread Kamil Hornicek
There's too many of these and I personally don't want to introduce more bugs (confusing src and dest etc) because there's no way I can properly test all of them. Maybe someone would pick this up if we offered to pay for it. K. Dne 6.4.2014 18:53, Thomas Faber napsal(a): You guys should consi

Re: [ros-dev] Short announce: My Serial port-on-MMIO implementation works - allowing debug logging on laptops

2014-04-06 Thread Aleksey Bragin
Minas, that's just great! Do you mind including that to trunk? Regards, Aleksey Bragin On 06.04.2014 22:37, Minas Abrahamyan wrote: Hi all, With this few words I would like to share the joyous event of MMIO-based serial port implementation has finally worked for me. This is the equivalent

Re: [ros-dev] [ros-diffs] [pschweitzer] 62675: [CHARMAP] Use rather wcsncpy(). A bit less safe, but at least, data are copied till possible

2014-04-06 Thread Timo Kreuzer
I don't really see the reason here. Whether using the secure function or not is is a question of whether we need null-termination or not. If we need it the secure function will do the right thing. If we do not need null-termination the non-secure function does the right thing and the secure functi

Re: [ros-dev] Short announce: My Serial port-on-MMIO implementation works - allowing debug logging on laptops

2014-04-06 Thread Hermès BÉLUSCA - MAÏTO
Maybe it can go along cportlib :) Hermès. De : Ros-dev [mailto:ros-dev-boun...@reactos.org] De la part de Aleksey Bragin Envoyé : dimanche 6 avril 2014 22:16 À : ReactOS Development List Objet : Re: [ros-dev] Short announce: My Serial port-on-MMIO implementation works - allowing debug loggi

Re: [ros-dev] [ros-diffs] [pschweitzer] 62675: [CHARMAP] Use rather wcsncpy(). A bit less safe, but at least, data are copied till possible

2014-04-06 Thread Pierre Schweitzer
Actually, it was based on my observation of: http://doxygen.reactos.org/dc/d77/wcs_8c_afce6ecc002302f621f1280446ee5ae77.html#afce6ecc002302f621f1280446ee5ae77 http://doxygen.reactos.org/d1/d60/tcsncpy_8h_source.html My point was not to break program behavior by producing empty strings. Actually, w

Re: [ros-dev] [ros-diffs] [pschweitzer] 62675: [CHARMAP] Use rather wcsncpy(). A bit less safe, but at least, data are copied till possible

2014-04-06 Thread Thomas Faber
On 2014-04-07 07:58, Pierre Schweitzer wrote: > My (naive) guess, would be as I did on CDFS: copy len - 1 and 0 last char. StringCbCopyW will do just that :) ___ Ros-dev mailing list Ros-dev@reactos.org http://www.reactos.org/mailman/listinfo/ros-dev