Re: [ros-dev] win32k C++ suggestion

2015-02-21 Thread Jerome Gardou
Hi Timo, I'd say go for it. I have no strong objection to introduce some changes before 0.4.0, as long as it's not too intrusive or add some real added value (unimplemented modules/parts). I'd like to have it for more than for simplification sake. Some parts of win32k are in a sorry state

Re: [ros-dev] [ros-diffs] [jgardou] 66334: [NTOSKRNL/MM] - MiIsEntireRangeCommitted: Ensure the PTE we are checking is really faulted in. - Prefer MiPteToPde and MiPdeToPte (which should really be cal

2015-02-21 Thread Jerome Gardou
It is possible that the entire VAD range is not committed, so we have to sweep over all the PTEs in the sub-range to check. If one of the PTEs is zero AND the entire VAD is not marked as committed, then we're sure that the range is not committed. Also, if the PTE is marked as decommitted, same

Re: [ros-dev] [ros-diffs] [jgardou] 66334: [NTOSKRNL/MM] - MiIsEntireRangeCommitted: Ensure the PTE we are checking is really faulted in. - Prefer MiPteToPde and MiPdeToPte (which should really be cal

2015-02-21 Thread Timo Kreuzer
I was thinking that a VAD with the Committed flag set would be entirely committed, so we could avoid all PTE checking. But I guess the flag stays set, even if we decommit ranges inside it. In that case it's clear that we need to check for decommitted pages. Regarding your change, I see the

Re: [ros-dev] win32k C++ suggestion

2015-02-21 Thread Aleksey Bragin
I always liked C++, and it was my main development language before I joined ReactOS. Indeed let's not rush, think/discuss through all possible things and then start gradually going for it for code pieces which are good (which means GDI first of all). Regards, Aleksey On 21.02.2015 17:05,

[ros-dev] win32k C++ suggestion

2015-02-21 Thread Timo Kreuzer
Hi I'd like to propose introducing C++ to win32k. Don't worry, this is not a suggestion to rewrite everything from scratch in C++, but to gradually introduce C++. The reason is not That's what Windows does, but the fact that especially GDI would heavily benefit in terms of code simplicity,

Re: [ros-dev] [ros-diffs] [gadamopoulos] 66383: [SHELL32] - Implement progress dialogs for SHFileOperation - Patch by Hwu Davies CORE-4476

2015-02-21 Thread Pierre Schweitzer
In such situations, please update all the langages files and not only English. This makes work easier for translators to track changes. On 21/02/2015 13:52, gadamopou...@svn.reactos.org wrote: Author: gadamopoulos Date: Sat Feb 21 12:52:58 2015 New Revision: 66383 URL: