Re: [Rosegarden-devel] Re: [Rosegarden-user] SysEx right on time but empty

2006-01-31 Thread Chris Cannam
On Tuesday 31 Jan 2006 21:22, Pedro Lopez-Cabanillas wrote: > What about calling to DataBlockRepository::clear() at ~AlsaDriver() > destructor? Hm, I added a call to that from AlsaDriver::shutdown() (called from dtor) but it looks like I forgot to commit it. I tested it and I'm pretty sure it d

Re: [Rosegarden-devel] Re: [Rosegarden-user] SysEx right on time but empty

2006-01-31 Thread Pedro Lopez-Cabanillas
On Tuesday 31 January 2006 13:04, Chris Cannam wrote: > OK, I've committed what I think is a fix. The superficial problem (no data > block ID set for mapped events created at the sequencer side) turned out to > also mask a deeper problem (separate data block ID counts at GUI and > sequencer meant

Re: [Rosegarden-devel] Re: [Rosegarden-user] SysEx right on time but empty

2006-01-31 Thread Chris Cannam
On Monday 30 Jan 2006 21:40, Pedro Lopez-Cabanillas wrote: > On Monday 30 January 2006 21:56, Pedro Lopez-Cabanillas wrote: > > I guess that there should be an explicit > > call to registerDataBlockForEvent somewere before setDataBlockForEvent() > > in AlsaDriver.cpp:2470, right? > > No. First, reg

Re: [Rosegarden-devel] Re: [Rosegarden-user] SysEx right on time but empty

2006-01-30 Thread Pedro Lopez-Cabanillas
On Monday 30 January 2006 23:54, Guillaume Laurent wrote: > registerDataBlockForEvent() is called at the construction of a MappedEvent > if the event's type is a sysex (see MappedEvent.cpp:115). Yes. Quoting myself: "In MappedEvent.cpp:115 there is a call to registerDataBlockForEvent, but this co

Re: [Rosegarden-devel] Re: [Rosegarden-user] SysEx right on time but empty

2006-01-30 Thread Guillaume Laurent
On Monday 30 January 2006 22:40, Pedro Lopez-Cabanillas wrote: > On Monday 30 January 2006 21:56, Pedro Lopez-Cabanillas wrote: > > I guess that there should be an explicit > > call to registerDataBlockForEvent somewere before setDataBlockForEvent() > > in AlsaDriver.cpp:2470, right? > > No. First,

Re: [Rosegarden-devel] Re: [Rosegarden-user] SysEx right on time but empty

2006-01-30 Thread Guillaume Laurent
On Monday 30 January 2006 23:08, Chris Cannam wrote: > Me: > > Who wrote this code in the first place? Was it > > Guillaume, or Richard? > > Nah, silly question. I'm not at a proper computer now > to check the code or the CVS record, but just > thinking about it, the structure is definitely Guill

Re: [Rosegarden-devel] Re: [Rosegarden-user] SysEx right on time but empty

2006-01-30 Thread Chris Cannam
Me: > Who wrote this code in the first place? Was it > Guillaume, or Richard? Nah, silly question. I'm not at a proper computer now to check the code or the CVS record, but just thinking about it, the structure is definitely Guillaume. G? What did you intend to happen on record? Chris

Re: [Rosegarden-devel] Re: [Rosegarden-user] SysEx right on time but empty

2006-01-30 Thread Chris Cannam
Pedro: > No. First, registerDataBlockForEvent() is protected, and second: it sets the > data block itself. I've tried to workaround the issues to only get more > problems. Who wrote this code in the first place? Was it Guillaume, or Richard? I had wondered whether it might be you, but it see

[Rosegarden-devel] Re: [Rosegarden-user] SysEx right on time but empty

2006-01-30 Thread Pedro Lopez-Cabanillas
On Monday 30 January 2006 21:56, Pedro Lopez-Cabanillas wrote: > I guess that there should be an explicit > call to registerDataBlockForEvent somewere before setDataBlockForEvent() in > AlsaDriver.cpp:2470, right? No. First, registerDataBlockForEvent() is protected, and second: it sets the data

[Rosegarden-devel] Re: [Rosegarden-user] SysEx right on time but empty

2006-01-30 Thread Pedro Lopez-Cabanillas
On Monday 30 January 2006 12:34, Chris Cannam wrote: > > Recording sysex events from vkeybd have wrong behavior, it keeps the > > buffer from the former sysex message, and appends the new message bytes > > at the end. It inserts the messages at the right time on the segment, > > though. > > Well I'

[Rosegarden-devel] Re: [Rosegarden-user] SysEx right on time but empty

2006-01-30 Thread Chris Cannam
[cc'ing rg-devel -- feel free to follow up to only that list] On Sunday 29 Jan 2006 22:44, Pedro Lopez-Cabanillas wrote: > Recording sysex events from vkeybd have wrong behavior, it keeps the buffer > from the former sysex message, and appends the new message bytes at the > end. It inserts the me