Re: Bas64 encoding performance

2002-03-11 Thread John Wilson
- Original Message - From: "Paul Brown" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Monday, March 11, 2002 2:00 AM Subject: RE: Bas64 encoding performance [snip] > But I also I grabbed the wrong snippet of code; this was the one that I > wanted: > &

Re: Bas64 encoding performance

2002-03-11 Thread Jason van Zyl
On Mon, 2002-03-11 at 11:51, Daniel Rall wrote: > Jason van Zyl <[EMAIL PROTECTED]> writes: > > > On Sat, 2002-03-09 at 15:58, John Wilson wrote: > > > I have been looking at the performance of the latest version of the Apache > >> XML-RPC system when transferring 1Mb byte arrays via base64 encod

Re: Bas64 encoding performance

2002-03-11 Thread Daniel Rall
Jason van Zyl <[EMAIL PROTECTED]> writes: > On Sat, 2002-03-09 at 15:58, John Wilson wrote: > > I have been looking at the performance of the latest version of the Apache >> XML-RPC system when transferring 1Mb byte arrays via base64 encoding. That >> is to say I have been running the TestBase64

Re: Bas64 encoding performance

2002-03-11 Thread Daniel Rall
FYI, your mail client line wrapped the patch, rendering it useless to patch. Hopefully this is cleared up later in this thread, but I don't see it checked in. You can create a Bugzilla attachment . - Dan "John Wilson" <[EMAIL PROTECTED]> writes: > As the l

Re: Bas64 encoding performance

2002-03-10 Thread John Wilson
Here you go John Wilson The Wilson Partnership http://www.wilson.co.uk - Original Message - From: "Jon Scott Stevens" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Monday, March 11, 2002 1:06 AM Subject: Re: Bas64 encoding performance > on 3/10/02 2:48

RE: Bas64 encoding performance

2002-03-10 Thread Paul Brown
> From: John Wilson [mailto:[EMAIL PROTECTED]] > the code ignores whitespace. > Which I take to mean that "=" or "==" should not be followed by non > whitespace characters. So I think I'm justified in flagging this as an > error. John -- You're right... :) I missed the bytes at the head o

Re: Bas64 encoding performance

2002-03-10 Thread Jon Scott Stevens
on 3/10/02 2:48 PM, "John Wilson" <[EMAIL PROTECTED]> wrote: > > Paul, > > the code ignores whitespace. John, please re-submit your files to the list, your email client line wrapped them. I have gotten the problem with attachments fixed. Or, you could put them on your/a website so that we ca

Re: Bas64 encoding performance

2002-03-10 Thread John Wilson
- Original Message - From: "Paul Brown" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Sunday, March 10, 2002 10:00 PM Subject: RE: Bas64 encoding performance > > > From: John Wilson [mailto:[EMAIL PROTECTED]] > > Subject: Re: Bas64 encoding p

RE: Bas64 encoding performance

2002-03-10 Thread Paul Brown
> From: John Wilson [mailto:[EMAIL PROTECTED]] > Subject: Re: Bas64 encoding performance > + if (sixBit < 64) { > +if (gotEquals) throw new Error("= character not at end of base64 > value"); Technically, if you look at the RFC (which is probably the c

Re: Bas64 encoding performance

2002-03-10 Thread John Wilson
As the list seems to be eating attachments - here's the patch as a message: Index: src/java/org/apache/xmlrpc/Base64.java === RCS file: /home/cvspublic/xml-rpc/src/java/org/apache/xmlrpc/Base64.java,v retrieving revision 1.2 diff -

Re: Bas64 encoding performance

2002-03-10 Thread Rick Blair
Hi all, John has always been a great supporter and maintainer. He is also a great resource. I say +1 to be a committer. Rick At 10:15 AM 3/10/02 +0100, you wrote: >Jason van Zyl wrote: > >> >>Definitely. I know you've been on the helma mailing lists and have >>always helped out, that

Re: Bas64 encoding performance

2002-03-10 Thread John Wilson
- Original Message - From: "Jason van Zyl" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Sunday, March 10, 2002 2:23 AM Subject: Re: Bas64 encoding performance [snip] > Maybe we could combine the code bases somehow? > That would be a little difficult

Re: Bas64 encoding performance

2002-03-10 Thread Hannes Wallnoefer
Jason van Zyl wrote: > >Definitely. I know you've been on the helma mailing lists and have >always helped out, that you are very familiar with XmlRpc in general >(MinML-RPC) so I'd say you're more than capable of applying your patches >directly. > >I would like to nominate John for commit access.

Re: Bas64 encoding performance

2002-03-10 Thread John Wilson
One last go - see if the file extension of the attachment is significant. John Wilson The Wilson Partnership http://www.wilson.co.uk

Re: Bas64 encoding performance

2002-03-10 Thread John Wilson
- Original Message - From: "John Wilson" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Cc: <[EMAIL PROTECTED]> Sent: Sunday, March 10, 2002 8:21 AM Subject: Re: Bas64 encoding performance [snip] > I sent an email with the patches as an attachment to

Re: Bas64 encoding performance

2002-03-10 Thread John Wilson
- Original Message - From: "Rick Blair" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Sunday, March 10, 2002 1:03 AM Subject: Re: Bas64 encoding performance > John, > > Looks good. I would like to have them, Any change getting it > patched in the

Re: Bas64 encoding performance

2002-03-09 Thread Jon Scott Stevens
on 3/9/02 6:23 PM, "Jason van Zyl" <[EMAIL PROTECTED]> wrote: > I would like to nominate John for commit access. > > +1 -0 I would like to see some patches first. -jon

Re: Bas64 encoding performance

2002-03-09 Thread Jason van Zyl
On Sat, 2002-03-09 at 15:58, John Wilson wrote: > I have been looking at the performance of the latest version of the Apache > XML-RPC system when transferring 1Mb byte arrays via base64 encoding. That > is to say I have been running the TestBase64 benchmark. > > On my test system (Sun 1.3 JVM on

Re: Bas64 encoding performance

2002-03-09 Thread Rick Blair
John, Looks good. I would like to have them, Any change getting it patched in the apache surce tree. If so then +1. Rick At 08:58 PM 3/9/02 -, you wrote: >I have been looking at the performance of the latest version of the Apache >XML-RPC system when transferring 1Mb byte arrays

Re: Bas64 encoding performance

2002-03-09 Thread Jon Scott Stevens
> Are you interested in having these patches? Twist my arm. -jon

Re: Bas64 encoding performance

2002-03-09 Thread John Wilson
Sorry, I intended to attach the patch to the last message - here it is. John Wilson The Wilson Partnership http://www.wilson.co.uk