Re: [Rpm-maint] [PATCH 5/5] Fix handling of zero-length file digests

2016-04-27 Thread Stefan Berger
"Rpm-maint" wrote on 04/27/2016 05:45:56 AM: > > I get the following warning: > > ima.c:23:1: warning: ‘PACKED’ attribute directive ignored [-Wattributes] > } __attribute__((PACKED)); > > May be there is an simpler way to check for the header being zeros

Re: [Rpm-maint] [PATCH 4/5] Extend header size to 64MB due to file signatures

2016-04-27 Thread Florian Festi
Well changing header size limit needs a bit more thought. The main problem is that packages with bigger header will look broken on older rpm versions and the usual way of dealing with this (adding rpmlib() Requires) won't work it needs reading the header. Also I wonder if we should increase the

Re: [Rpm-maint] [PATCH 5/5] Fix handling of zero-length file digests

2016-04-27 Thread Florian Festi
I get the following warning: ima.c:23:1: warning: ‘PACKED’ attribute directive ignored [-Wattributes] } __attribute__((PACKED)); May be there is an simpler way to check for the header being zeros only? Florian -- Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn,

Re: [Rpm-maint] [PATCH 0/5] Fix issues related to signed files

2016-04-27 Thread Florian Festi
On 04/26/2016 12:33 AM, Stefan Berger wrote: > This series of patches fixes several issues related to signed files > produced by rpmsign. Thanks for the patches I already pushed the first few. Florian -- Red Hat GmbH, http://www.de.redhat.com/, Registered seat: Grasbrunn, Commercial register: