@dmnks pushed 1 commit.
2ded022a696838f7b6c1ce7fe7174d22777e8a75 Add podman backend
--
View it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2559/files/58a1e437fc1a3447b4ac976f43a10adc39c069b1..2ded022a696838f7b6c1ce7fe7174d22777e8a75
You are receiving this because you are
@dmnks pushed 4 commits.
f9b9e0e116ad1d13b65b4064f7382a3b132a791e Replace fakechroot with bwrap
a02c68989f0d1741772fab9730fced67ae4dc89a Drop ci/ directory, move Dockerfile
to tests/
bf0e8bfb5710330d2b22b3033cbfa88a3f5dea52 Turn Dockerfile into a standalone RPM
image
@dmnks pushed 4 commits.
222538da27e5edc686b7a06e97c3290fb0581eb9 Replace fakechroot with bwrap
e0f5f8fca9e7d765728f9c739a534c63e6cf70d7 Drop ci/ directory, move Dockerfile
to tests/
c9308144d95136fb67ebbb3c1989fd0589a1d971 Turn Dockerfile into a standalone RPM
image
@dmnks pushed 6 commits.
27331917eb4366a10869427f811bc605752c7e88 Actually ensure no rpmdb in "no
rpmdb" test
dbbc4e9811f7ce7a846b76ad9fb8c16ffbe0d82b Silence awk if no RPM_CONFIGDIR in
atlocal
994d1b0abe19ea14407b5848b7125ba463fa1692 Replace fakechroot with bwrap
> That said, a generator not using the filename passed to it via %1 sounds
> suspicious in itself.
It's generating a provide based on the package name.
--
Reply to this email directly or view it on GitHub:
@pmatilai approved this pull request.
I don't claim to have understood, or even tried, everything this does. It's
remarkably neat and tidy for such big change though. Good job :+1:
Feel free to hit merge once CI passes.
--
Reply to this email directly or view it on GitHub:
Oh yup. Semi-final, not final :smile:
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2559#issuecomment-1625339177
You are receiving this because you are subscribed to this thread.
Message ID:
> That final "Replace fakechroot with bwrap" commit could use a little more
> elaborate commit message though. Like a brief description of the setup this
> creates smile
Yup, on the todo list above :laughing:
--
Reply to this email directly or view it on GitHub:
Test-suite passes locally :+1:
That final "Replace fakechroot with bwrap" commit could use a little more
elaborate commit message though. Like a brief description of how the setup this
creates :smile:
--
Reply to this email directly or view it on GitHub:
OK, pushed a semi-final version of this branch. Please note the CI will now
fail since there's no podman/docker backend yet. That's in progress now :grin:
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2559#issuecomment-1625318978
You
@dmnks pushed 3 commits.
ebbda3d41dfa876bb60e1ea82efbe33b837d52fb Actually ensure no rpmdb in "no
rpmdb" test
47acf07be8309f7492d79daf1afc7cdf01464202 Silence awk if no RPM_CONFIGDIR in
atlocal
ba798a1146aabd6103558195f6071c626ed3f86a Replace fakechroot with bwrap
--
View it on GitHub:
Merged #2570 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2570#event-9752720350
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint
Thanks for keeping me busy :joy:
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2570#issuecomment-1625111935
You are receiving this because you are subscribed to this thread.
Message ID: ___
Hi,
I think using Docker directly would solve this problem (as then you can use
fedora as a base image).
There are at least two approaches:
- docker buildx (if you need to build for multiple architectures), an
example:
Despite the original claim of volume III being the last one, heres one
another :smile: Just to keep things flowing.
You can view, comment on, or merge this pull request online at:
https://github.com/rpm-software-management/rpm/pull/2570
-- Commit Summary --
* Add sandbox mount command
*
For `rpm-sequoia`, I'm [running the `rpm` test suite from GitHub's
Actions](https://github.com/rpm-software-management/rpm-sequoia/blob/main/.github/workflows/ci.yml#L128).
The only issue is that it runs on Ubuntu and not Fedora or some other
rpm-base distribution. As I understand it, [GitHub
Okay, showtime :grin:
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2568#issuecomment-1624938210
You are receiving this because you are subscribed to this thread.
Message ID: ___
Rpm-maint
Merged #2568 into master.
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2568#event-9751787461
You are receiving this because you are subscribed to this thread.
Message ID:
___
Rpm-maint
@dmnks commented on this pull request.
> fi
}
function sandbox()
{
-(unset RPM_CONFIGDIR RPM_POPTEXEC_PATH
- cd ${RPMTEST} && \
- FAKECHROOT_BASE="${RPMTEST}" fakechroot "$@"
-)
+local cmd=$1
+shift
+case $cmd in
+exec)
+(unset
@dmnks commented on this pull request.
> fi
}
function sandbox()
{
-(unset RPM_CONFIGDIR RPM_POPTEXEC_PATH
- cd ${RPMTEST} && \
- FAKECHROOT_BASE="${RPMTEST}" fakechroot "$@"
-)
+local cmd=$1
+shift
+case $cmd in
+exec)
+(unset
Fixed up. Other quote inconsistencies are left for later :smile:
--
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/2568#issuecomment-1624915013
You are receiving this because you are subscribed to this thread.
Message ID:
@dmnks pushed 5 commits.
4413f80ea0afe002db3a01e4845d909ba2822c58 Add RPMTREE variable to tests
f31b62e83ac0179d2cf05df369ebf44dbc9b88c5 Rename testing/ to tree/ in tests
b5d2af4d740a35edf9fb09d0aa0f6d9c10cfbc3a Turn populate into mktree
ea3981134bf71b84040c7acc6beb4866a483ffdd Create the
>From https://semaphoreci.com/blog/semaphore-classic-deprecation:
> However, we are excited to announce that Semaphore Classic will be
> discontinued by September 30, 2023.
It's an interesting way to put it. Okay, maybe they're engineers *are* excited
to be finally rid of a legacy platform
@dmnks commented on this pull request.
> fi
}
function sandbox()
{
-(unset RPM_CONFIGDIR RPM_POPTEXEC_PATH
- cd ${RPMTEST} && \
- FAKECHROOT_BASE="${RPMTEST}" fakechroot "$@"
-)
+local cmd=$1
+shift
+case $cmd in
+exec)
+(unset
@pmatilai commented on this pull request.
> fi
}
function sandbox()
{
-(unset RPM_CONFIGDIR RPM_POPTEXEC_PATH
- cd ${RPMTEST} && \
- FAKECHROOT_BASE="${RPMTEST}" fakechroot "$@"
-)
+local cmd=$1
+shift
+case $cmd in
+exec)
+(unset
@pmatilai commented on this pull request.
> fi
}
function sandbox()
{
-(unset RPM_CONFIGDIR RPM_POPTEXEC_PATH
- cd ${RPMTEST} && \
- FAKECHROOT_BASE="${RPMTEST}" fakechroot "$@"
-)
+local cmd=$1
+shift
+case $cmd in
+exec)
+(unset
@pmatilai commented on this pull request.
> @@ -27,7 +29,7 @@ else
exit
fi
-RPMTEST="@CMAKE_CURRENT_BINARY_DIR@/testing"
+RPMTEST=$RPMTREE
Oh I know the feeling. Guess why they're so inconsistent to begin with?
:laughing:
--
Reply to this email directly or view it on GitHub:
@dmnks commented on this pull request.
> RPM_CONFIGDIR=${RPMTEST}/@RPM_CONFIGDIR@
-export RPMTEST HOME RPM_CONFIGDIR
+export RPMTEST RPM_CONFIGDIR
Oh-oh, again, you're right. On one hand, we do override a bunch of paths like
`_topdir` in `run()` but you can never be
@dmnks commented on this pull request.
> @@ -27,7 +29,7 @@ else
exit
fi
-RPMTEST="@CMAKE_CURRENT_BINARY_DIR@/testing"
+RPMTEST=$RPMTREE
Ugh, you're right. Not that I wasn't aware, but I'm kinda sloppy when it comes
to quoting in my own changes. I just consider quotes too noisy to
29 matches
Mail list logo
