Re: [Rpm-maint] [rpm-software-management/rpm] rpm2archive -f pax cannot handle non-utf8 filenames (Issue #2972)

2024-03-18 Thread Panu Matilainen
rpm2archive could use some love for sure, but I'd rather not teach it about format internals, that's just the kind of thing I'd rather outsource to somebody else - like libarchive. If it doesn't do what we want it to do, then lets at least look at fixing it instead of doing it in rpm, it'd benef

[Rpm-maint] [rpm-software-management/rpm] Spring cleaning! (PR #2977)

2024-03-18 Thread Panu Matilainen
Int vs enum type mismatches, initialization order consistency and other "fascinating" trivia. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/2977 -- Commit Summary -- * Fix some int/enum confusion in the build code * Fix

Re: [Rpm-maint] [rpm-software-management/rpm] rpm2archive: fix hardlink handling in cpio output (PR #2975)

2024-03-18 Thread Panu Matilainen
Merged #2975 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2975#event-12147493990 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mail

Re: [Rpm-maint] [rpm-software-management/rpm] rpm2archive: fix hardlink handling in cpio output (PR #2975)

2024-03-18 Thread Panu Matilainen
Thanks for the patch! -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2975#issuecomment-2003154611 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mai

Re: [Rpm-maint] [rpm-software-management/rpm] Spring cleaning! (PR #2977)

2024-03-18 Thread Panu Matilainen
Merged #2977 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2977#event-12147549787 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mail

[Rpm-maint] [rpm-software-management/rpm] Sqlite backend spring cleaning (PR #2978)

2024-03-18 Thread Panu Matilainen
This one is a particularly bad case of int/enum abuse. Not so suprisingly, using separate variables for sqlite and rpm side returns makes the stuff much saner. I can kinda remember this even: "Just make it work now, I'll clean it all up later" and this is payback time. You can view, comment on,

Re: [Rpm-maint] [rpm-software-management/rpm] rpm2archive -f pax cannot handle non-utf8 filenames (Issue #2972)

2024-03-18 Thread Michael Schroeder
It just warns about the unknown attribute. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2972#issuecomment-2003338390 You are receiving this because you are subscribed to this thread. Message ID: __

Re: [Rpm-maint] [rpm-software-management/rpm] Sqlite backend spring cleaning (PR #2978)

2024-03-18 Thread Panu Matilainen
@pmatilai pushed 4 commits. 9bc302619451dac4745c5513f22686f32c4750de Fix int/enum type mess in sqlite_pkgdbPut() e5356bcad92b53b68330056b72c2710af0db804a Fix a few int/enum messes wrt sqlite3_step() use 631692bd020456608834f7d003c1fcbcdd3a1269 Fix int/enum type mess in sqlite_idxdbByKey() 61

Re: [Rpm-maint] [rpm-software-management/rpm] rpm2archive -f pax cannot handle non-utf8 filenames (Issue #2972)

2024-03-18 Thread Michael Schroeder
And this is about file names, I think "upstream rpm" treats those pretty much as binary as they are created by the build process and not part of the spec file. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2972#issuecomment-200334575

[Rpm-maint] [rpm-software-management/rpm] rpmarchive should get an option to extract the archive into the file system (Issue #2979)

2024-03-18 Thread Michael Schroeder
I think pretty much everybody that uses rpmarchive just does it to pipe it into tar/cpio to extract the content. How about adding an option so that it can directly extract the content? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/29

Re: [Rpm-maint] [rpm-software-management/rpm] Sqlite backend spring cleaning (PR #2978)

2024-03-18 Thread Panu Matilainen
Merged #2978 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2978#event-12149204018 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mail

Re: [Rpm-maint] [rpm-software-management/rpm] rpm2archive -f pax cannot handle non-utf8 filenames (Issue #2972)

2024-03-18 Thread Panu Matilainen
Right. So the warning would only be seen by folks who run rpm2archive to convert legacy rpms to tar - ie a rare corner case really. A harmless warning from gnu tar in that case is quite acceptable to me at least. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-softw

Re: [Rpm-maint] [rpm-software-management/rpm] rpm2archive -f pax cannot handle non-utf8 filenames (Issue #2972)

2024-03-18 Thread Michael Schroeder
Why "legacy"? Does the current code reject non-utf8 file names? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2972#issuecomment-2003513183 You are receiving this because you are subscribed to this thread. Message ID: _

Re: [Rpm-maint] [rpm-software-management/rpm] rpm2archive -f pax cannot handle non-utf8 filenames (Issue #2972)

2024-03-18 Thread Panu Matilainen
It does, by default. For many years now. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2972#issuecomment-2003543922 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] rpm2archive -f pax cannot handle non-utf8 filenames (Issue #2972)

2024-03-18 Thread Michael Schroeder
That makes things a bit easier, so we just need to teach libarchive that it should accept utf8. I'll adapt the title of this issue ;-) -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2972#issuecomment-2003579832 You are receiving this b

Re: [Rpm-maint] [rpm-software-management/rpm] support reproducible automatic rebuilds (PR #2880)

2024-03-18 Thread Panu Matilainen
Closed #2880. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2880#event-12149995726 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list Rpm

Re: [Rpm-maint] [rpm-software-management/rpm] support reproducible automatic rebuilds (PR #2880)

2024-03-18 Thread Panu Matilainen
The discussion has moved to https://github.com/rpm-software-management/rpm/discussions/2934 and https://github.com/rpm-software-management/rpm/pull/2944, seems to me we can close this somewhat controversial draft. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-so

Re: [Rpm-maint] [rpm-software-management/rpm] Add support for setting the build time and clamping to the build time (PR #2944)

2024-03-18 Thread ニール・ゴンパ
@Conan-Kudo commented on this pull request. > @@ -245,6 +245,10 @@ Supplements: (%{name} = %{version}-%{release} and > langpacks-%{1})\ # Is ignored when SOURCE_DATE_EPOCH is not set. %clamp_mtime_to_source_date_epoch 0 +# If true, make sure that timestamps in built rpms +#

Re: [Rpm-maint] [rpm-software-management/rpm] rpmsign --delsign leaves behind 0 padding (Issue #2965)

2024-03-18 Thread Panu Matilainen
rpmsign cannot know what the previous reservation (if any) was, so it *cannot guarantee* going back to the former state on --delsign. That said, there's something very wonky here, the reserved space doesn't appear to get used at all on signing, although it does reclaim the space from the --del

Re: [Rpm-maint] [rpm-software-management/rpm] Remove residual rpm packages after deleting the Requires dependencies (Issue #2963)

2024-03-18 Thread Panu Matilainen
@pmatilai converted this issue into discussion #2980. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2963#event-12150300723 You are receiving this because you are subscribed to this thread. Message ID:

Re: [Rpm-maint] [rpm-software-management/rpm] %exclude is too strong (Issue #2952)

2024-03-18 Thread Panu Matilainen
Closed #2952 as completed. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2952#event-12150341988 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint m

Re: [Rpm-maint] [rpm-software-management/rpm] %exclude is too strong (Issue #2952)

2024-03-18 Thread Panu Matilainen
You're instructing rpm to both exclude and include a file. It possibly do both, so the only reasonable course of action can be erroring out. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2952#issuecomment-2003646399 You are receiving

Re: [Rpm-maint] [rpm-software-management/rpm] Remove residual rpm packages after deleting the Requires dependencies (Discussion #2980)

2024-03-18 Thread Panu Matilainen
> When I remove the unnecessary 'Requires:' of one package, I found that the > residual package which is no more required can not br removed when upgrade. I > tried 'Obsoletes', but I found that it affects other packages that requires > it. Impossible to give any detailed response because there

[Rpm-maint] [rpm-software-management/rpm] Bunch of docs formatting cosmetics (PR #2981)

2024-03-18 Thread Panu Matilainen
You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/2981 -- Commit Summary -- * Bunch of docs formatting cosmetics -- File Changes -- M docs/manual/queryformat.md (34) M docs/manual/spec.md (2) -- Patch Links -- htt

Re: [Rpm-maint] [rpm-software-management/rpm] Bunch of docs formatting cosmetics (PR #2981)

2024-03-18 Thread Panu Matilainen
Merged #2981 into master. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/2981#event-12150925799 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mail

Re: [Rpm-maint] [rpm-software-management/rpm] %exclude is too strong (Issue #2952)

2024-03-18 Thread Vít Ondruch
> the only reasonable course of action is erroring out. Shall I open separate ticket? -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2952#issuecomment-2003741467 You are receiving this because you are subscribed to this thread. Messag

Re: [Rpm-maint] [rpm-software-management/rpm] rpmsign --delsign leaves behind 0 padding (Issue #2965)

2024-03-18 Thread Jan Zerebecki
Bernhard mentioned that the size of the rpm stays the same on --delsign, but should shrink by 1104 bytes. I haven't calculated it myself but the direction of that looks right and a quick read of the code looks like it should be doing that (but I would need look much more careful to identify why

Re: [Rpm-maint] [rpm-software-management/rpm] rpmsign --delsign leaves behind 0 padding (Issue #2965)

2024-03-18 Thread Panu Matilainen
> So it looks to me like it is not reclaiming the space during --delsign. Where > or why do we disagree? > > It looks to me like the reservation is hard coded. So as long as the rpm that > was used to build and the one that was used to --delsign is the same it > should be able to guarantee it,

Re: [Rpm-maint] [rpm-software-management/rpm] %exclude is too strong (Issue #2952)

2024-03-18 Thread Panu Matilainen
Reopened #2952. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2952#event-12152413309 You are receiving this because you are subscribed to this thread. Message ID: ___ Rpm-maint mailing list

Re: [Rpm-maint] [rpm-software-management/rpm] %exclude is too strong (Issue #2952)

2024-03-18 Thread Panu Matilainen
Hmm, it seems I misread the report because I thought that's what was happening, I guess the strange ticket summary set the stage for strange ideas what will follow. -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2952#issuecomment-2003

Re: [Rpm-maint] [rpm-software-management/rpm] Remove residual rpm packages after deleting the Requires dependencies (Discussion #2980)

2024-03-18 Thread Cunshun Xia
I apologize if my previous description was not very precise. What I meant to say was that if A originally depends on B, and we remove the "Requires B" from the spec, the next time we upgrade A using "dnf upgrade" or "rpm -U", it will not simultaneously remove B. This is different from the effect

Re: [Rpm-maint] [rpm-software-management/rpm] rpmbuild should error out on conflicting %exclude directive (Issue #2952)

2024-03-18 Thread Vít Ondruch
I have not really wanted to suggest this should be prohibited / reported as an error. But since duplicates are already detected and reported, reporting this would be in line with that and possibly prevented possible surprises, so that is acceptable. -- Reply to this email directly or view it

[Rpm-maint] [rpm-software-management/rpm] Rpm roadmap update 2024 (Discussion #2982)

2024-03-18 Thread Panu Matilainen
We've just published our roadmap for the next three years: https://rpm.org/roadmap Of course the big thing there is the looming RPM v6.0 on which we can now shed a lot more light on, so copying it here: RPM 6.0 release * Introducing [RPM v6](https://github.com/rpm-software-management/rpm/discu

[Rpm-maint] [rpm-software-management/rpm] Return to Tralla La or: RPM in C++ (Discussion #2983)

2024-03-18 Thread Panu Matilainen
Ever since the RPM upstream reboot in 2006, we've been striving to replace the old-school, hand-written pointer gymnastics with general purpose APIs in the codebase. We've come a long way, but all this time we've been dreaming about richer data structures than C has to offer. Of course in C, you

Re: [Rpm-maint] [rpm-software-management/rpm] rpmsign --delsign leaves behind 0 padding (Issue #2965)

2024-03-18 Thread Bernhard M. Wiedemann
After 2022-06-20 we changed to a new rsa4096 signkey for the project. %__gpg_reserved_space seems to default to 4096 bytes so that should fit. And indeed, rpm --delsign leaves the size as is. With [this dump-rpm-headers.py](https://gist.github.com/koseki/9737a4490128bcb8b426c22a0b7c3885) I get

Re: [Rpm-maint] [rpm-software-management/rpm] rpmsign --delsign leaves behind 0 padding (Issue #2965)

2024-03-18 Thread Panu Matilainen
Just FWIW, there's now an in-tree tool for looking at low-level package structure: https://github.com/rpm-software-management/rpm/blob/master/tools/rpmdump.c -- Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/2965#issuecomment-2005946927