ffesti commented on this pull request.
> @@ -659,6 +674,10 @@ int main(int argc, char *argv[])
case 's':
ba->buildAmount |= RPMBUILD_PACKAGESOURCE;
break;
+case 'd':
This looks fishy. The `'r'` case also gets
```
ba->buildAmount |= RPMBUILD_PREP;
```
and I fail to see
Ok, opposite to what is discussed in #875 this patch does not the same thing as
`rpmbuild -bb --nobuild`. The later does not execute `%generate_buildrequires`
while this patch clearly tries to do that. In it's function it is very close to
-br but does not build the srpm if no issue is
Also a test-case or two wouldn't hurt. It should be easy to adapt the test for
dynamic buildrequires into a new test covering this.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
The new parameters need to be added to the rpmbuild man page before they can be
merged.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
Anything in this direction needs to deal with dynamic buildrequires too, one
way or the other, calling in @ffesti and @ignatenkobrain
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
I concur, having special-purpose switch(es) for this seems nicer and way more
obvious than using --nobuild to achieve the same :+1:
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
I have added an option to rpmbuild.c which makes rpmbuild check the build
dependencies. In this patch the option is activated by -bd, -td or -rd. I have
not updated the man page nor the changelog.
You can view, comment on, or merge this pull request online at:
