Merged #870 into master.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/870#event-2668442635___
Rpm-maint mailing list
Conan-Kudo approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/rpm-software-management/rpm/pull/870#pullrequestreview-294273383___
pmatilai commented on this pull request.
> @@ -68,12 +68,6 @@ static const int typeSizes[16] = {
0
};
-enum headerSorted_e {
-HEADERSORT_NONE= 0,/* Not sorted */
-HEADERSORT_OFFSET = 1,/* Sorted by offset (on-disk format) */
-HEADERSORT_INDEX = 2,/*
pmatilai commented on this pull request.
> @@ -68,12 +68,6 @@ static const int typeSizes[16] = {
0
};
-enum headerSorted_e {
-HEADERSORT_NONE= 0,/* Not sorted */
-HEADERSORT_OFFSET = 1,/* Sorted by offset (on-disk format) */
-HEADERSORT_INDEX = 2,/*
Conan-Kudo requested changes on this pull request.
> @@ -68,12 +68,6 @@ static const int typeSizes[16] = {
0
};
-enum headerSorted_e {
-HEADERSORT_NONE= 0,/* Not sorted */
-HEADERSORT_OFFSET = 1,/* Sorted by offset (on-disk format) */
-HEADERSORT_INDEX = 2,
headerExport() is the only thing that needs offset sorting, theres no
point messing up with the header itself for this when we can just sort a copy
instead. No visible functional changes, but makes headerExport() a read-only
operation to the header, as it should be.
You can view, comment on, or
