Re: [Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)

2021-02-05 Thread Florian Festi
@ffesti commented on this pull request. > +return RPMRC_OK; +} + +static rpmRC dbus_announce_tsm_pre(rpmPlugin plugin, rpmts ts) +{ +int rc; + +rc = open_dbus(plugin, ts); +if (rc != RPMRC_OK) + return rc; +return send_ts_message(plugin, "StartTransaction", ts, RPMRC_OK

[Rpm-maint] [rpm-software-management/rpm] Fix test cases failing on systems with tape drives (#1529)

2021-02-05 Thread Florian Festi
If $TAPE is set tar uses the tape drive instead of stdout as default. The rpm2archive test assumed that tar will just use stdout no matter what. Force this behaviour per command line option. Resolves: rhbz#1902844 You can view, comment on, or merge this pull request online at: https://github.co

Re: [Rpm-maint] [rpm-software-management/rpm] Handle file install failures more gracefully (#1534)

2021-02-12 Thread Florian Festi
Minor nit pick: The name and usage of the new `stage` member in the last patch isn't as obvious at probably should be. Also the numbers used are nicely unrelated to the stages listed in the commit message. May be having named constant instead of random numbers makes this more readable. -- You

Re: [Rpm-maint] [rpm-software-management/rpm] Handle file install failures more gracefully (#1534)

2021-02-12 Thread Florian Festi
Do we really want to call `rpmpluginsCallFsmFilePost()` for all files in case of failure? Or should be not call it at all in this case. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-manageme

Re: [Rpm-maint] [rpm-software-management/rpm] rpm2archive: Support uncompressed output (#1530)

2021-02-12 Thread Florian Festi
If I had imagined the tool would be used in such a central role I might had added a few more options right from the start. Adding those features should pretty easy though. Feel free to bug me if you need help. -- You are receiving this because you are subscribed to this thread. Reply to this em

Re: [Rpm-maint] [rpm-software-management/rpm] rpmbuild sets RPMFILE_DOC on files in %{_datadir}/doc regardless of spec file notation (#1368)

2021-02-12 Thread Florian Festi
Yes, this is intentional. All files in the docdir get automatically marked as docs. If there is some specific use case where this creates problems please re-open. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://gith

Re: [Rpm-maint] [rpm-software-management/rpm] rpmbuild sets RPMFILE_DOC on files in %{_datadir}/doc regardless of spec file notation (#1368)

2021-02-12 Thread Florian Festi
Closed #1368. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1368#event-4324585421___ Rpm-maint mailing list Rpm-maint@lists.r

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Add variable arrays to rpm (#1149)

2021-02-12 Thread Florian Festi
I guess the overall direction of rpm development is to rather add more lua than adding more to the macro language. So I am closing this here as this is not likely to happen any time soon... well any time actually. -- You are receiving this because you are subscribed to this thread. Reply to thi

Re: [Rpm-maint] [rpm-software-management/rpm] RFE: Add variable arrays to rpm (#1149)

2021-02-12 Thread Florian Festi
Closed #1149. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1149#event-4324748371___ Rpm-maint mailing list Rpm-maint@lists.r

Re: [Rpm-maint] [rpm-software-management/rpm] Improve the "minimize writes" feature (#1080)

2021-02-12 Thread Florian Festi
While this is easy to implement this is probably not the right trade off. The regular minimize writes feature already saves a lot. We'd rather not allow rpm to take chances when it comes to correctness of the operation for a relatively little speed up. -- You are receiving this because you are

Re: [Rpm-maint] [rpm-software-management/rpm] Improve the "minimize writes" feature (#1080)

2021-02-12 Thread Florian Festi
Closed #1080. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1080#event-4324886601___ Rpm-maint mailing list Rpm-maint@lists.r

[Rpm-maint] [rpm-software-management/rpm] Add section for %generate_buildrequires to the manual (#1539)

2021-02-16 Thread Florian Festi
This was still missing from the Spec syntax documentation You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1539 -- Commit Summary -- * Add section for %generate_buildrequires to the manual -- File Changes -- M doc/manua

Re: [Rpm-maint] [rpm-software-management/rpm] Handle file install failures more gracefully (#1534)

2021-02-16 Thread Florian Festi
My concerns have been addressed. Looks really good now! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1534#issuecomment-779645250__

Re: [Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)

2021-02-16 Thread Florian Festi
@ffesti commented on this pull request. > +state->logging = 1; + +/* ...don't log test transactions */ +if (rpmtsFlags(ts) & (RPMTRANS_FLAG_TEST|RPMTRANS_FLAG_BUILD_PROBS)) + state->logging = 0; + +/* ...don't log chroot transactions */ +if (!rstreq(rpmtsRootDir(ts), "/

Re: [Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)

2021-02-16 Thread Florian Festi
@ffesti commented on this pull request. > +static rpmRC dbus_announce_init(rpmPlugin plugin, rpmts ts) +{ +struct dbus_announce_data * state = rcalloc(1, sizeof(*state)); +rpmPluginSetData(plugin, state); +return RPMRC_OK; +} + +static rpmRC open_dbus(rpmPlugin plugin, rpmts ts) +{ +

Re: [Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)

2021-02-16 Thread Florian Festi
@ffesti commented on this pull request. > + fprintf(stderr, "Connection Error (%s)\n", err.message); + dbus_error_free(&err); + } + if (state->bus) { + rc = dbus_bus_request_name(state->bus, "org.rpm.announce", +

Re: [Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)

2021-02-16 Thread Florian Festi
While many smaller things are fixed now. This still needs a run through the error handling. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1255#issuecomment-779651408_

Re: [Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)

2021-02-16 Thread Florian Festi
@ffesti commented on this pull request. > @@ -0,0 +1,25 @@ +'\" t +.TH "RPM-DBUS-ANNOUNCE" "8" "03 Jun 2020" "Red Hat, Inc." +.SH NAME +rpm-plugin-dbus-announce \- DBus plugin for the RPM Package Manager + +.SH Description + +The plugin writes basic information about rpm transactions to the +sys

Re: [Rpm-maint] [rpm-software-management/rpm] Hardlink handling cleanups + fixes (#1540)

2021-02-16 Thread Florian Festi
The "Streamline + consolidate the hardlink handling logic" patch still makes my head ache but I think it is fine. Other three patches look nice and simple in comparison... -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: htt

Re: [Rpm-maint] [rpm-software-management/rpm] Add query formats for displaying tag numbers and names (#1551)

2021-02-23 Thread Florian Festi
The patch looks good. But I wonder how useful the new formats really are. I have difficulty coming up with another use case other than what's in the test case. That doesn't mean I am against adding them. But the whole discussion started with packages having tags not yet supported by the system's

Re: [Rpm-maint] [rpm-software-management/rpm] Dynamic Spec generation (#1485)

2021-02-23 Thread Florian Festi
When it comes to the distribution automagically generating sub packages I agree that the package need to be able to over write the behaviour. But I wonder if this really should be done on the "automatic sub packages off/on" level. Similar to what we have with debuginfo sub packages I'd rather ex

Re: [Rpm-maint] [rpm-software-management/rpm] Dynamic Spec generation (#1485)

2021-02-23 Thread Florian Festi
I guess I really need to write a proper design document... When I think about distribution level sub package creation I think about something very close to an brp-script - most likely a literal brp-script. Not that I am a big fan of the way brp scripts are currently run. But I'd rather improve t

Re: [Rpm-maint] [rpm-software-management/rpm] RPMTAG_FILECLASS type mismatch (#1563)

2021-03-03 Thread Florian Festi
I wonder if we could overload the assignment in the Python binding to translate the list of strings back into the dict it originally were. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-mana

Re: [Rpm-maint] [rpm-software-management/rpm] rpmio: avoid reading past the end of the mode string (#1604)

2021-03-30 Thread Florian Festi
Merged #1604 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1604#event-4525791119___ Rpm-maint mailing list Rpm-mai

Re: [Rpm-maint] [rpm-software-management/rpm] rpmio: avoid reading past the end of the mode string (#1604)

2021-03-30 Thread Florian Festi
Yeah, I guess we really don't want to read some random memory. Nice catch. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1604#issuecomment-809997582___

Re: [Rpm-maint] [rpm-software-management/rpm] Fix incorrect rpmarchive_writeto argument string (#1611)

2021-03-30 Thread Florian Festi
Merged #1611 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1611#event-4525797908___ Rpm-maint mailing list Rpm-mai

Re: [Rpm-maint] [rpm-software-management/rpm] Fix incorrect rpmarchive_writeto argument string (#1611)

2021-03-30 Thread Florian Festi
I have no idea how you found this... but yes, nice catch! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1611#issuecomment-810003050

Re: [Rpm-maint] [rpm-software-management/rpm] Clarify %check script use-case by executing it before %install (#1618)

2021-04-07 Thread Florian Festi
I wonder if moving %check to a later time instead of running it earlier does the trick. If we first package the files and run %check afterwards it cannot influence the package contents but still has access to the buildroot. Yes, this comes at the price of failing the build after doing all of the

Re: [Rpm-maint] [rpm-software-management/rpm] Tag alpha rpm versions? (#1614)

2021-04-09 Thread Florian Festi
Closed #1614. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1614#event-4572854542___ Rpm-maint mailing list Rpm-maint@lists.r

Re: [Rpm-maint] [rpm-software-management/rpm] Tag alpha rpm versions? (#1614)

2021-04-09 Thread Florian Festi
Well, the page says "Draft" for a reason. 4.17.0-alpha is not tagged because it is not out yet. All actual releases are tagged in the git repository. Note that we did not always do alpha releases in the past. RPM is such a central component of the distribution that we don't really expect people

Re: [Rpm-maint] [rpm-software-management/rpm] Lend a hand to libmagic for arriving to expected conclusion (#1624)

2021-04-09 Thread Florian Festi
Merged #1624 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1624#event-4573869635___ Rpm-maint mailing list Rpm-mai

Re: [Rpm-maint] [rpm-software-management/rpm] rpm testsuite test 236 fails with file 5.40 (#1616)

2021-04-09 Thread Florian Festi
Closed #1616 via #1624. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1616#event-4573869641___ Rpm-maint mailing list Rpm-mai

Re: [Rpm-maint] [rpm-software-management/rpm] Add type hints to the Python interface (#1615)

2021-04-09 Thread Florian Festi
While I like the overall idea of adding type hints to the binding I am not a big fan of the content of python/rpm/_rpm.pyi. This basically duplicates the API implementation in the C based API and is very easy to get out of sync. Having this generated automatically during build time from the C b

Re: [Rpm-maint] [rpm-software-management/rpm] Make interactive Lua mode actually interactive (#1632)

2021-04-13 Thread Florian Festi
The "Remove the need for special print syntax in Lua interactive mode" patch does not really seem to cut it. `isassign` does not allow for white space but also matches `a==5`. But the whole idea of printing everything is also ill fated as there are compount statements like loops und if clauses.

Re: [Rpm-maint] [rpm-software-management/rpm] Make interactive Lua mode actually interactive (#1632)

2021-04-14 Thread Florian Festi
May be it is worth peaking into the actual lua shell sources. I'd expect that there should be a way to retrieve the value of the last expression somehow using the lua C API. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: h

[Rpm-maint] [rpm-software-management/rpm] Add --nocompression option to rpm2archive (#1657)

2021-04-26 Thread Florian Festi
Also use popt for the command line handling. As we are using librpm anyway there is no reason to keep the dependencies low (as with rpm2cpio). Resolves: #1530 You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1657 -- Commit Summ

Re: [Rpm-maint] [rpm-software-management/rpm] Issue #1473: move option -q to rpmQueryPoptTable (#1656)

2021-04-26 Thread Florian Festi
The pull request should only have the one relevant patch. Please rebase the patch to the current master branch. The patch is also missing a justification for the change. This should be part of the commit message. But even ignoring the commit message I don't quite see what you are trying to achi

Re: [Rpm-maint] [rpm-software-management/rpm] rpm2archive: Support uncompressed output (#1530)

2021-04-27 Thread Florian Festi
After considering to expose more of libarchive's functionality like many compression methods and archive formats I opted to only add an option for uncompressed output - as requested. Is the PR what you had in mind? -- You are receiving this because you are subscribed to this thread. Reply to th

[Rpm-maint] [rpm-software-management/rpm] find-lang.sh: Support long languages names for QT (#1658)

2021-04-27 Thread Florian Festi
Most language abbreviations are just two characters but some are longer. Allow an arbiraty number of character instead of exactly two in the names of .qm files (QT translations). This brings the handling of .qm files in line with all other file types. Resolves: #1642 You can view, comment on, or m

Re: [Rpm-maint] [rpm-software-management/rpm] Load plugin library symbols first (#1664)

2021-04-28 Thread Florian Festi
I understand the issue of symbols of the plugin vs system symbols as both may be linked to different versions of a library or symbols may collide otherwise. I am just not quite sure how or if at all this relates to RTLD_LAZY vs RTLD_NOW. So while the change may be OK I wonder if the commit messa

Re: [Rpm-maint] [rpm-software-management/rpm] test/README: Improve wording, convert to markdown (#1662)

2021-04-28 Thread Florian Festi
Looks like the new file does not get automatically picked up by automake and needs to be added to `EXTRA_DIST` in `tests/Makefile.am`. Generally changes to the content (even if just rewording) and changing the format as a whole should be done in separate patches but it's not a big deal here. Fe

Re: [Rpm-maint] [rpm-software-management/rpm] test/README: Improve wording, convert to markdown (#1662)

2021-04-28 Thread Florian Festi
Oh, and thanks for the patch! Your attention to details like this is appreciated! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1662#issuecomment-828468299___

[Rpm-maint] [rpm-software-management/rpm] Delete horribly outdated "documentation" (#1665)

2021-04-29 Thread Florian Festi
about build dependencies No idea how this could survive that long... You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1665 -- Commit Summary -- * Delete horribly outdated "documentation" -- File Changes -- D doc/manual

Re: [Rpm-maint] [rpm-software-management/rpm] Delete horribly outdated "documentation" (#1665)

2021-04-29 Thread Florian Festi
@ffesti pushed 1 commit. 39db22fefe5c55477d02b5d6ce7194a042ac3094 Delete horribly outdated "documentation" -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1665/files/6b60dc4920f24761c84500ede3e6f64c7c7

[Rpm-maint] [rpm-software-management/rpm] Sync doc/manual with rpm.org/documentation.html (#1666)

2021-04-29 Thread Florian Festi
We have copied the documentation found on http://rpm.org/documentation.html to `doc/manual/`, But there are some documents that are only in the git repository and not on http://rpm.org. There is also no process to keep those places in sync. We need a way to turn the in-tree documentation into a

Re: [Rpm-maint] [rpm-software-management/rpm] %generate_buildrequires should have a page on rpm.org (#1029)

2021-04-29 Thread Florian Festi
da55723907418bfb3939cd6ddd941b3fdb4f6887 add a paragraph to the in tree documentation and dynamic build requires are also mentioned elsewhere (e.g. in doc/manual/buildprocess.md). Rather than making a separate page just for rpm.org we should sync up the in-tree docs with the rpm.org web page: #

Re: [Rpm-maint] [rpm-software-management/rpm] %generate_buildrequires should have a page on rpm.org (#1029)

2021-04-29 Thread Florian Festi
Closed #1029. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1029#event-4661421993___ Rpm-maint mailing list Rpm-maint@lists.r

Re: [Rpm-maint] [rpm-software-management/rpm] test/README: Improve wording, convert to markdown (#1662)

2021-04-29 Thread Florian Festi
Merged #1662 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1662#event-4662071582___ Rpm-maint mailing list Rpm-mai

Re: [Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)

2021-05-03 Thread Florian Festi
OK, now there should be all issues raised so far being addressed. The plugin now only gives a warning via `rpmlog` if the connection to dbus cannot be obtained. From my POV this can be merged by squashing all commit into the first one - or I can squash them first if that is prefered. -- You ar

[Rpm-maint] [rpm-software-management/rpm] Insert space between the "{" and "%" (#1676)

2021-05-06 Thread Florian Festi
to avoid gh-pages taking them as Liquid tags See https://shopify.dev/docs/themes/liquid/reference/tags for details. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1676 -- Commit Summary -- * Insert space between the "{" an

Re: [Rpm-maint] [rpm-software-management/rpm] Insert space between the "{" and "%" (#1676)

2021-05-06 Thread Florian Festi
Merged #1676 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1676#event-4695505452___ Rpm-maint mailing list Rpm-mai

[Rpm-maint] [rpm-software-management/rpm] Doc Rework (#1679)

2021-05-07 Thread Florian Festi
This is an attempt to solve #1666. We have some documentation on https://rpm.org that lives in the `rpm-web` repo and the docs in `doc/manual` that should stay in the sources repo. Currently these are duplicated and can't be kept in sync easily. These cahnges re-arange the files so `docs/manual

Re: [Rpm-maint] [rpm-software-management/rpm] Doc Rework (#1679)

2021-05-07 Thread Florian Festi
@ffesti pushed 4 commits. c41b4e8776b031a010b806fd7f94ed5d5798a5c1 Rename doc/ to docs/ to work with GitHub Pages dc7e0cfc9c506c04bd844fa3632feeb775195821 Move man pages into their own sub directory 65c6bf8f36a4074d548fe1249c1cece94f6d9687 Add layout for adding manual/ to Github pages 01033d

Re: [Rpm-maint] [rpm-software-management/rpm] Doc Rework (#1679)

2021-05-07 Thread Florian Festi
@ffesti pushed 2 commits. fcb2ed6448e6013ab19dcfa596c72770bf8be8ed Convert man pages to markdown 918aa9faf57b72233ed36ed2994175154bb2910d Add index for man pages -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/

Re: [Rpm-maint] [rpm-software-management/rpm] Doc Rework (#1679)

2021-05-07 Thread Florian Festi
OK, here a preview on how markdown man pages could look like: http://ffesti.github.io/rpm/man/ Still needs some work: * Add `pandoc` as dependency and though make the test suite pass again. * Check if both the Markdown and the resulting man pages are OK. This is just piping everything blindly th

Re: [Rpm-maint] [rpm-software-management/rpm] Doc Rework (#1679)

2021-05-07 Thread Florian Festi
@ffesti pushed 2 commits. 0bcfba0eee9cbe35c8432f5bda8acf8a021eb931 Add pandoc as dependency 7df22b318dc9723932a8d2704989cd5d869a21ed Add generated man pages to gitignore -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-man

Re: [Rpm-maint] [rpm-software-management/rpm] Doc Rework (#1679)

2021-05-07 Thread Florian Festi
@ffesti pushed 1 commit. dc46dfd9955e55f192e87f755b8b6447dca0427a Bump Fedora version used in the CI -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1679/files/7df22b318dc9723932a8d2704989cd5d869a21ed..

Re: [Rpm-maint] [rpm-software-management/rpm] Doc Rework (#1679)

2021-05-07 Thread Florian Festi
@ffesti pushed 1 commit. eae879c7fe62162b04b7b91455635590869d0e45 Dont run pandoc in parallel -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1679/files/dc46dfd9955e55f192e87f755b8b6447dca0427a..eae879c

Re: [Rpm-maint] [rpm-software-management/rpm] Doc Rework (#1679)

2021-05-07 Thread Florian Festi
@ffesti pushed 1 commit. 3305427f8445258b35d4e683c9e9d00f1bb0948a Dont run pandoc in parallel -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1679/files/eae879c7fe62162b04b7b91455635590869d0e45..3305427

Re: [Rpm-maint] [rpm-software-management/rpm] Doc Rework (#1679)

2021-05-07 Thread Florian Festi
@ffesti pushed 0 commits. -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1679/files/3305427f8445258b35d4e683c9e9d00f1bb0948a..7df22b318dc9723932a8d2704989cd5d869a21ed ___

Re: [Rpm-maint] [rpm-software-management/rpm] Doc Rework (#1679)

2021-05-10 Thread Florian Festi
@ffesti pushed 2 commits. a1fb295947ec2fb8f4c804bf8eb067e1252bc96d Convert man pages to markdown 56f5b272fd8b3c7930cf6ef0a8cb0d87a19853dc Add index for man pages -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/

Re: [Rpm-maint] [rpm-software-management/rpm] rpm2archive: Support uncompressed output (#1530)

2021-05-10 Thread Florian Festi
Closed #1530 via #1657. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1530#event-4716823295___ Rpm-maint mailing list Rpm-mai

Re: [Rpm-maint] [rpm-software-management/rpm] Add --nocompression option to rpm2archive (#1657)

2021-05-10 Thread Florian Festi
Merged #1657 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1657#event-4716823275___ Rpm-maint mailing list Rpm-mai

Re: [Rpm-maint] [rpm-software-management/rpm] Doc Rework (#1679)

2021-05-10 Thread Florian Festi
Looks like pandoc has issues with the French and Japanese files. This work for me locally. There are probably still some packages missing in the `ci/Dockerfile. Unfortunately the error messages are all but helpful *sigh* -- You are receiving this because you are subscribed to this thread. Reply

Re: [Rpm-maint] [rpm-software-management/rpm] Doc Rework (#1679)

2021-05-10 Thread Florian Festi
OK, build is fixed. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1679#issuecomment-836768389___ Rpm-maint mailing list Rpm-mai

Re: [Rpm-maint] [rpm-software-management/rpm] Doc Rework (#1679)

2021-05-10 Thread Florian Festi
@ffesti pushed 3 commits. 6b883c45fe1f5bc9908fbe82d7ccd7fecbc9de78 Add index.md for man pages c9e3297d57a4b06becde060ccff2d6d25c6d8a73 Improve man page index.md 877df37125290478d754939c56ffd86ff67c11f3 Add index.md to docs dir -- You are receiving this because you are subscribed to this thre

Re: [Rpm-maint] [rpm-software-management/rpm] Doc Rework (#1679)

2021-05-18 Thread Florian Festi
Merged #1679 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1679#event-4760538147___ Rpm-maint mailing list Rpm-mai

[Rpm-maint] [rpm-software-management/rpm] Documentation fixes (#1685)

2021-05-19 Thread Florian Festi
Various fixes to the documentation You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1685 -- Commit Summary -- * Add favicon to documentation and fix header * Fix typos and broken markup * Remove reference to what is now t

Re: [Rpm-maint] [rpm-software-management/rpm] Documentation fixes (#1685)

2021-05-19 Thread Florian Festi
@ffesti pushed 3 commits. fb7e7ac375d18de48c9bbc1cdc273921db8a5031 Add favicon to documentation and fix header 24ad6a7fae5b0dce4bf32afb120692195b6546fa Fix typos and broken markup 7c1b40063c4e3a0e56f2e8d2c77bacb8fe0b9d42 Remove reference to what is now the same file -- You are receiving th

Re: [Rpm-maint] [rpm-software-management/rpm] typo: transaction (#1686)

2021-05-19 Thread Florian Festi
Thanks for the fix! -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1686#issuecomment-843951017___ Rpm-maint mailing list Rpm-mai

Re: [Rpm-maint] [rpm-software-management/rpm] typo: transaction (#1686)

2021-05-19 Thread Florian Festi
Merged #1686 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1686#event-4765640841___ Rpm-maint mailing list Rpm-mai

Re: [Rpm-maint] [rpm-software-management/rpm] Documentation fixes (#1685)

2021-05-19 Thread Florian Festi
Merged #1685 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1685#event-4765649172___ Rpm-maint mailing list Rpm-mai

Re: [Rpm-maint] [rpm-software-management/rpm] Sync doc/manual with rpm.org/documentation.html (#1666)

2021-05-19 Thread Florian Festi
The in-tree docs from master is now available as https://rpm-software-management.github.io/rpm/ Plan is to link to it from rpm.org aka rpm-web as soon as it is a bit more polished and then delete the duplicate pages from rpm-web. -- You are receiving this because you are subscribed to this thre

Re: [Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)

2021-05-26 Thread Florian Festi
@ffesti commented on this pull request. > @@ -0,0 +1,144 @@ +#include "system.h" + +#include +#include +#include +#include +#include +#include +#include +#include "lib/rpmplugin.h" + +struct dbus_announce_data { +DBusConnection * bus; +int old_dboffset; Done. -- You are receivi

Re: [Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)

2021-05-26 Thread Florian Festi
@ffesti pushed 1 commit. 9a51049918edca7572ab6efd27a45ee2ea9d98b8 Add dbus-announce plugin -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1255/files/a1e7a31155a3053e745473e477e1b755ebc5cdbd..9a51049918

Re: [Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)

2021-05-26 Thread Florian Festi
@ffesti commented on this pull request. > +dbcookie = rpmdbCookie(rpmtsGetRdb(ts)); +if (!dbus_message_append_args(msg, DBUS_TYPE_STRING, &dbcookie)) { + goto err; +} +dbcookie = _free(dbcookie); + +if (!dbus_connection_send(state->bus, msg, &serial)) { + goto err

Re: [Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)

2021-05-26 Thread Florian Festi
@ffesti commented on this pull request. > + return RPMRC_OK; + +/* ...don't notify on test transactions */ +if (rpmtsFlags(ts) & (RPMTRANS_FLAG_TEST|RPMTRANS_FLAG_BUILD_PROBS)) + return RPMRC_OK; + +/* ...don't notify on chroot transactions */ +if (!rstreq(rpmtsRootDir(

Re: [Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)

2021-05-26 Thread Florian Festi
@ffesti commented on this pull request. > + rpmts ts, +int res) +{ +struct dbus_announce_data * state = rpmPluginGetData(plugin); +DBusMessage* msg; +dbus_uint32_t serial = 0; +char * dbcookie; + +if (!state->bus) { +

Re: [Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)

2021-05-26 Thread Florian Festi
Rebased to current master Switched man page over to new docs pattern (markdown, doc->docs move) Squashed commits into one Addressed above comments. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-softwa

Re: [Rpm-maint] [rpm-software-management/rpm] Add dbus-announce plugin (#1255)

2021-05-26 Thread Florian Festi
@ffesti commented on this pull request. > +if (!state->bus) { + return RPMRC_OK; +} + +msg = dbus_message_new_signal("/org/rpm/Transaction", /* object name */ + "org.rpm.Transaction", /* interface name */ + name);

[Rpm-maint] [rpm-software-management/rpm] More work on the Reference Manual (#1691)

2021-05-31 Thread Florian Festi
Mainly reformat and improve the Tags page. You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1691 -- Commit Summary -- * Convert tags page in reference manual to tables * Add introduction to tags and tag types * Add Table

Re: [Rpm-maint] [rpm-software-management/rpm] More work on the Reference Manual (#1691)

2021-05-31 Thread Florian Festi
http://ffesti.github.io/rpm/manual/tags.html for the rendered result. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1691#issuecomment-851255353___

Re: [Rpm-maint] [rpm-software-management/rpm] rpm2archive: Support uncompressed output (#1530)

2021-05-31 Thread Florian Festi
Guess this is done. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/issues/1530#issuecomment-851368084___ Rpm-maint mailing list Rpm-m

[Rpm-maint] IRC channels move to Libera.chat

2021-06-17 Thread Florian Festi
The recent developments in what used to be the freenode IRC network force us to look for a new home for our IRC channels. As a result we - as so many other projects - are moving to the Libera.chat network. Discussion about the RPM tool and project itself can continue in the #rpm channel there. Top

[Rpm-maint] [rpm-software-management/rpm] Don't strip flags for OrderWithRequires in rpmds (#1708)

2021-06-17 Thread Florian Festi
As we allow dependeny flags like pre, post, ... in the spec syntax we should not remove them when reading in the tags from a package. Thanks to Michael Schröder for spotting this. Resolves: #1703 You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-ma

Re: [Rpm-maint] [rpm-software-management/rpm] OrderWithRequires deps flags are stripped (#1703)

2021-06-17 Thread Florian Festi
Nope. This is clearly an oversight. Too many places to touch to add a new type of dependency. Interestingly enough weak dependencies are not stripped although we currently do not support flags for them. -- You are receiving this because you are subscribed to this thread. Reply to this email di

Re: [Rpm-maint] [rpm-software-management/rpm] check-rpaths-worker script increases build time considerably for some packages (#1713)

2021-06-21 Thread Florian Festi
Yeah, the script runs `readelf` for every regular file in the `$RPM_BUILD_ROOT` - twice and in series. That's something we painstakingly avoided for all the other brp scripts affecting the kernel (and others). I can switch this over for parallel processing, too. But weeding out the files that ne

[Rpm-maint] [rpm-software-management/rpm] Run rpath check in parallel (#1714)

2021-06-21 Thread Florian Festi
See #1713 You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1714 -- Commit Summary -- * Run rpath check in parallel * Don't break readelf output at 80 characters -- File Changes -- M scripts/check-rpaths (4) M scri

Re: [Rpm-maint] [rpm-software-management/rpm] check-rpaths-worker script increases build time considerably for some packages (#1713)

2021-06-21 Thread Florian Festi
Not quite sure how I detect those. Also we already executed `readelf` by that point, right? Is there a way of skipping files based on file attributes I can pass to `find` like file name, executable bit etc? -- You are receiving this because you are subscribed to this thread. Reply to this emai

Re: [Rpm-maint] [rpm-software-management/rpm] Run rpath check in parallel (#1714)

2021-06-21 Thread Florian Festi
@ffesti pushed 1 commit. a2bd159f17a11f92dadcde2a118cca59fbec8296 check-rpaths: Look for RPATH and RUNPATH in one go -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1714/files/98006bef1a2212095d1c69f28

Re: [Rpm-maint] [rpm-software-management/rpm] Run rpath check in parallel (#1714)

2021-06-21 Thread Florian Festi
Yeah, I figured this would help, but it took your message for me to see how to do that in an clean and easy way. Can someone test the changes, please. May be even with one of the long running builds like kernel. -- You are receiving this because you are subscribed to this thread. Reply to this

Re: [Rpm-maint] [rpm-software-management/rpm] Run rpath check in parallel (#1714)

2021-06-21 Thread Florian Festi
@ffesti pushed 1 commit. 56ed63e63f18a9af1c1a1d3340dfcccd5b855e13 check-rpaths: Look for RPATH and RUNPATH in one go -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1714/files/a2bd159f17a11f92dadcde2a1

Re: [Rpm-maint] [rpm-software-management/rpm] Run rpath check in parallel (#1714)

2021-06-21 Thread Florian Festi
Ok, there were still some issues with quoting. Should work now and produce proper messages. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1714#issuecomment-865305016_

[Rpm-maint] [rpm-software-management/rpm] Create directories for man pages right away (#1722)

2021-06-22 Thread Florian Festi
to avoid rebuilding the man pages over and over again You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1722 -- Commit Summary -- * Create directories for man pages right away -- File Changes -- M docs/man/Makefile.am (6

Re: [Rpm-maint] [rpm-software-management/rpm] Create directories for man pages right away (#1722)

2021-06-22 Thread Florian Festi
@ffesti pushed 1 commit. 8247a1ac3195802763994a99461913185abbf036 Add generated man pages to tar ball -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/rpm-software-management/rpm/pull/1722/files/3b55840405f143b08462b85bab289a7cf27a590b.

[Rpm-maint] [rpm-software-management/rpm] Brown paper back fixes for the new style man pages (#1730)

2021-06-22 Thread Florian Festi
You can view, comment on, or merge this pull request online at: https://github.com/rpm-software-management/rpm/pull/1730 -- Commit Summary -- * Also add rendered Japanese man pages * Don't depend on translation sub directories -- File Changes -- M docs/man/Makefile.am (3) -- Patch

Re: [Rpm-maint] [rpm-software-management/rpm] rpm-4.17.0beta1 fails to build because pandoc is unavailable (#1729)

2021-06-22 Thread Florian Festi
> Having to depends on Haskell in order to build rpm is big bullet to swallow ! This is not intentional. While pandoc is needed to create the release tarball (or make changes to the man pages) requiring pandoc for building from the release tarball is not intended. The man pages should be shipped

Re: [Rpm-maint] [rpm-software-management/rpm] Add quoting to literal curly brackets (#1735)

2021-06-28 Thread Florian Festi
Merged #1735 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1735#event-4946628164___ Rpm-maint mailing list Rpm-mai

Re: [Rpm-maint] [rpm-software-management/rpm] Translations update from Weblate (#1733)

2021-06-28 Thread Florian Festi
Merged #1733 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1733#event-4946754436___ Rpm-maint mailing list Rpm-mai

Re: [Rpm-maint] [rpm-software-management/rpm] Tiny memory leak fixes (#1734)

2021-06-28 Thread Florian Festi
Merged #1734 into master. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/rpm-software-management/rpm/pull/1734#event-4946813124___ Rpm-maint mailing list Rpm-mai

<    4   5   6   7   8   9   10   11   12   13   >