Re: asciidoctor-diagram missing from Fedora

2020-11-23 Thread Christopher Brown
Vit, Dan, Thanks for the feedback, I have updated the spec file. https://raw.githubusercontent.com/snecklifter/rubygem-asciidoctor-diagram/master/rubygem-asciidoctor-diagram.spec COPR: https://copr.fedorainfracloud.org/coprs/snecker/rubygem-asciidoctor-diagram/ Would be good to get this

Re: asciidoctor-diagram missing from Fedora

2020-11-18 Thread Dan Allen
Christopher, I just noticed these lines in the spec file: BuildRequires: rubygem(prawn-svg) BuildRequires: rubygem(asciidoctor-pdf) Asciidoctor Diagram does not depend on Asciidoctor PDF. It's an independent extension that only depends on the main asciidoctor gem (in order to use the extension

Re: asciidoctor-diagram missing from Fedora

2020-11-18 Thread Vít Ondruch
I had something like this on my mind: ~~~ $ diff -u rubygem-asciidoctor-diagram.spec{,.orig} --- rubygem-asciidoctor-diagram.spec    2020-11-18 10:07:55.687486987 +0100 +++ rubygem-asciidoctor-diagram.spec.orig    2020-11-18 10:05:33.015423167 +0100 @@ -1,7 +1,5 @@  %global gem_name

Re: asciidoctor-diagram missing from Fedora

2020-11-16 Thread Dan Allen
Pepijn gives it the thumbs up too. Best Regards, -Dan On Mon, Nov 16, 2020 at 11:01 AM Christopher Brown wrote: > Hi Vit, > > > > On Mon, 16 Nov 2020 at 09:54, Vít Ondruch wrote: > >> >> Dne 13. 11. 20 v 17:46 Christopher Brown napsal(a): >> >> Hi folks, >> >> I've got a working build of

Re: asciidoctor-diagram missing from Fedora

2020-11-16 Thread Christopher Brown
Hi Vit, On Mon, 16 Nov 2020 at 09:54, Vít Ondruch wrote: > > Dne 13. 11. 20 v 17:46 Christopher Brown napsal(a): > > Hi folks, > > I've got a working build of asciidoctor-diagram ready for review: > > https://bugzilla.redhat.com/show_bug.cgi?id=1897619 > > Spec file: > > >

Re: asciidoctor-diagram missing from Fedora

2020-11-16 Thread Dan Allen
Nice work Christopher! That looks good to me so far. I've notified Pepijn of your progress to see if he has any comments. Best Regards, -Dan On Fri, Nov 13, 2020 at 9:48 AM Christopher Brown wrote: > Hi folks, > > I've got a working build of asciidoctor-diagram ready for review: > >

Re: asciidoctor-diagram missing from Fedora

2020-11-16 Thread Vít Ondruch
Dne 13. 11. 20 v 17:46 Christopher Brown napsal(a): Hi folks, I've got a working build of asciidoctor-diagram ready for review: https://bugzilla.redhat.com/show_bug.cgi?id=1897619 Spec file:

Re: asciidoctor-diagram missing from Fedora

2020-11-13 Thread Christopher Brown
Hi folks, I've got a working build of asciidoctor-diagram ready for review: https://bugzilla.redhat.com/show_bug.cgi?id=1897619 Spec file: https://raw.githubusercontent.com/snecklifter/rubygem-asciidoctor-diagram/master/rubygem-asciidoctor-diagram.spec @Dan - this includes support for

Re: asciidoctor-diagram missing from Fedora

2020-11-03 Thread Christopher Brown
Neal, Dan, Thanks both, I think we have a way forward. I'll start the dialog upstream. @Neal - would it be possible to update the Fedora wiki regarding bundling Nodejs deps? Not sure if it needs to be: https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries or

Re: asciidoctor-diagram missing from Fedora

2020-11-02 Thread Neal Gompa
On Mon, Nov 2, 2020 at 10:41 AM Christopher Brown wrote: > > Hi Dan, > > Thanks for this. The issue I think is that there is a large number of > dependencies and AIUI, Fedora doesn't allow these to be bundled with the > gem[1]. This means a fairly significant task creating packages for a

Re: asciidoctor-diagram missing from Fedora

2020-11-02 Thread Dan Allen
Christopher, I understand your point. But please consider the fact that many of the diagramming tool integrations that Asciidoctor Diagram provides are optional (and thus there is no reason to bundle them). If the tool is not there, then it simply cannot be used in the document. The "core" ones

Re: asciidoctor-diagram missing from Fedora

2020-11-02 Thread Vít Ondruch
Unfortunately, there is not right or wrong format. It is just about critical mass. If you create flatpak/snap instead, you won't benefit from fixes possibly provided by other packagers. While if there is not enough packagers, it is certainly annoying to be the one to take care about

Re: asciidoctor-diagram missing from Fedora

2020-11-02 Thread Christopher Brown
Hi Dan, Thanks for this. The issue I think is that there is a large number of dependencies and AIUI, Fedora doesn't allow these to be bundled with the gem[1]. This means a fairly significant task creating packages for a variety of nodejs dependencies amongst other things, e.g. Vega[2] has a

Re: asciidoctor-diagram missing from Fedora

2020-10-29 Thread Dan Allen
Christopher, I would encourage you not to give up on Asciidoctor Diagram yet. I spoke with Pepijn (https://github.com/pepijnve), the maintainer, and he told me he would be glad to help you if you reached out (via the project issue tracker). Just introduce yourself there so he knows who you are.

Re: asciidoctor-diagram missing from Fedora

2020-10-27 Thread Christopher Brown
Ok, thanks Vit. I think I'll probably do the same. I don't have the bandwidth to take on the maintenance of that number of packages right now unless anyone else is interested in sharing the work? On Tue, 27 Oct 2020 at 16:52, Vít Ondruch wrote: > When we tried to get ascii_binder into Fedora,

Re: asciidoctor-diagram missing from Fedora

2020-10-27 Thread Vít Ondruch
When we tried to get ascii_binder into Fedora, we get this far with asciidoctor-diagram. https://fedorapeople.org/cgit/jackorp/public_git/rubygem-asciidoctor-diagram.git/tree/rubygem-asciidoctor-diagram.spec But we rather avoided the dependency in ascii_binder for the time being:

asciidoctor-diagram missing from Fedora

2020-10-27 Thread Christopher Brown
Hello, I've upgrade to F33 and discovered that we are missing asciidoctor-diagram as a requirement for some internal tooling. https://rubygems.org/gems/asciidoctor-diagram/ https://github.com/asciidoctor/asciidoctor-diagram I am putting together a spec file for this now however tests are