On Sat, 2011-11-19 at 20:55 -0800, Aaron Patterson wrote:
> > No, you don't know for sure when you'll backport. But when you do, you
> > don't have to change master as well. So when you backport, you create a
> > new change in 3-1-stable, containing a) the fix and b) a CHANGELOG entry
> > for 3-1-s
Dear all,
I am trying to write tests that test installation of plugins using "rails
plugin install xxx". So far I have setup a basic PluginTest class taking
inspiration from RunnerTest:
railties/test/application/plugin_test.rb
require 'isolation/abstract_unit'
module ApplicationTests
class Pl
On Sun, Nov 20, 2011 at 10:57:55AM +, Jon Leighton wrote:
> On Sat, 2011-11-19 at 20:55 -0800, Aaron Patterson wrote:
> > So if you revert on 3-1-stable, then do you need to add a changelog
> > entry to master? If it was changelog worthy for 3-1-stable, surely it
> > should be changelog worthy
> # Set correct permissions on new file
> chown(old_stat.uid, old_stat.gid, file_name) # <-- delete
> this line
>
>
This line was added deliberately. Prior to its inclusion the files had the
ownership and group information of the file returned by Tempfile, which was
almost always wrong (
On Nov 20, 12:47 pm, Michael Koziarski wrote:
> > chown(old_stat.uid, old_stat.gid, file_name)
>
> This line was added deliberately.
I think I now see the flaw in my original logic, thanks. How about
this instead: change the line to:
chown(nil, old_stat.gid, file_name)
The reason being: n
Yep, that sounds like it would work well
--
Cheers,
Koz
On Monday, 21 November 2011 at 10:57 AM, dburry wrote:
> On Nov 20, 12:47 pm, Michael Koziarski (http://koziarski.com)> wrote:
> > > chown(old_stat.uid, old_stat.gid, file_name)
> >
> >
> > This line was added deliberately.
>
> I thi
Rails 3.1.3 has been released. This release mainly contains fixes for
regressions that popped up in 3.1.2.
## CHANGES ##
Action Pack:
* Downgrade sprockets to ~> 2.0.3. Using 2.1.0 caused regressions.
* Fix using `translate` helper with a html translation which uses the
`:count` option
