Re: [Rails-core] Re: [Feature Request] When performing find by multiple ids, return partial results on RecordNotFound error.

2016-06-23 Thread Robert Smith
I'm getting a "lean no" impression from the comments regarding adding the objects, and a "lean yes" for adding the ids to the message and/or as an accessor. On Tuesday, June 21, 2016 at 3:28:19 PM UTC-4, Al Tenhundfeld wrote: > > John, I was trying to formulate those same thoughts. Thanks. > > I

Re: [Rails-core] Re: [Feature Request] When performing find by multiple ids, return partial results on RecordNotFound error.

2016-06-23 Thread John Mileham
One thing that's not immediately obvious from the rails-core list is that a lot of the chatter is from people like me who have no actual say. :) But if my vote mattered, I'd lean strongly against any form of programmatically readable value (even an array of IDs) encapsulated in the exception to di

[Rails-core] [Feature Request] Add period at the end of error message

2016-06-23 Thread Victor Ng KP
>From UX perspective, a full sentence is to end with a period (see http://ux.stackexchange.com/questions/18671/), but this is not the case with Rails. In https://github.com/rails/rails/blob/master/activemodel/lib/active_model/locale/en.yml, we see that error messages are left hanging. If t

Re: [Rails-core] [Feature Request] Add period at the end of error message

2016-06-23 Thread Tom Prats
I often join with a comma, so having a period at the end would break that. But having it be an option wouldn't be a bad thing. On Fri, Jun 24, 2016 at 12:04 AM Victor Ng KP wrote: > From UX perspective, a full sentence is to end with a period (see > http://ux.stackexchange.com/questions/18671/),