[Rails-core] Deprecate strip_heredoc?

2019-06-08 Thread Simon Perepelitsa
The new squiggly-heredoc syntax is available since Ruby 2.3, which does the same thing as "strip_heredoc" method. I was going to submit a documentation change to mention the new Ruby syntax, but now I'm doubting if there is any good use case for the method, except for backwards compatibility. Ca

Re: [Rails-core] Deprecate strip_heredoc?

2019-06-08 Thread George Claghorn
+1 for deprecating. -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscr...@googlegroups.com. To post to this group, send email to ru

Re: [Rails-core] Deprecate strip_heredoc?

2019-06-08 Thread Xavier Noria
+1 too. -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To unsubscribe from this group and stop receiving emails from it, send an email to rubyonrails-core+unsubscr...@googlegroups.com. To post to this group, send email to rubyonrails-co

Re: [Rails-core] Deprecate strip_heredoc?

2019-06-08 Thread Rafael Mendonça França
The squiggly-heredoc operator can't be applied to an already existing string. That is the only case were you still need strip_heredoc, so unless we add a way to strip heredocs from an already existent string object to Ruby we can't deprecated it. See https://github.com/rails/rails/commit/89bcca59e

Re: [Rails-core] Deprecate strip_heredoc?

2019-06-08 Thread Matthew Draper
> The squiggly-heredoc operator can't be applied to an already existing string. > That is the only case were you still need strip_heredoc, so unless we add a > way to strip heredocs from an already existent string object to Ruby we can't > deprecated it. How about we rename it to something l