[Rails-core] Is flash.now necessary?

2012-09-07 Thread George Ogata
Typically I find the rule of thumb is: * If you're rendering, set flash.now. * If you're redirecting, set flash. Is there ever a case where this is not what is wanted? And if not, could this be automatic? i.e. sweep the flash if and only if not redirecting. (Happy to do the grunt work - just

Re: [Rails-core] Is flash.now necessary?

2012-09-07 Thread Prem Sichanugrist
It used to be the fact that if you set flash[:notice] and try to render the page, the flash message will not be displayed. That's why they have to implement `flash.now`. Is that still the case? On Friday, September 7, 2012 at 2:14 PM, George Ogata wrote: > Typically I find the rule of thumb is:

Re: [Rails-core] Is flash.now necessary?

2012-09-07 Thread George Ogata
On Fri, Sep 7, 2012 at 2:22 PM, Prem Sichanugrist wrote: > It used to be the fact that if you set flash[:notice] and try to render > the page, the flash message will not be displayed. That's why they have to > implement `flash.now`. Is that still the case? > Currently if you set flash[:notice] an

Re: [Rails-core] Is flash.now necessary?

2012-09-07 Thread Robert Pankowecki
I sometimes use flash to keep things between multiple request ex. searched word and use FlashHash#keep in before filter to keep it when user is still using the same controller. How can I keep something for the next request when rendering in your proposed solution? Would I have to set flash and keep

Re: [Rails-core] Is flash.now necessary?

2012-09-07 Thread George Ogata
On Fri, Sep 7, 2012 at 4:02 PM, Robert Pankowecki < robert.pankowe...@gmail.com> wrote: > I sometimes use flash to keep things between multiple request ex. > searched word and use FlashHash#keep in before filter to keep it when > user is still using the same controller. Can you provide more info

Re: [Rails-core] Is flash.now necessary?

2012-09-07 Thread Robert Pankowecki
> Can you provide more info on what you're doing with this searched word? > Highlighting? I was just using it for coherent navigation. You could go like search => show => edit => update => index and see the list filtered with the searched keyword. > My initial reaction is it's a dubious practice,

Re: [Rails-core] Is flash.now necessary?

2012-09-07 Thread George Ogata
On Fri, Sep 7, 2012 at 5:15 PM, Robert Pankowecki < robert.pankowe...@gmail.com> wrote: > > Can you provide more info on what you're doing with this searched word? > > Highlighting? > > I was just using it for coherent navigation. You could go like search > => show => edit => update => index and s

Re: [Rails-core] Is flash.now necessary?

2012-09-23 Thread ghazel
On Fri, Sep 7, 2012 at 2:32 PM, George Ogata wrote: > On Fri, Sep 7, 2012 at 5:15 PM, Robert Pankowecki < > robert.pankowe...@gmail.com> wrote: > >> > Can you provide more info on what you're doing with this searched word? >> > Highlighting? >> >> I was just using it for coherent navigation. You