Having just spent a lot of time wading through the HMT and HOT code,
I'll agree that there is a lot of room for improvement w.r.t.
clarity. And if there is a general agreement that a refactoring is
needed then the longer we wait the tougher the job will be. I would
encourage Adam's effort.
Howe
On Wed, Apr 22, 2009 at 10:51 AM, Pratik wrote:
>
> Which problem is it solving for you ? Do you see any performance gains
> that I'm missing ? Do you believe if this is making any code easier to
> understand ? Could you please provide failing tests which are to be
> fixed by the refactoring in q
Which problem is it solving for you ? Do you see any performance gains
that I'm missing ? Do you believe if this is making any code easier to
understand ? Could you please provide failing tests which are to be
fixed by the refactoring in question ?
Thanks.
On Wed, Apr 22, 2009 at 6:15 PM, DWF w
Given that the GSOC Rails projects involve some ActiveRecord
refactorings, doesn't this type of improvement make sense?
--dwf
On Mar 8, 12:42 pm, Niels Ganser wrote:
> I realize us Rubyists don't necessarily think the classic works in the
> field such as Fowler's "Refactoring" apply to our day-
I realize us Rubyists don't necessarily think the classic works in the
field such as Fowler's "Refactoring" apply to our day-to-day coding in
their entirety but in this case I fully agree with Fowler when he says
"You don't decide to refactor, you refactor because you want to do
something else
Even if Adam patch make other patches stales, since it cleans up
current ActiveRecord associations code, it wouldn't be hard for others
users to redo their patch. IMHO, it would be even better for people
who are going to make patches in the future.
Rails core guys are obviously very familiar with
On Sat, Mar 7, 2009 at 7:35 PM, Adam wrote:
> More importantly, the added complexity created by importing all of the
> collection logic and interface into a non-collection association class
> just adds to rigidity and potential for odd bugs in the future.
Let's do this refactoring when that actu
