On Jan 25, 2008 9:22 PM, Michael Koziarski <[EMAIL PROTECTED]> wrote:
>
> I'm happy with the documentation but not sure I buy the need for
> #8720?
Why match the API of polymorphic_path with polymorphic_url? Because there is
no need for these two to have different signatures, especially since
ge
> OK, so we're keeping formatted_foo helpers for now. But what of my patch?
>
> http://dev.rubyonrails.org/ticket/10883
>
> It fixes issues. It adds tons of documentation. It provides more test
> coverage. Is there anything wrong with it? Anything that someone would like
> to put up for discussion
OK, so we're keeping formatted_foo helpers for now. But what of my patch?
http://dev.rubyonrails.org/ticket/10883
It fixes issues. It adds tons of documentation. It provides more test
coverage. Is there anything wrong with it? Anything that someone would like
to put up for discussion, or to have m
> I've often wondered why (apart from specific implementation reasons) we need
> a formatted_xxx helper to cater for formats at all.
I don't believe there's a reason beyond the (considerable)
implementation specific reasons :). Changing that with the current
routing implementation would probabl
I'm frequently in need of generating a formatted polymorphic url.
Currently, it's done ugly because the formatted_polymorphic_url code
is broken (see ticket 8782 and Mislav's #2 above). I would like to
see that helper working-but if the job can be done with something
simpler, I'm all for it. Tre
On 1/21/08, Michael Koziarski <[EMAIL PROTECTED]> wrote:
>
> On Jan 22, 2008 9:28 AM, Mislav Marohnić <[EMAIL PROTECTED]>
> wrote:
> >
> > Should this work: polymorphic_url(@article, :format => :pdf) ? Currently
> it
> > doesn't. I've included a failing tests, it's commented out.OpenActionPack
>
>
2008/1/22 Michael Koziarski <[EMAIL PROTECTED]>:
> > What's still broken? (I decided not to fix everything in one go.)
> > Hash argument: polymorphic_url(:id => @article). Test is commented out
> (like
> > before).
> > Should this work: polymorphic_url(@article, :format => :pdf) ? Currently
> it
>
On Jan 22, 2008 9:28 AM, Mislav Marohnić <[EMAIL PROTECTED]> wrote:
> Yesterday I answered a question regarding polymorphic URL helpers on Core ML
> and noticed that the module has no documentation. I've documented it and
> rewritten unit tests using Mocha. I also optimized some of the code slightl
