[Rails-core] Re: tzinfo-0.3.11 bundled with activesupport-2.1.2 is incomplete

2008-11-18 Thread Chad Woolley
On Tue, Nov 18, 2008 at 8:57 AM, Geoff B [EMAIL PROTECTED] wrote: Adam and Chad -- curious to know if this setup would work for you: I was just bikeshedding about the dubiousness of bundling a hacked version of a dependency gem in another gem, and adding code manage the resulting problems. I

[Rails-core] Re: tzinfo-0.3.11 bundled with activesupport-2.1.2 is incomplete

2008-11-14 Thread Geoff B
On Nov 13, 1:25 pm, Adam Greene [EMAIL PROTECTED] wrote: Geoff, it sounds like there is not an easy solution except perhaps if you bundle a version like 0.3.11 but rails *requires* 0.3.9, use ~0.3.9 for the config.gem version rather than always incrementing it to 0.3.11. If ActiveSupport

[Rails-core] Re: tzinfo-0.3.11 bundled with activesupport-2.1.2 is incomplete

2008-11-14 Thread Geoff B
On Nov 14, 8:50 am, Geoff B [EMAIL PROTECTED] wrote: Fyi, Rails should be compatible with any tzinfo version in the 0.3.x series (and possibly the 0.2.x series, though I haven't tested this recently.) For the most part, the version upgrades are just changes to tzdata; there haven't been any

[Rails-core] Re: tzinfo-0.3.11 bundled with activesupport-2.1.2 is incomplete

2008-11-14 Thread Geoff B
On Nov 14, 8:50 am, Geoff B [EMAIL PROTECTED] wrote: I do think we should respect a version explicitly specified via config.gem, even if it's an older version than the bundled one (which we're not doing right now.) The caveat with this setup would be, the GMT offsets that appear in the

[Rails-core] Re: tzinfo-0.3.11 bundled with activesupport-2.1.2 is incomplete

2008-11-14 Thread Adam Greene
hey geoff, If ActiveSupport required an older version than what was bundled, you'd run the risk of requiring an older version of the gem that happened to be installed on your system, even if you didn't explicitly declare it via config.gem. that actually isn't true. I had tzinfo 0.3.10

[Rails-core] Re: tzinfo-0.3.11 bundled with activesupport-2.1.2 is incomplete

2008-11-13 Thread Adam Greene
Good conversation! Geoff, it sounds like there is not an easy solution except perhaps if you bundle a version like 0.3.11 but rails *requires* 0.3.9, use ~0.3.9 for the config.gem version rather than always incrementing it to 0.3.11. But that could create additional issues like missing a

[Rails-core] Re: tzinfo-0.3.11 bundled with activesupport-2.1.2 is incomplete

2008-11-13 Thread Chad Woolley
On Thu, Nov 13, 2008 at 12:25 PM, Adam Greene [EMAIL PROTECTED] wrote: If I'm the only one who was bit by this issue, then so be it. But if it keeps coming up, putting the full gem (with the extra 2.6 megs and hundreds of files; yes it is a beast!) into vendor/ doesn't seem to be all that

[Rails-core] Re: tzinfo-0.3.11 bundled with activesupport-2.1.2 is incomplete

2008-11-12 Thread Michael Koziarski
On Wed, Nov 12, 2008 at 3:42 AM, David Masover [EMAIL PROTECTED] wrote: On Tue, Nov 11, 2008 at 7:11 PM, Geoff B [EMAIL PROTECTED] wrote: Also, Tzinfo is not the only non-Rails dependency: see the vendor directories in ActionMailer, ActionController and ActiveSupport. Do you suggest that

[Rails-core] Re: tzinfo-0.3.11 bundled with activesupport-2.1.2 is incomplete

2008-11-12 Thread Michael Koziarski
On Wed, Nov 12, 2008 at 3:42 AM, David Masover [EMAIL PROTECTED] wrote: On Tue, Nov 11, 2008 at 7:11 PM, Geoff B [EMAIL PROTECTED] wrote: Also, Tzinfo is not the only non-Rails dependency: see the vendor directories in ActionMailer, ActionController and ActiveSupport. Do you suggest that

[Rails-core] Re: tzinfo-0.3.11 bundled with activesupport-2.1.2 is incomplete

2008-11-11 Thread Chad Woolley
On Tue, Nov 11, 2008 at 7:27 AM, Geoff B [EMAIL PROTECTED] wrote: Adam, The bundled tzinfo is a slimmed-down version that only includes the classes and zone definitions necessary to support ActiveSupport::TimeZone. This chops ~2.8MB from the size of tzinfo, and hundreds of files, so it

[Rails-core] Re: tzinfo-0.3.11 bundled with activesupport-2.1.2 is incomplete

2008-11-11 Thread Geoff B
Adam, The bundled tzinfo is a slimmed-down version that only includes the classes and zone definitions necessary to support ActiveSupport::TimeZone. This chops ~2.8MB from the size of tzinfo, and hundreds of files, so it seems worth it. But as far as trying to require a complete version of the

[Rails-core] Re: tzinfo-0.3.11 bundled with activesupport-2.1.2 is incomplete

2008-11-11 Thread Geoff B
On Nov 11, 2:02 pm, Chad Woolley [EMAIL PROTECTED] wrote: Why does it need to be bundled rather than be a normal gem dependency? By bundling tzinfo, everything works out of the box -- if you freeze rails into vendor, you can then deploy anywhere, even on boxes that don't have rails or tzinfo

[Rails-core] Re: tzinfo-0.3.11 bundled with activesupport-2.1.2 is incomplete

2008-11-11 Thread David Masover
Isn't there a method of freezing not just rails, but all gems your project uses? Seems to me that if you're dealing with an uncooperative host, that's the route you want to go -- those of us with cooperative hosts would probably rather manage things with gems. Often, that's unavoidable --

[Rails-core] Re: tzinfo-0.3.11 bundled with activesupport-2.1.2 is incomplete

2008-11-11 Thread Chad Woolley
On Tue, Nov 11, 2008 at 4:57 PM, Geoff B [EMAIL PROTECTED] wrote: On Nov 11, 2:02 pm, Chad Woolley [EMAIL PROTECTED] wrote: Why does it need to be bundled rather than be a normal gem dependency? By bundling tzinfo, everything works out of the box -- if you freeze rails into vendor, you can

[Rails-core] Re: tzinfo-0.3.11 bundled with activesupport-2.1.2 is incomplete

2008-11-11 Thread Geoff B
Please keep in mind, you *can* manage the full Tzinfo gem via config.gem -- the bug you identified only occurs when you try to require a version that's older than the bundled one. Also, Tzinfo is not the only non-Rails dependency: see the vendor directories in ActionMailer, ActionController and

[Rails-core] Re: tzinfo-0.3.11 bundled with activesupport-2.1.2 is incomplete

2008-11-11 Thread David Masover
On Tue, Nov 11, 2008 at 7:11 PM, Geoff B [EMAIL PROTECTED] wrote: Also, Tzinfo is not the only non-Rails dependency: see the vendor directories in ActionMailer, ActionController and ActiveSupport. Do you suggest that Rails unbundle TMail, Builder, XmlSimple, etc., and add them as