[Rails-core] Test Locations in Rails 4

2012-09-29 Thread Mike Moore
What do folks think about making changes to the default test locations? I would love to see the following changes made: test/units -> test/models test/units/helpers -> test/helpers test/units/lib -> test/lib test/functional -> test/controllers test/functional -> test/mailers

[Rails-core] Test Locations in Rails 4

2012-09-30 Thread Santiago Pastorino
Mike, We decided to do this for Rails 4. Can you go ahead and provide a Pull Request?. Mention me on it and I will merge. Thanks again for putting all this ideas and for minitest-rails :) -- Santiago Pastorino WyeWorks Co-founder http://www.wyeworks.com Twitter: http://twitter.com/spastorino G

Re: [Rails-core] Test Locations in Rails 4

2012-09-29 Thread Godfrey Chan
+0.5 :) I'm using minitest-rails on my newer projects and I liked the structure you picked. It makes it easy to add tests for things like serializers (test/serializers), commands, etc. I think this would be a more reasonable choice of naming for new projects. I just don't know how this is going

Re: [Rails-core] Test Locations in Rails 4

2012-09-29 Thread Luís Ferreira
This is similar to rspec structure which I really like. I believe your proposal being less generic and better fitted to the rails use case is a very nice one. One question though, where do routing tests go? On Sep 29, 2012, at 11:59 PM, Godfrey Chan wrote: > +0.5 :) > > I'm using minitest-rail

Re: [Rails-core] Test Locations in Rails 4

2012-09-29 Thread Mike Moore
On Sep 29, 2012, at 5:17 PM, "Luís Ferreira" wrote: > One question though, where do routing tests go? /test/routes -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com.

Re: [Rails-core] Test Locations in Rails 4

2012-09-29 Thread Luís Ferreira
Yes, seems obvious. Just pointing that out. But the changes seem really nice and makes the placing of test files more obvious and semantic. On Sep 30, 2012, at 12:36 AM, Mike Moore wrote: > On Sep 29, 2012, at 5:17 PM, "Luís Ferreira" wrote: > >> One question though, where do routing tests go?

Re: [Rails-core] Test Locations in Rails 4

2012-09-29 Thread Andrés Mejía
+1. I never saw the point of the existing naming scheme. On Sat, Sep 29, 2012 at 6:39 PM, Luís Ferreira wrote: > Yes, seems obvious. Just pointing that out. But the changes seem really > nice and makes the placing of test files more obvious and semantic. > On Sep 30, 2012, at 12:36 AM, Mike Moor

Re: [Rails-core] Test Locations in Rails 4

2012-09-29 Thread Santiago Pastorino
Hey Mike, I'm personally in favor of what you've proposed. I'm starting a discussion with other Rails core members about it. In case we decide to accept the changes we should be keeping compatibility with the old schema. Only new apps should be using this and old apps should continue working. We c

Re: [Rails-core] Test Locations in Rails 4

2012-09-29 Thread Godfrey Chan
This is probably quite obvious, but I thought I'd point it out anyways. One big advantage of this schema is that there is a one-to-one corresponding between the content of the /app directory and the /test directory. This makes a lot of things very straightforward. For instance, when using guard

Re: [Rails-core] Test Locations in Rails 4

2012-09-29 Thread Mike Moore
On Sep 29, 2012, at 9:42 PM, Santiago Pastorino wrote: > Hey Mike, Hey Santiago. > I'm personally in favor of what you've proposed. I'm starting a > discussion with other Rails core members about it. > In case we decide to accept the changes we should be keeping > compatibility with the old sch

Re: [Rails-core] Test Locations in Rails 4

2012-09-30 Thread Mike Moore
On Sep 30, 2012, at 12:49 PM, Santiago Pastorino wrote: > Mike, > > We decided to do this for Rails 4. > Can you go ahead and provide a Pull Request?. > Mention me on it and I will merge. > > Thanks again for putting all this ideas and for minitest-rails :) Awesome. Will do. Thanks! -- You rec

Re: [Rails-core] Test Locations in Rails 4

2012-10-05 Thread Francesco Rodriguez
Hey guys, Is anyone already working on this task? If not, I would like to do it myself. Francesco. On Sunday, September 30, 2012 2:05:06 PM UTC-5, Mike Moore wrote: > > On Sep 30, 2012, at 12:49 PM, Santiago Pastorino > > > wrote: > > > Mike, > > > > We decided to do this for Rails 4. > >

Re: [Rails-core] Test Locations in Rails 4

2012-10-05 Thread Mike Moore
On Oct 5, 2012, at 12:20 PM, Francesco Rodriguez wrote: > Hey guys, > > Is anyone already working on this task? If not, I would like to do it myself. I'm working on it. Will submit a pull request "soon". ;) -- You received this message because you are subscribed to the Google Groups "Ruby on

Re: [Rails-core] Test Locations in Rails 4

2012-10-08 Thread Mike Moore
FYI: https://github.com/rails/rails/pull/7878 -- You received this message because you are subscribed to the Google Groups "Ruby on Rails: Core" group. To post to this group, send email to rubyonrails-core@googlegroups.com. To unsubscribe from this group, send email to rubyonrails-core+unsubscr