Re: [rust-dev] Weird performance regression in 0.7?

2013-07-07 Thread Björn Steinbrink
On 2013.07.06 22:21:44 +0200, Björn Steinbrink wrote: > The problem is that in 0.7 almost all #[inline(always)] attributes got > replaced by just #[inline]. In your code, this causes the write and > result function for hashing not to be inlined. On its own, this is not a > problem, but unfortunatel

Re: [rust-dev] Weird performance regression in 0.7?

2013-07-06 Thread Björn Steinbrink
On 2013.07.06 22:21:44 +0200, Björn Steinbrink wrote: > The problem is that in 0.7 almost all #[inline(always)] attributes got > replaced by just #[inline]. In your code, this causes the write and > result function for hashing not to be inlined. Well, those two among others. Here's the top 5 funct

Re: [rust-dev] Weird performance regression in 0.7?

2013-07-06 Thread Björn Steinbrink
On 2013.07.06 10:37:49 -0500, Tommy M. McGuire wrote: > When I updated my idiotic anagrams-hashmap toy to 0.7, I seem to have > run across a weird performance regression involving hashmaps. > > Previous runs took approximately 6 seconds, but the 0.7 build is 1) > taking about 35 seconds and 2) ver

Re: [rust-dev] Weird performance regression in 0.7?

2013-07-06 Thread Tommy M. McGuire
On 07/06/2013 10:59 AM, Björn Steinbrink wrote: > On 2013.07.06 17:52:00 +0200, Björn Steinbrink wrote: >> Hi, >> >> On 2013.07.06 10:37:49 -0500, Tommy M. McGuire wrote: >>> Previous runs took approximately 6 seconds, but the 0.7 build is 1) >>> taking about 35 seconds and 2) very variable, since

Re: [rust-dev] Weird performance regression in 0.7?

2013-07-06 Thread Corey Richardson
(This or something derived from it would be nice for https://github.com/mozilla/rust/issues/7532) On Sat, Jul 6, 2013 at 11:37 AM, Tommy M. McGuire wrote: > When I updated my idiotic anagrams-hashmap toy to 0.7, I seem to have > run across a weird performance regression involving hashmaps. > > Pr

Re: [rust-dev] Weird performance regression in 0.7?

2013-07-06 Thread Björn Steinbrink
On 2013.07.06 17:52:00 +0200, Björn Steinbrink wrote: > Hi, > > On 2013.07.06 10:37:49 -0500, Tommy M. McGuire wrote: > > Previous runs took approximately 6 seconds, but the 0.7 build is 1) > > taking about 35 seconds and 2) very variable, since rebuilding it and > > sometimes just running it seve

Re: [rust-dev] Weird performance regression in 0.7?

2013-07-06 Thread Björn Steinbrink
Hi, On 2013.07.06 10:37:49 -0500, Tommy M. McGuire wrote: > Previous runs took approximately 6 seconds, but the 0.7 build is 1) > taking about 35 seconds and 2) very variable, since rebuilding it and > sometimes just running it several more times results in smaller run > times of ~22 seconds. Furt

[rust-dev] Weird performance regression in 0.7?

2013-07-06 Thread Tommy M. McGuire
When I updated my idiotic anagrams-hashmap toy to 0.7, I seem to have run across a weird performance regression involving hashmaps. Previous runs took approximately 6 seconds, but the 0.7 build is 1) taking about 35 seconds and 2) very variable, since rebuilding it and sometimes just running it se