Re: [Ryu-devel] [PATCH 3/4] python3: Fix binary type manipulation

2016-06-02 Thread IWAMOTO Toshihiro
ex), 2): > -result.append(chr(int(given_hex[offset:offset + 2], 16))) > - > -return ''.join(result) > +return b''.join([six.int2byte(int(c, 16)) for c in given_hex.split()]) > -- > 2.7.4 -- IWAMOTO Toshihiro

Re: [Ryu-devel] [PATCH v2 1/3] python3: Return a list instead of a view of the dictionary's values

2016-06-09 Thread IWAMOTO Toshihiro
lass Table(object): > raise NotImplementedError() > > def values(self): > -return self._destinations.values() > +return list(self._destinations.values()) > > def itervalues(self): > return iter(self

[Ryu-devel] [PATCH] Update the readthedoc URL

2016-06-27 Thread IWAMOTO Toshihiro
The hosting site has changed to use readthedocs.io instead of readthedocs.org. Signed-off-by: IWAMOTO Toshihiro --- README.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.rst b/README.rst index 0811218..77df3b3 100644 --- a/README.rst +++ b/README.rst @@ -24,7

[Ryu-devel] [PATCH] Avoid parallel executions of AppManager.close()

2016-06-27 Thread IWAMOTO Toshihiro
If an AppManager.close call is started and all AppManager.services are stop, AppManager.run_apps starts another close() call, resulting in a strange error in close(). Prevent that using a semaphore. Signed-off-by: IWAMOTO Toshihiro --- ryu/base/app_manager.py | 12 1 file changed

Re: [Ryu-devel] [PATCH] Avoid parallel executions of AppManager.close()

2016-06-27 Thread IWAMOTO Toshihiro
At Tue, 28 Jun 2016 14:25:00 +0900, IWAMOTO Toshihiro wrote: > > If an AppManager.close call is started and all AppManager.services > are stop, AppManager.run_apps starts another close() call, > resulting in a strange error in close(). Prevent that using > a semaphore. >

Re: [Ryu-devel] [PATCH] Avoid parallel executions of AppManager.close()

2016-06-27 Thread IWAMOTO Toshihiro
At Tue, 28 Jun 2016 15:02:52 +0900, Takashi YAMAMOTO wrote: > > On Tue, Jun 28, 2016 at 2:25 PM, IWAMOTO Toshihiro > wrote: > > > If an AppManager.close call is started and all AppManager.services > > are stop, AppManager.run_apps starts another close() call, > >

Re: [Ryu-devel] [PATCH] Avoid parallel executions of AppManager.close()

2016-06-28 Thread IWAMOTO Toshihiro
At Tue, 28 Jun 2016 16:19:52 +0900, Takashi YAMAMOTO wrote: > > [1 ] > On Tue, Jun 28, 2016 at 3:16 PM, IWAMOTO Toshihiro > wrote: > > > At Tue, 28 Jun 2016 15:02:52 +0900, > > Takashi YAMAMOTO wrote: > > > > > > On Tue, Jun 28, 2016 at 2:25 PM,

[Ryu-devel] [PATCH v2] Avoid parallel executions of AppManager.close()

2016-06-29 Thread IWAMOTO Toshihiro
If an AppManager.close call is started and all AppManager.services are stopped, AppManager.run_apps starts another close() call, resulting in a KeyError exception in close() (*1). Prevent that using a semaphore. (*1) https://launchpad.net/bugs/1589746 Signed-off-by: IWAMOTO Toshihiro --- ryu

Re: [Ryu-devel] [PATCH v2] Avoid parallel executions of AppManager.close()

2016-06-29 Thread IWAMOTO Toshihiro
At Thu, 30 Jun 2016 10:27:22 +0900, IWAMOTO Toshihiro wrote: > > If an AppManager.close call is started and all AppManager.services > are stopped, AppManager.run_apps starts another close() call, > resulting in a KeyError exception in close() (*1). Prevent that using > a sema

Re: [Ryu-devel] [PATCH 6/9] ofproto/nx_actions: Add default argument to specs field of NXActionLearn

2016-07-07 Thread IWAMOTO Toshihiro
if we need this as NXActionLearn without specs is useless, but this can be written concisely. self.specs = specs if specs is not None else [] > @classmethod > def parser(cls, buf): > -- > 1.9.1 -- IWAMOTO Toshihiro --

Re: [Ryu-devel] [PATCH 4/7] ofproto/nx_actions: Update arguments to be compatible with ovs-ofctl

2016-07-07 Thread IWAMOTO Toshihiro
At Thu, 7 Jul 2016 15:51:10 +0900, Takashi YAMAMOTO wrote: > > [1 ] > [1.1 ] > this change broke dragonflow. > https://bugs.launchpad.net/dragonflow/+bug/1599367 > > i thought we aimed to align with on-wire fields rather than ovs-ofctl etc. > was the policy changed? Sorry I haven't noticed ear

Re: [Ryu-devel] [PATCH] ofproto/nx_actions: Revert API of NXAction

2016-07-20 Thread IWAMOTO Toshihiro
At Wed, 20 Jul 2016 13:36:41 +0900, Shinpei Muraoka wrote: > > This patch will revert the API of NXAction for the following report. > https://bugs.launchpad.net/dragonflow/+bug/1599367 > revert commit id: a01f8f0aa03cd85df2fc07e7217c2a79e7f0 You meant commit 3c3896fd77f274ce953dcb78795aa5cc4f

Re: [Ryu-devel] [PATCH] ofproto/nx_actions: Revert API of NXAction

2016-07-25 Thread IWAMOTO Toshihiro
oad is not used. So we > might be able to have ofs_nbits argument for both if it's more > consistent with the rests. > > Iwamoto-san, what's your opinion? I checked the git history. When I added NXActionRegLoad, I thought ofs and nbits are more user-friendly than ofs_nbit, w

Re: [Ryu-devel] [PATCH v3 2/2] ofproto/nx_actions: Update argument of NXActionCT

2016-07-25 Thread IWAMOTO Toshihiro
Thanks for cleaning up API incoherency. At Fri, 22 Jul 2016 13:59:49 +0900, Shinpei Muraoka wrote: > > Since zone_src in NXActionCT was not possible to specify string, > update zone_src of NXActionCT for the uniformity. > Therefore, you will be able to specify string of OXM/NXM fields for zone_sr

Re: [Ryu-devel] [PATCH v3 2/2] ofproto/nx_actions: Update argument of NXActionCT

2016-07-26 Thread IWAMOTO Toshihiro
At Tue, 26 Jul 2016 16:25:15 +0900, Shinpei Muraoka wrote: > > Hi Iwamoto-San > > > On 2016年07月26日 13:55, IWAMOTO Toshihiro wrote: > > Thanks for cleaning up API incoherency. > > > > At Fri, 22 Jul 2016 13:59:49 +0900, > > Shinpei Muraoka wrote: > >

Re: [Ryu-devel] [PATCH v3 1/2] ofproto/nx_actions: Revert API of NXAction

2016-07-26 Thread IWAMOTO Toshihiro
At Wed, 27 Jul 2016 07:02:29 +0900 (JST), FUJITA Tomonori wrote: > > Iwamoto-san, any comment on this? It might be helpful to mention - NXActionRegLoad now takes ofs_nbits argument instead of ofs and nbits even with this revert and being a bit explicit about what this patch reverts: -

Re: [Ryu-devel] [PATCH v4 1/2] ofproto/nx_actions: Revert API of NXAction

2016-07-27 Thread IWAMOTO Toshihiro
At Wed, 27 Jul 2016 11:35:55 +0900, Shinpei Muraoka wrote: > > This patch will revert the API of NXAction for the following report. > https://bugs.launchpad.net/dragonflow/+bug/1599367 > revert commit id: 3c3896fd77f274ce953dcb78795aa5cc4fde6c65 > > This patch reverts recently introduced start an

Re: [Ryu-devel] [PATCH v4 2/2] ofproto/nx_actions: Update argument of NXActionCT

2016-07-27 Thread IWAMOTO Toshihiro
At Wed, 27 Jul 2016 11:35:56 +0900, Shinpei Muraoka wrote: > > Since zone_src in NXActionCT was not possible to specify string, > update zone_src of NXActionCT for the uniformity. > Therefore, you will be able to specify string of OXM/NXM fields for zone_src. > > If you want to set the immediate

Re: [Ryu-devel] [PATCH 06/20] packet/bgp: Fix to serialize BGPNotification on Python3

2016-08-22 Thread IWAMOTO Toshihiro
At Mon, 22 Aug 2016 09:40:29 +0900, IWASE Yusuke wrote: > > Signed-off-by: IWASE Yusuke > --- > ryu/lib/packet/bgp.py | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/ryu/lib/packet/bgp.py b/ryu/lib/packet/bgp.py > index 697eff3..457f87b 100644 > --- a/ryu/lib/pack

Re: [Ryu-devel] [PATCH 02/20] packet/bgp: Support MPLS-Based Ethernet VPN (RFC7432)

2016-08-22 Thread IWAMOTO Toshihiro
(label & 0xff) >> 0) > -return buf > +return six.binary_type(buf) > > @classmethod > def _label_from_bin(cls, label): > @@ -1030,6 +1031,651 @@ class LabelledVPNIP6AddrPrefix(_LabelledAddrPrefix, > _VPNAdd IIRC, ryu packet library returns bytearr

Re: [Ryu-devel] [PATCH 02/20] packet/bgp: Support MPLS-Based Ethernet VPN (RFC7432)

2016-08-22 Thread IWAMOTO Toshihiro
At Tue, 23 Aug 2016 09:45:30 +0900, Iwase Yusuke wrote: > > Hi Iwamoto-San, > > > On 2016年08月22日 17:31, IWAMOTO Toshihiro wrote: > > At Mon, 22 Aug 2016 09:40:25 +0900, > > IWASE Yusuke wrote: > >> > >> Signed-off-by: IWASE Yusuke > >>

Re: [Ryu-devel] New to openstack

2016-08-23 Thread IWAMOTO Toshihiro
e of Ryu. http://docs.openstack.org/draft/config-reference/networking/networking_options_reference.html#modular-layer-2-ml2-plug-in-configuration-options -- IWAMOTO Toshihiro --

Re: [Ryu-devel] [RYU] Delete flow entry basing on priority

2016-08-29 Thread IWAMOTO Toshihiro
At Tue, 30 Aug 2016 11:49:27 +0900, Iwase Yusuke wrote: > > Hi, > > Please CC ryu-devel@lists.sourceforge.net and keep this mailing this. > > How about specifying out_port=ofproto.OFPP_ANY and out_group=ofproto.OFPG_ANY > to OFPFlowMod message? >e.g.) > mod = parser.OFPFlowMod(datapath=

Re: [Ryu-devel] [RYU] Delete flow entry basing on priority

2016-08-30 Thread IWAMOTO Toshihiro
TE_STRICT messages but not by OFPFC_DELETE messages. And OFPFC_DELETE_STRICT messages don't do wildcard matches. You'll need to dump the entire flow table (OFPFlowStatsRequest) and filter by priority in your python code. > On Tue, Aug 30, 2016 at 10:35 AM, IWAMOTO Toshihiro > wrote: > >

[Ryu-devel] [PATCH] Add Nicira extension vlan_tci field

2016-09-13 Thread IWAMOTO Toshihiro
This Nicira extension field is VLAN VID+CFI+PCP. OXM_OF_VLAN_VID and OXM_OF_VLAN_PCP should work fine in theory, but in OvS it seems vlan_tci must be used to access the CFI bit from NX_LEARN actions. Signed-off-by: IWAMOTO Toshihiro --- ryu/ofproto/nicira_ext.py | 3 +++ 1 file changed, 3

Re: [Ryu-devel] [PATCH] ofproto/ofproto_v1_5_parser: OFPMultipartReply malformed message offset fix

2016-09-28 Thread IWAMOTO Toshihiro
input validation bugs. > > I hope that Fujita-san applies this patch, as well as any others you > submit to resolve any similar such errors, as soon as possible. Agreed. such kind of while-loops are wide-spread throughout ryu/ofproto. We would

Re: [Ryu-devel] [PATCH] ofproto/ofproto_v1_5_parser: OFPMultipartReply malformed message offset fix

2016-09-28 Thread IWAMOTO Toshihiro
At Wed, 28 Sep 2016 17:02:30 +0900, IWAMOTO Toshihiro wrote: > > At Tue, 27 Sep 2016 12:43:51 -0400, > Victor J. Orlikowski wrote: > > > > On Tue, Sep 27, 2016, at 05:19 AM, Michał Rzepka > > wrote: > > > Recently, I discovered major multipart message parser

Re: [Ryu-devel] [PATCH] ofproto/ofproto_v1_5_parser: OFPMultipartReply malformed message offset fix

2016-09-28 Thread IWAMOTO Toshihiro
At Wed, 28 Sep 2016 21:15:49 -0400, Victor J. Orlikowski wrote: > > On Wed, Sep 28, 2016, at 08:32 PM, IWAMOTO Toshihiro > wrote: > > Another option is wrap top-level msg_parser functions with > > eventlet.timeout.Timeout, which amounts to much less amount of code >

[Ryu-devel] [RFC][PATCH] Raise OFPTruncatedMessage exception on truncated messages

2016-09-29 Thread IWAMOTO Toshihiro
other OpenFlow versions, too. [1] https://bugs.launchpad.net/dragonflow/+bug/1624826 Signed-off-by: IWAMOTO Toshihiro --- ryu/exception.py | 13 +++ ryu/ofproto/ofproto_v1_3_parser.py | 71 +- 2 files changed, 67 insertions(+), 17

Re: [Ryu-devel] [PATCH] ofproto/nicira_ext: Add missing NXMs in OVS v2.6.0

2016-09-29 Thread IWAMOTO Toshihiro
llowing the ovs-ofctl style? (Just asking, not asking for implementing that.) > === > == > > .. Note:: > @@ -481,17 +603,50 @@ reg Integer 32bi

[Ryu-devel] [PATCH 3/3] test_parser: Add an truncate packet test

2016-10-07 Thread IWAMOTO Toshihiro
Signed-off-by: IWAMOTO Toshihiro --- .../of13/libofproto-OFP13-flow_mod.truncated64 | 0 ...bofproto-OFP13-flow_mod.packet.truncated64.json | 33 ++ 2 files changed, 33 insertions(+) create mode 100644 ryu/tests/packet_data/of13/libofproto-OFP13-flow_mod.truncated64

[Ryu-devel] [PATCH 2/3] test_parser: Enable tests for truncated packets

2016-10-07 Thread IWAMOTO Toshihiro
When there are files named "*.truncated%d" in the packet_data directories, they are treated as special instructions; test method are generated by truncating wire_msg from corresponding "*.packet" files. Signed-off-by: IWAMOTO Toshihiro --- ryu/tests/unit/ofproto

[Ryu-devel] [PATCH 1/3] ofproto_v1_3_parser: Raise OFPTruncatedMessage exception on truncated messages

2016-10-07 Thread IWAMOTO Toshihiro
Signed-off-by: IWAMOTO Toshihiro --- ryu/exception.py | 13 +++ ryu/ofproto/ofproto_parser.py | 15 ++-- ryu/ofproto/ofproto_v1_3_parser.py | 71 +- 3 files changed, 79 insertions(+), 20 deletions(-) diff --git a/ryu/exception.py b

[Ryu-devel] [PATCH 0/3] parsing truncated ofp messages

2016-10-07 Thread IWAMOTO Toshihiro
This set of patches is for parsing truncated ofp messages and test support for it. Support for truncated message is far from complete, but it can be made better if needed. IWAMOTO Toshihiro (3): ofproto_v1_3_parser: Raise OFPTruncatedMessage exception on truncated messages test_parser

Re: [Ryu-devel] [RFC][PATCH] Raise OFPTruncatedMessage exception on truncated messages

2016-10-07 Thread IWAMOTO Toshihiro
At Mon, 3 Oct 2016 18:32:34 +0900, Takashi YAMAMOTO wrote: > > On Thu, Sep 29, 2016 at 4:44 PM, IWAMOTO Toshihiro > wrote: > > > OFPT_ERROR_MSG can return truncated messages. Some users want to > > see them in human-friendly format [1]. Catch exceptions caused > &

[Ryu-devel] [PATCH] Log OFPErrorMsg.data as ascii when type is OFPET_HELLO_FAILED

2016-10-20 Thread IWAMOTO Toshihiro
OFPErrorMsg.data usually contains the offending OpenFlow message, but is an ASCII text string if its type is OFPET_HELLO_FAILED. Signed-off-by: IWAMOTO Toshihiro --- ryu/controller/ofp_handler.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ryu/controller

Re: [Ryu-devel] [PATCH v3 8/9] pip: Separate test-requires

2016-11-10 Thread IWAMOTO Toshihiro
At Tue, 8 Nov 2016 17:13:46 +0900, IWASE Yusuke wrote: > > Currently, in addition to "requirements for tests", test-requires > includes "optional requirements". > This makes it unclear to identify which packages are surely required > to use optional features (e.g., RPC, OF-Config, OVSDB) and caus

Re: [Ryu-devel] [PATCH v3 8/9] pip: Separate test-requires

2016-11-10 Thread IWAMOTO Toshihiro
At Fri, 11 Nov 2016 11:30:33 +0900 (JST), FUJITA Tomonori wrote: > > On Fri, 11 Nov 2016 11:24:25 +0900 > Iwase Yusuke wrote: > > > Hi Iwamoto-San, > > > > > > On 2016年11月11日 11:11, IWAMOTO Toshihiro wrote: > >> At Tue, 8 Nov

Re: [Ryu-devel] [PATCH] adding DHCPv6 support

2016-11-21 Thread IWAMOTO Toshihiro
ls(code, data, length) > + > +def serialize(self): > +if self.length == 0: > +self.length = len(self.data) > +options_pack_str = self._PACK_STR % self.length > +return struct.pack(options_pack_str, self.code, self.length

Re: [Ryu-devel] 回复: RYU BUG

2016-12-04 Thread IWAMOTO Toshihiro
At Mon, 5 Dec 2016 10:13:41 +0800, =?gb18030?B?Li4uLi4uLg==?= wrote: > > [1 ] > [1.1 ] > Hello, I am China Shenzhen TICOMM Information Technology Co. Ltd. > What does "under the slow speed" exactly mean? > answer:The interval of we use ofctl_rest.py file exactly serach an flow > table, > retu

Re: [Ryu-devel] [PATCH 7/7] BGPSpeaker: Enable to set capability for IPv6

2016-12-11 Thread IWAMOTO Toshihiro
At Thu, 8 Dec 2016 15:28:42 +0900, Iwase Yusuke wrote: > > Hi Kakuma-San, > > > On 2016年12月08日 15:06, fumihiko kakuma wrote: > > On Mon, 7 Nov 2016 16:04:23 +0900 > > IWASE Yusuke wrote: > > > >> This patch enables BGPSpeaker to set the capability for IPv6 unicast > >> address family. > >> >

Re: [Ryu-devel] [PATCH 7/7] BGPSpeaker: Enable to set capability for IPv6

2016-12-14 Thread IWAMOTO Toshihiro
At Wed, 14 Dec 2016 16:26:48 +0900, Iwase Yusuke wrote: > > Hi, > > On 2016年12月14日 15:28, FUJITA Tomonori wrote: > > On Mon, 12 Dec 2016 12:57:02 -0500 > > "Victor J. Orlikowski" wrote: > > > >> On Mon, Dec 12, 2016, at 11:21 AM, IWAMOTO Toshihi

Re: [Ryu-devel] [PATCH 7/7] BGPSpeaker: Enable to set capability for IPv6

2016-12-14 Thread IWAMOTO Toshihiro
At Thu, 15 Dec 2016 15:33:30 +0900 (JST), FUJITA Tomonori wrote: > > On Thu, 15 Dec 2016 14:31:25 +0900 > IWAMOTO Toshihiro wrote: > > > At Wed, 14 Dec 2016 16:26:48 +0900, > > Iwase Yusuke wrote: > >> > >> Hi, > >> > >> On 2016年12月

Re: [Ryu-devel] About Ryu OpenStack Plugins doc

2016-12-19 Thread IWAMOTO Toshihiro
ould remove the above doc page and wiki page > (https://github.com/osrg/ryu/wiki/OpenStack) linked from this page in the > near future. The above wiki link is also on the ryu top page https://osrg.github.io/ryu/. It is better to handle this

[Ryu-devel] [PATCH 1/3] nicira_ext: Define some CT constants

2017-04-26 Thread IWAMOTO Toshihiro
Signed-off-by: IWAMOTO Toshihiro --- ryu/ofproto/nicira_ext.py | 5 + 1 file changed, 5 insertions(+) diff --git a/ryu/ofproto/nicira_ext.py b/ryu/ofproto/nicira_ext.py index 411ed48..416c625 100644 --- a/ryu/ofproto/nicira_ext.py +++ b/ryu/ofproto/nicira_ext.py @@ -269,6 +269,11

[Ryu-devel] [PATCH 3/3] ofproto: Add some tests for ofp_instruction_from_str

2017-04-26 Thread IWAMOTO Toshihiro
Signed-off-by: IWAMOTO Toshihiro --- ryu/tests/unit/ofproto/test_ofctl_string.py | 134 1 file changed, 134 insertions(+) create mode 100644 ryu/tests/unit/ofproto/test_ofctl_string.py diff --git a/ryu/tests/unit/ofproto/test_ofctl_string.py b/ryu/tests/unit

[Ryu-devel] [PATCH 0/3] Add ovs-ofctl style action string parser

2017-04-26 Thread IWAMOTO Toshihiro
This set of patches allow users to use ovs-ofctl style action strings to build OFPInstructionActions, which may help transition from ovs-ofctl. Support is currently very limited and many from_string() method should be added for this to be useful. IWAMOTO Toshihiro (3): nicira_ext: Define some

[Ryu-devel] [PATCH 2/3] ofproto: Add ovs-ofctl style action string parser

2017-04-26 Thread IWAMOTO Toshihiro
This commit adds a new method called ofp_instruction_from_str, which takes an ovs-ofctl style action string and returns a list of OFPInstructionActions. Currently only a few action strings are understood. Signed-off-by: IWAMOTO Toshihiro --- ryu/exception.py | 4 ++ ryu

Re: [Ryu-devel] [PATCH 0/3] Add ovs-ofctl style action string parser

2017-04-26 Thread IWAMOTO Toshihiro
At Wed, 26 Apr 2017 21:56:33 +0900 (JST), FUJITA Tomonori wrote: > > On Wed, 26 Apr 2017 15:58:43 +0900 > IWAMOTO Toshihiro wrote: > > > This set of patches allow users to use ovs-ofctl style action > > strings to build OFPInstructionActions, which may help trans

[Ryu-devel] [PATCH v2 2/3] ofproto: Add ovs-ofctl style action string parser

2017-05-02 Thread IWAMOTO Toshihiro
This commit adds a new method called ofp_instruction_from_str, which takes an ovs-ofctl style action string and returns a list of OFPInstructionActions. Currently only a few action strings are understood. Signed-off-by: IWAMOTO Toshihiro --- ryu/exception.py | 4 ++ ryu

[Ryu-devel] [PATCH v2 0/3] Add ovs-ofctl style action string parser

2017-05-02 Thread IWAMOTO Toshihiro
ded goto_table support and some more tests IWAMOTO Toshihiro (3): nicira_ext: Define some CT constants ofproto: Add ovs-ofctl style action string parser ofproto: Add some tests for ofp_instruction_from_str ryu/exception.py| 4 + ryu/ofproto/nicira_ext

[Ryu-devel] [PATCH v2 3/3] ofproto: Add some tests for ofp_instruction_from_str

2017-05-02 Thread IWAMOTO Toshihiro
Signed-off-by: IWAMOTO Toshihiro --- ryu/tests/unit/ofproto/test_ofctl_string.py | 154 1 file changed, 154 insertions(+) create mode 100644 ryu/tests/unit/ofproto/test_ofctl_string.py diff --git a/ryu/tests/unit/ofproto/test_ofctl_string.py b/ryu/tests/unit

[Ryu-devel] [PATCH v2 1/3] nicira_ext: Define some CT constants

2017-05-02 Thread IWAMOTO Toshihiro
Signed-off-by: IWAMOTO Toshihiro --- ryu/ofproto/nicira_ext.py | 5 + 1 file changed, 5 insertions(+) diff --git a/ryu/ofproto/nicira_ext.py b/ryu/ofproto/nicira_ext.py index 411ed48..416c625 100644 --- a/ryu/ofproto/nicira_ext.py +++ b/ryu/ofproto/nicira_ext.py @@ -269,6 +269,11

[Ryu-devel] [PATCH] Allow CIDR notation for ip match fields

2017-05-08 Thread IWAMOTO Toshihiro
admit this code is a gross hack. :( IWAMOTO Toshihiro (1): ofproto: Allow CIDR notation for ipv[46]_{src,dst} ryu/lib/addrconv.py | 20 ryu/ofproto/oxx_fields.py | 3 +++ 2 files changed, 19 insertions(+), 4 del

[Ryu-devel] [PATCH] ofproto: Allow CIDR notation for ipv[46]_{src, dst}

2017-05-08 Thread IWAMOTO Toshihiro
This hack allows CIDR notations for OFPMatch. For example: ofpp.OFPMatch(ipv4_src="198.51.100.0/24") Signed-off-by: IWAMOTO Toshihiro --- ryu/lib/addrconv.py | 20 ryu/ofproto/oxx_fields.py | 3 +++ 2 files changed, 19 insertions(+), 4 deletions(-) di

Re: [Ryu-devel] [PATCH v2 2/3] ofproto: Add ovs-ofctl style action string parser

2017-05-09 Thread IWAMOTO Toshihiro
tl_* do similar thing, but it wasn't clear for me if the code can be shared/reused. So I took this simpler approach. I'll investigate if this functionality can be put under ryu.lib.ofctl_*. > On 2017年05月02日 16:19, IWAMOTO Toshihiro wrote: > > This commit adds a new method calle

[Ryu-devel] [PATCH v3 0/3] Add ovs-ofctl style action string parser

2017-05-23 Thread IWAMOTO Toshihiro
ing parsers into ryu.lib IWAMOTO Toshihiro (3): nicira_ext: Define some CT constants ofctl: Add ovs-ofctl style action string parser ofctl: Add some tests for ofp_instruction_from_str ryu/exception.py| 4 + ryu/lib/ofctl_string.py |

[Ryu-devel] [PATCH v3 1/3] nicira_ext: Define some CT constants

2017-05-23 Thread IWAMOTO Toshihiro
Signed-off-by: IWAMOTO Toshihiro --- ryu/ofproto/nicira_ext.py | 5 + 1 file changed, 5 insertions(+) diff --git a/ryu/ofproto/nicira_ext.py b/ryu/ofproto/nicira_ext.py index 411ed48..416c625 100644 --- a/ryu/ofproto/nicira_ext.py +++ b/ryu/ofproto/nicira_ext.py @@ -269,6 +269,11

[Ryu-devel] [PATCH v3 2/3] ofctl: Add ovs-ofctl style action string parser

2017-05-23 Thread IWAMOTO Toshihiro
This commit adds a new method called ofp_instruction_from_str, which takes an ovs-ofctl style action string and returns a list of JSON dictionaries. Currently only a few action strings are understood. Signed-off-by: IWAMOTO Toshihiro --- ryu/exception.py | 4 + ryu/lib

[Ryu-devel] [PATCH v3 3/3] ofctl: Add some tests for ofp_instruction_from_str

2017-05-23 Thread IWAMOTO Toshihiro
Signed-off-by: IWAMOTO Toshihiro --- ryu/tests/unit/lib/test_ofctl_string.py | 157 1 file changed, 157 insertions(+) create mode 100644 ryu/tests/unit/lib/test_ofctl_string.py diff --git a/ryu/tests/unit/lib/test_ofctl_string.py b/ryu/tests/unit/lib

Re: [Ryu-devel] [PATCH v3 2/3] ofctl: Add ovs-ofctl style action string parser

2017-05-26 Thread IWAMOTO Toshihiro
At Wed, 24 May 2017 14:58:04 +0900, Iwase Yusuke wrote: > > Hi, > > > On 2017年05月23日 16:05, IWAMOTO Toshihiro wrote: > > diff --git a/ryu/lib/ofctl_string.py b/ryu/lib/ofctl_string.py > > ...(snip) > > + > > +import re > > + > > +import

[Ryu-devel] [PATCH v4 1/3] nicira_ext: Define some CT constants

2017-05-26 Thread IWAMOTO Toshihiro
Signed-off-by: IWAMOTO Toshihiro --- ryu/ofproto/nicira_ext.py | 5 + 1 file changed, 5 insertions(+) diff --git a/ryu/ofproto/nicira_ext.py b/ryu/ofproto/nicira_ext.py index 411ed48..416c625 100644 --- a/ryu/ofproto/nicira_ext.py +++ b/ryu/ofproto/nicira_ext.py @@ -269,6 +269,11

[Ryu-devel] [PATCH v4 3/3] ofctl: Add some tests for ofp_instruction_from_str

2017-05-26 Thread IWAMOTO Toshihiro
Signed-off-by: IWAMOTO Toshihiro --- ryu/tests/unit/lib/test_ofctl_string.py | 151 1 file changed, 151 insertions(+) create mode 100644 ryu/tests/unit/lib/test_ofctl_string.py diff --git a/ryu/tests/unit/lib/test_ofctl_string.py b/ryu/tests/unit/lib

[Ryu-devel] [PATCH v4 0/3] Add ovs-ofctl style action string parser

2017-05-26 Thread IWAMOTO Toshihiro
n's comments v2 -> v3: - Moved action string parsers into ryu.lib IWAMOTO Toshihiro (3): nicira_ext: Define some CT constants ofctl: Add ovs-ofctl style action string parser ofctl: Add some tests for ofp_instruction_from_str ryu/exception.py| 4

[Ryu-devel] [PATCH v4 2/3] ofctl: Add ovs-ofctl style action string parser

2017-05-26 Thread IWAMOTO Toshihiro
This commit adds a new method called ofp_instruction_from_str, which takes an ovs-ofctl style action string and returns a list of JSON dictionaries. Currently only a few action strings are understood. Signed-off-by: IWAMOTO Toshihiro --- ryu/exception.py | 4 + ryu/lib

Re: [Ryu-devel] [PATCH] tests: Revert some test files

2017-07-03 Thread IWAMOTO Toshihiro
At Mon, 3 Jul 2017 10:40:39 +0900, Iwase Yusuke wrote: > > Hi Fujita-San, > > > On 2017年07月02日 20:15, FUJITA Tomonori wrote: > > I did a clean revert because I want to avoid experiments just before > > the new release. > > > > The current size is 1MB, right? Is it the problem? > > No, the curr

[Ryu-devel] [PATCH] ofproto: Avoid emitting illegal instruction sets

2017-07-04 Thread IWAMOTO Toshihiro
The OpenFlow spec forbids multiple occurences of a same instruction type within a mod_flow message, so make sure ofp_instruction_from_jsondict doesn't emit such an instruction set. Signed-off-by: IWAMOTO Toshihiro --- ryu/ofproto/ofproto_parser.py

Re: [Ryu-devel] [PATCH 1/2] flags: Move option definitions from each apps

2017-07-24 Thread IWAMOTO Toshihiro
On Tue, 25 Jul 2017 10:32:25 +0900, IWASE Yusuke wrote: > > Currently, CLI/file configration option are defined in each application, > but in this case, if that application is not loaded before the > initialization in "ryu/cmd/manager.py" (ryu-manager), the application's > option is NOT enabled. >

[Ryu-devel] [PATCH] of14: Implement OFPBundleCtrlMsg parser

2017-10-26 Thread IWAMOTO Toshihiro
Copied from of15 implementation. Signed-off-by: IWAMOTO Toshihiro --- ryu/ofproto/ofproto_v1_4_parser.py| 23 ++- ryu/tests/unit/ofproto/test_parser.py | 2 +- 2 files changed, 23 insertions(+), 2 deletions(-) diff --git a/ryu/ofproto/ofproto_v1_4_parser.py b/ryu

[Ryu-devel] [PATCH 2/4] ofproto_v1_3: Add bundle extension

2017-12-01 Thread IWAMOTO Toshihiro
Signed-off-by: IWAMOTO Toshihiro --- ryu/ofproto/ofproto_v1_3.py| 33 ryu/ofproto/ofproto_v1_3_parser.py | 168 - 2 files changed, 200 insertions(+), 1 deletion(-) diff --git a/ryu/ofproto/ofproto_v1_3.py b/ryu/ofproto/ofproto_v1_3.py index

[Ryu-devel] [PATCH 4/4] packet_data_generator3: Generate OF13 Ext-230 bundle packets

2017-12-01 Thread IWAMOTO Toshihiro
Signed-off-by: IWAMOTO Toshihiro --- ryu/tests/packet_data_generator3/gen.py | 52 ++--- 1 file changed, 42 insertions(+), 10 deletions(-) diff --git a/ryu/tests/packet_data_generator3/gen.py b/ryu/tests/packet_data_generator3/gen.py index b436ec58..cab3e805 100644

[Ryu-devel] [PATCH 3/4] packet_data_generator3: Support ovs-2.8

2017-12-01 Thread IWAMOTO Toshihiro
>From ovs 2.8, ovs-ofctl tries to collect port descriptions, which isn't handled by the fake server in gen.py. Pass the --no-names option to work around this. Signed-off-by: IWAMOTO Toshihiro --- ryu/tests/packet_data_generator3/gen.py | 15 +++ 1 file changed, 15 in

[Ryu-devel] [PATCH 0/4] Add OF1.3 bundle extension

2017-12-01 Thread IWAMOTO Toshihiro
This set of patches add OF1.3 bundle extension, which will be used by OpenStack in near future (I hope). I had to change OFPExperimenter.parser to be able to return ONFBundleCtrlMsg. Some may find the code being ugly. I'll add actual tests later. IWAMOTO Toshihiro (4): ofproto: Co

[Ryu-devel] [PATCH 1/4] ofproto: Correct OFPBundle{Ctrl, Add}Msg docstrings

2017-12-01 Thread IWAMOTO Toshihiro
Signed-off-by: IWAMOTO Toshihiro --- ryu/ofproto/ofproto_v1_4_parser.py | 8 ryu/ofproto/ofproto_v1_5_parser.py | 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/ryu/ofproto/ofproto_v1_4_parser.py b/ryu/ofproto/ofproto_v1_4_parser.py index f927fdba..a73ee7f2

[Ryu-devel] [PATCH] ofproto: add Nicira extension ct_clear action

2018-03-28 Thread IWAMOTO Toshihiro
Signed-off-by: IWAMOTO Toshihiro --- ryu/lib/ofctl_string.py| 4 ++ ryu/ofproto/nicira_ext.py | 1 + ryu/ofproto/nx_actions.py | 38 ++ .../of13/ovs-ofctl-of13-action_ct_clear.packet | Bin 0 ->

Re: [Ryu-devel] About Gathering Delay information

2018-04-01 Thread IWAMOTO Toshihiro
ding time.time() calls and calculation in your switch app is the simplest approach. -- IWAMOTO Toshihiro -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdo

Re: [Ryu-devel] fowarding interface

2018-04-03 Thread IWAMOTO Toshihiro
t find it anywhere. Does an openflow output action work for you? -- IWAMOTO Toshihiro -- Check out the vibrant tech community on one of the world's most engaging tech sites, Slash

Re: [Ryu-devel] Ryu with mininet wifi

2018-04-03 Thread IWAMOTO Toshihiro
#x27; , controller = RemoteController, > ip='192.168.110.187') > > > When I try to run gui_topology.py or shortestpath,py I get the following > (repeatable) output: > > DPSET: Multiple connections from 0001 > Multiple connections from 000

Re: [Ryu-devel] Ryu with mininet wifi

2018-04-08 Thread IWAMOTO Toshihiro
ow can I achieve this? Assuming you are talking about OpenFlow controllers, searching OpenFlow specs for "role" would give you some info. (I'm not an expert here and have no idea how controller roles are actually

Re: [Ryu-devel] Append fields in match

2018-04-09 Thread IWAMOTO Toshihiro
is OpenFlow set 'in_port' but not add 'vlan_vid' in match. Please check the __init__ implementation of OFPMatch. It doesn't support such a coding style. You need to pass all the match fields to the constructor. -- IWAMOTO Toshihiro --

Re: [Ryu-devel] Ryu with mininet wifi

2018-04-11 Thread IWAMOTO Toshihiro
is problem?? > Do you get any errors? I guess the match field isn't matching against your flows. -- IWAMOTO Toshihiro -- Check out the vibrant tech community on one of the world's most engaging tech sites, Sla

Re: [Ryu-devel] Ryu with mininet wifi

2018-04-17 Thread IWAMOTO Toshihiro
t, but didn't get any clear answer. I want to > start from a point where the Ryu controller can receive beacons if the > signal is going under a certain threshold. > Do you have an idea how to do this? > Ryu is about OpenFlow and nothing to do wi

Re: [Ryu-devel] Question about supported devices

2018-04-17 Thread IWAMOTO Toshihiro
m/ has several posts about Ryu usage. I didn't look at articles, though. -- IWAMOTO Toshihiro -- Check out the vibrant tech community on one of the world's most engaging tech sites, Sl

Re: [Ryu-devel] Ryu with mininet wifi

2018-04-22 Thread IWAMOTO Toshihiro
out where is the problem? Did you get any OpenFlow error messages? If not, the group entry should have been set. I guess you can use ovs-ofctl dump-groups and dump-group-stats for debugging. -- IWAMOTO Toshihiro -- Chec

Re: [Ryu-devel] Protocol http

2018-04-22 Thread IWAMOTO Toshihiro
> Is it possible identify packet with protocol http ? You can match on 80/tcp or 443/tcp, if that's enough. -- IWAMOTO Toshihiro -- Check out the vibrant tech community on one of the world's most engaging t

Re: [Ryu-devel] master/slave with zookeeper

2018-04-24 Thread IWAMOTO Toshihiro
de, check the role request message spec. This is not a zookeeper mailing list, but the following link may be useful. http://zookeeper.apache.org/doc/r3.4.11/recipes.html#sc_leaderElection -- IWAMOTO Toshihiro -- Chec

Re: [Ryu-devel] About controlling LLDP packet generation interval

2018-04-24 Thread IWAMOTO Toshihiro
pology discovery I want to disable LLDP packets > unless a link is broken. Please suggest me how can I do such thing. Are you talking about ryu/topology/switches.py? It seems the logic is somewhat hardcoded, you'll need to tweak the lldp_lo

Re: [Ryu-devel] How to make communication between two private networks

2018-04-25 Thread IWAMOTO Toshihiro
? OpenFlow is basically a L2 thing, and I'm not pretty sure it's good for L3 routing. The following page might be of some help. https://github.com/mininet/openflow-tutorial/wiki/Router-Exercise -- IWAMOTO Toshihiro

Re: [Ryu-devel] controller queuing(packet-in messages) - controller performance analysis

2018-04-25 Thread IWAMOTO Toshihiro
EventOFPPacketIn is dynamically defined in ryu/controller/ofp_event.py, and documented in doc/source/ryu_app_api.rst. -- IWAMOTO Toshihiro -- Check out the vibrant tech community on one of the world's most engaging tech s

Re: [Ryu-devel] controller queuing(packet-in messages) - controller performance analysis

2018-04-26 Thread IWAMOTO Toshihiro
On Thu, 26 Apr 2018 12:34:47 +0900, knet solutions wrote: > > [1 ] > [1.1 ] > Hi IWAMOTO Toshihiro, > > Thanks for the pointers. > > How this event gets triggered?. so its like as long as Packet IN received > (FIFO model), it triggers the event? > > > J

Re: [Ryu-devel] master/slave with zookeeper

2018-05-06 Thread IWAMOTO Toshihiro
ny suggestions? Hi, tooz is a OpenStack wrapper library for etcd/zookeeper/whatsoever. I'm not quite sure about details but following links may help you? https://docs.openstack.org/tooz/latest/user/tutorial/leader_election.html https://git.openstack.org/c

Re: [Ryu-devel] RYU application exit signal/event handler

2018-05-07 Thread IWAMOTO Toshihiro
n RYU crashes or RYU Closed(CTRL+C) purposefully. > > Any suggestions? I guess a usual way to do this is properly catching exceptions and installing signal handlers (using signal.signal for example). -- IWAMOTO Toshihiro ---

Re: [Ryu-devel] 404 error when using ryu gui. Is it a bug?

2018-05-08 Thread IWAMOTO Toshihiro
me? Sounds like an import issue. Please check your error messages for any import errors. And also double check you are actually importing the intended files. It is possible files under /usr/lib/python or so are imported unintentionally. -- IWAMOTO Toshihiro

Re: [Ryu-devel] 404 error when using ryu gui. Is it a bug?

2018-05-08 Thread IWAMOTO Toshihiro
On Tue, 08 May 2018 19:27:42 +0900, 林佳烁 wrote: > > [1 ] > 在 2018-05-08 16:31:30,"IWAMOTO Toshihiro" 写道: > >On Tue, 08 May 2018 11:39:38 +0900, > >林佳烁 wrote: > >> > >> [1 ] > >> [1.1 ] > >> Hi, > >> > >

Re: [Ryu-devel] collecting host to switch link information

2018-05-08 Thread IWAMOTO Toshihiro
ent from which > switch port is connected. > > And from the get_link method, the link information are never collected. I guess you are using get_link, get_host etc from ryu.topology.api. The information you need is not defined in OpenFlow and AFAIK ryu.topology.api relies on LLDP to do the

Re: [Ryu-devel] OVSDB library support for SFLOW.

2018-05-08 Thread IWAMOTO Toshihiro
ain of references > to the newly created record from the top-level Open_vSwitch record." > > So is there a way to achieve this through OVSDB library of ryu? Or is there > any equivalent to set up SFLOW through ryu? create doesn't seem to be implemented. I don

Re: [Ryu-devel] Forceing (Packet-In) to send instructions to a specific switch

2018-05-09 Thread IWAMOTO Toshihiro
erated when a packet matches a flow that has a controller action. A packet-in is always sent to a controller. You can implement a packet-in handler that does the job you described above, and the handler can send back a flowmod message to the switch to p

Re: [Ryu-devel] How to run load balancer of SDN hub with Ryu?

2018-05-09 Thread IWAMOTO Toshihiro
I guess you are using a VM image from sdnhub.org. Could you ask the question there? On Wed, 02 May 2018 08:59:28 +0900, Aymen AlAwadi wrote: > > [1 ] > [1.1 ] > Dear all, > > I am trying to run the Load-balancer of SDN hub with Ryu controller using > this guide

Re: [Ryu-devel] Truncated Packets / PCAP Writer

2018-05-09 Thread IWAMOTO Toshihiro
ack 253, win 4096, options > [nop,nop,TS val 800045157 ecr 739067198], length 63 > 23:05:39.995833 IP truncated-ip - 1 bytes missing! amazonaws.com.https > > ubuntu.65277: Flags [P.], seq 253:316, ack 380, win 1136, options [nop,nop,TS > val 739069697 ecr 800045157], length 63 &g

Re: [Ryu-devel] update eventlet version requirements for ryu python package

2018-05-09 Thread IWAMOTO Toshihiro
essage should say "eventlet >= 0.22" or "eventlet > 0.21", but otherwise it looks fine to me. -- IWAMOTO Toshihiro -- Check out the vibrant tech communit

  1   2   3   4   5   >