Hi Fujita-San,
On 2016年07月27日 14:35, FUJITA Tomonori wrote:
> On Thu, 21 Jul 2016 16:41:03 +0900
> Iwase Yusuke wrote:
>
>> Hi Alan,
>>
>> Thank you for reviewing my patch!
>
> Can you please send the patch in the proper format?
Sure, I will send this patch again.
Regards,
Iwase
-
On Thu, 21 Jul 2016 16:41:03 +0900
Iwase Yusuke wrote:
> Hi Alan,
>
> Thank you for reviewing my patch!
Can you please send the patch in the proper format?
--
What NetFlow Analyzer can do for you? Monitors network band
;> app_mgr.close()
>>
>>
>> Is this something you would consider including in the next RYU release?
>>
>> Thanks again,
>> Alan.
>>
>>
>> -Original Message-
>> From: alan_ford...@keysight.com [mailto:alan_ford...@keysight.com]
>
ilto:iwase.yusu...@gmail.com]
Sent: Thursday, July 21, 2016 3:00 AM
To: FORDYCE,ALAN (K-Scotland,ex1) ; v...@duke.edu
Cc: ryu-devel@lists.sourceforge.net
Subject: Re: [Ryu-devel] KeyboardInterrupt (ctrl-c) and RYU
Hi Alan and Victor,
Thank you very much for your suggestions and patch!
But, I am
Hi Victor,
All right, thanks a lot.
On 2016年07月21日 15:49, Victor Orlikowski wrote:
> No - I think you were right the first time; go ahead and follow the naming
> convention. ;)
>
> So long as you made sure to check that LOG isn't referenced anywhere else,
> all's well.
>
> Best,
> Victor
> --
>
No - I think you were right the first time; go ahead and follow the naming
convention. ;)
So long as you made sure to check that LOG isn't referenced anywhere else,
all's well.
Best,
Victor
--
Victor J. Orlikowski <> vjo@[cs.]duke.edu
> On Jul 21, 2016, at 4:59 AM, Iwase Yusuke wrote:
>
> FY
Hi Victor,
Thank you for reviewing my patch.
On 2016年07月21日 11:32, Victor Orlikowski wrote:
Looks good to me, but I have not run it. ;)
A couple of questions/comments:
1) I presume you have verified that all uses of "LOG" have been changed to
"logger"?
Given the scoping, It appears you shoul
Looks good to me, but I have not run it. ;)
A couple of questions/comments:
1) I presume you have verified that all uses of "LOG" have been changed to
"logger"?
Given the scoping, It appears you should have gotten them all.
2) I would re-write the commit message thus:
Currently, ryu-manager emit
---
From: alan_ford...@keysight.com [mailto:alan_ford...@keysight.com]
Sent: Wednesday, July 20, 2016 11:39 AM
To: v...@duke.edu
Cc: ryu-devel@lists.sourceforge.net
Subject: Re: [Ryu-devel] KeyboardInterrupt (ctrl-c) and RYU
Your suggestion of a log message is probably the best approach.
Thanks,
Ala
ng in the next RYU release?
Thanks again,
Alan.
-Original Message-
From: alan_ford...@keysight.com [mailto:alan_ford...@keysight.com]
Sent: Wednesday, July 20, 2016 11:39 AM
To: v...@duke.edu
Cc: ryu-devel@lists.sourceforge.net
Subject: Re: [Ryu-devel] KeyboardInterrupt (ctrl-c) and RYU
] KeyboardInterrupt (ctrl-c) and RYU
Also - should be obvious - but include a comment on the pass, explaining that
you're "papering over" the fact that eventlet doesn't properly wrap the
KeyboardInterrupt inside select()/poll()/epoll().
Another suggestion: instead of a pass, a log mes
Also - should be obvious - but include a comment on the pass, explaining that
you're "papering over" the fact that eventlet doesn't properly wrap the
KeyboardInterrupt inside select()/poll()/epoll().
Another suggestion: instead of a pass, a log message, at debug level (or
whatever desired defau
Suggest just silently swallowing the KeyboardInterrupt (with a "pass"), since
the finally block will cover the close().
Best,
Victor
--
Victor J. Orlikowski <> vjo@[cs.]duke.edu
> On Jul 20, 2016, at 10:27 AM, "alan_ford...@keysight.com"
> wrote:
>
>except KeyboardInterrupt:
>app_
Re: [Ryu-devel] KeyboardInterrupt (ctrl-c) and RYU
Hi,
As you said, Ryu does not catch explicitly catch KeyboardInterrupt, but Ryu
closes Ryu`s application at 'finally' statement, so we don't have to catch it
explicitly, I think.
https://github.com/osrg/ryu/blob/master/ryu/cmd/m
Hi,
As you said, Ryu does not catch explicitly catch KeyboardInterrupt,
but Ryu closes Ryu`s application at 'finally' statement,
so we don't have to catch it explicitly, I think.
https://github.com/osrg/ryu/blob/master/ryu/cmd/manager.py#L100-L101
FYI, you can test it as follows.
$ git diff
Hi All,
Can anyone suggest a fix for this issue?
Thanks,
Alan.
From: FORDYCE,ALAN (K-Scotland,ex1)
Sent: Friday, June 24, 2016 7:42 AM
To: 'ryu-devel@lists.sourceforge.net'
Subject: KeyboardInterrupt (ctrl-c) and RYU
Hi All,
I am new to RYU having previously been using POX as my SDN Controlle
Hi All,
I am new to RYU having previously been using POX as my SDN Controller. One of
the first things that I've noticed when running RYU from my linux command line
is that when I quit RYU with Ctrl-C I get the following exception reported
back...
[root@localhost bin]# /usr/local/bin/ryu-manag
17 matches
Mail list logo
