[sage-combinat-devel] Re: Is there a reason for CombinatorialFreeModule to violate the unique parent condition?

2013-02-26 Thread Simon King
Hi Nicolas, On 2013-02-26, Nicolas M. Thiery nicolas.thi...@u-psud.fr wrote: In my current (not yet posted) patch, the coercion is missing: sage: G = CombinatorialFreeModule(ZZ, [1,2,3,4], prefix=G) sage: y = CombinatorialFreeModule(ZZ, [1,2,3,4], prefix='y') sage:

[sage-combinat-devel] Re: Is there a reason for CombinatorialFreeModule to violate the unique parent condition?

2013-02-26 Thread Simon King
Hi, On 2013-02-26, Simon King simon.k...@uni-jena.de wrote: That's perfect: I don't want this coercion :-) No? ... So, you *really* don't want a coercion between parents that have previously evaluated equal? I.e., in a case where the only difference is the prefix? Then I just change the

[sage-combinat-devel] Re: Is there a reason for CombinatorialFreeModule to violate the unique parent condition?

2013-02-25 Thread Simon King
Hi Nicolas, On 2013-02-25, Nicolas M. Thiery nicolas.thi...@u-psud.fr wrote: It was a design decision that the user could create his own free module by specifying a prefix, even if the base ring and index set is the same. So the result for ``G is y`` is as desired. On the other hand, I

[sage-combinat-devel] Re: Is there a reason for CombinatorialFreeModule to violate the unique parent condition?

2013-02-25 Thread Simon King
Hi Nicolas, On 2013-02-25, Nicolas M. Thiery nicolas.thi...@u-psud.fr wrote: On the other hand, I personally consider that ``G == y`` is buggy: it should return False; the user explicitly asked for G and y to be distinct even if they are trivially isomorphic. The problem that bites us here:

Re: [sage-combinat-devel] Re: Is there a reason for CombinatorialFreeModule to violate the unique parent condition?

2013-02-25 Thread Nicolas M. Thiery
On Mon, Feb 25, 2013 at 07:17:57PM +, Simon King wrote: - Make CombinatorialFreeModule a unique parent, i.e., different prefixes will result in distinct and unequal modules (as suggested by Nicolas). I mentioned in my previous post that this change will not be trivial, but perhaps it

[sage-combinat-devel] Re: Is there a reason for CombinatorialFreeModule to violate the unique parent condition?

2013-02-25 Thread Simon King
Hi Nicolas, On 2013-02-25, Nicolas M. Thiery nicolas.thi...@u-psud.fr wrote: On Mon, Feb 25, 2013 at 07:17:57PM +, Simon King wrote: - Make CombinatorialFreeModule a unique parent, i.e., different prefixes will result in distinct and unequal modules (as suggested by Nicolas). I

Re: [sage-combinat-devel] Re: Is there a reason for CombinatorialFreeModule to violate the unique parent condition?

2013-02-25 Thread Nicolas M. Thiery
On Tue, Feb 26, 2013 at 12:20:14AM +, Simon King wrote: When I made CombinatorialFreeModule inherit from UniqueRepresentation (not only from the new CachedRepresentation), then only very few tests failed (some of them in my coercion tutorial). All of it easy to fix. So, I had a wrong