[sage-devel] Re: Faster roots computation for Sparse Polynomial

2014-06-14 Thread leif
Julian Rüth wrote: Bruno Grenet [2014-06-12 13:47:59 +0200]: - The algorithm I implemented uses some auxiliary functions that are not of real interest outside the algorithm. How should I do to avoid this functions be available for the users? If you turn these auxiliary functions into methods o

[sage-devel] Re: Faster roots computation for Sparse Polynomial

2014-06-16 Thread Jean-Pierre Flori
Hi all, I'm going to hijack this topic for a related question: I've been working a little bit on factorization/root computation of polynomials over finite fields and am not really satisfied with the way the current state of affair. Just as in Bruno's case, there is a huge any_root function in p

[sage-devel] Re: Faster roots computation for Sparse Polynomial

2014-06-19 Thread Nils Bruin
On Friday, June 13, 2014 6:28:17 PM UTC-4, Bruno Grenet wrote: > > Dear all, > > I am new to Sage development and I'd like some help or advice for the > following task: > > There is right now no specific algorithm for computing roots of Sparse > Polynomials in Sage. Such algorithms exist, at lea

Re: [sage-devel] Re: Faster roots computation for Sparse Polynomial

2014-06-16 Thread Bruno Grenet
Dear all, Thanks for your replies! I am still confused by a couple of things. First, I looked for these "_roots_univariate_polynomial" functions but they do not seem to be defined anywhere ("grep -rl _roots_univariate_polynomial SAGE_ROOT/src/sage/" only gives rings/polynomial/polynomial_elem

Re: [sage-devel] Re: Faster roots computation for Sparse Polynomial

2014-06-16 Thread Julian Rüth
* Bruno Grenet [2014-06-16 23:41:31 +0200]: > First, I looked for these "_roots_univariate_polynomial" functions but they > do not seem to be defined anywhere ("grep -rl _roots_univariate_polynomial > SAGE_ROOT/src/sage/" only gives rings/polynomial/polynomial_element.c and > rings/polynomial/poly

Re: [sage-devel] Re: Faster roots computation for Sparse Polynomial

2014-06-19 Thread Bruno Grenet
Le 17/06/2014 00:01, Julian Rüth a écrit : * Bruno Grenet [2014-06-16 23:41:31 +0200]: First, I looked for these "_roots_univariate_polynomial" functions but they do not seem to be defined anywhere ("grep -rl _roots_univariate_polynomial SAGE_ROOT/src/sage/" only gives rings/polynomial/polynom

Re: [sage-devel] Re: Faster roots computation for Sparse Polynomial

2014-06-19 Thread Julian Rüth
* Bruno Grenet [2014-06-19 09:21:29 +0200]: > Le 17/06/2014 00:01, Julian Rüth a écrit : > >In your case you would add a method _roots_univariate_polynomial to > >sage.rings.integer_ring.IntegerRing_class. > I have the following problem using this strategy of a > _roots_univariate_polynomial metho

Re: [sage-devel] Re: Faster roots computation for Sparse Polynomial

2014-06-24 Thread Bruno Grenet
Following your advices, I have created a ticket (#16516 ) on trac, and pushed a modification. I changed the Polynomial.roots function to look at the return value of _roots_univariate_polynomial and I added a method _roots_univariate_polynomial to IntegerRi