Re: [sage-devel] Re: Wrapping gap.IsConjugate

2013-04-11 Thread Jori Mantysalo
On Tue, 5 Feb 2013, Javier López Peña wrote: Incidentally, I think I misunderstood what you wanted to do. Apparently you are trying to identify conjugate *subgroups* of a group G, whilst what I did works for identifying conjugate *elements* of the group. So feel free to implement your wrapper!

Re: [sage-devel] Re: Wrapping gap.IsConjugate

2013-02-05 Thread Javier López Peña
On Friday, February 1, 2013 1:03:55 PM UTC, jori.ma...@uta.fi wrote: > Should Sage aim to efficient code whenever something is added, or should > we just put in something that works and lock "user interface", i.e. > command or function name, order of arguments etc? > I don't think we have to c

Re: [sage-devel] Re: Wrapping gap.IsConjugate

2013-02-01 Thread Jori Mantysalo
On Fri, 1 Feb 2013, Dima Pasechnik wrote: If I understand correctly, after conjugacy_class(self, g) is done it needs only say conjugacy_class(self, g1)==conjugacy_class(self, g2) to check if This is not efficient - - True. Should Sage aim to efficient code whenever something is added, or s

[sage-devel] Re: Wrapping gap.IsConjugate

2013-02-01 Thread Dima Pasechnik
On 2013-02-01, Jori Mantysalo wrote: > On Thu, 31 Jan 2013, Javier López Peña wrote: > >> there are indeed many GAP method that are not exposed to the sage library. >> A while back I wrote a wrapper for (some) conjugacy classes methods: >> http://trac.sagemath.org/sage_trac/ticket/7886 > >> My pat

Re: [sage-devel] Re: Wrapping gap.IsConjugate

2013-02-01 Thread Javier López Peña
On Friday, February 1, 2013 11:41:40 AM UTC, jori.ma...@uta.fi wrote: > If I understand correctly, after conjugacy_class(self, g) is done it needs > only say conjugacy_class(self, g1)==conjugacy_class(self, g2) to check if > two groups are conjugates. (But still, for convenience there should be

Re: [sage-devel] Re: Wrapping gap.IsConjugate

2013-02-01 Thread Jori Mantysalo
On Thu, 31 Jan 2013, Javier López Peña wrote: there are indeed many GAP method that are not exposed to the sage library. A while back I wrote a wrapper for (some) conjugacy classes methods: http://trac.sagemath.org/sage_trac/ticket/7886 My patches don't merge anymore, but I will try to rebase

[sage-devel] Re: Wrapping gap.IsConjugate

2013-01-31 Thread Dima Pasechnik
On 2013-01-31, Simon King wrote: > Hi Jori, hi Dima, > > On 2013-01-31, Dima Pasechnik wrote: >>> - What is naming policy? Should this be is_conjugate? What is best order >>> for >>> arguments? >> Indeed, I would keep the naming as close to GAP's one as possible. > > "As close as possible" is,

[sage-devel] Re: Wrapping gap.IsConjugate

2013-01-31 Thread Volker Braun
LibGAP should be in Sage-5.7 and I'd say its ready for prime time. I already switched the abelian groups to libgap and am currently rewiring the matrix groups. The permutation groups still need to be done.. On Thursday, January 31, 2013 7:59:41 PM UTC, Javier López Peña wrote: > > Hi Jori, > >

[sage-devel] Re: Wrapping gap.IsConjugate

2013-01-31 Thread Javier López Peña
Hi Jori, there are indeed many GAP method that are not exposed to the sage library. A while back I wrote a wrapper for (some) conjugacy classes methods: http://trac.sagemath.org/sage_trac/ticket/7886 My approach (suggested by N. Thiery) was to create two different classes, a generic one for fal

Re: [sage-devel] Re: Wrapping gap.IsConjugate

2013-01-31 Thread Jori Mantysalo
On Thu, 31 Jan 2013, Simon King wrote: - What is naming policy? Should this be is_conjugate? Indeed, I would keep the naming as close to GAP's one as possible. "As close as possible" is, I think, not a good advice -- because it could be understood to adopt GAP's function name IsConjugate.

[sage-devel] Re: Wrapping gap.IsConjugate

2013-01-31 Thread Simon King
Hi Jori, hi Dima, On 2013-01-31, Dima Pasechnik wrote: >> - What is naming policy? Should this be is_conjugate? What is best order for >> arguments? > Indeed, I would keep the naming as close to GAP's one as possible. "As close as possible" is, I think, not a good advice -- because it could be

[sage-devel] Re: Wrapping gap.IsConjugate

2013-01-31 Thread Dima Pasechnik
On 2013-01-31, Jori Mantysalo wrote: > There is function is_isomorphic in Sage, but there is not is_conjugate. > For curiosity I looked source, and it seems to be an oneliner to write > one: > > def are_conjugates(self, g1, g2): > """ > Returns ``True`` if ``g1`` and ``g2`