hg: jdk8/tl/langtools: 7137836: tidy up Names.java

2012-02-24 Thread jonathan . gibbons
Changeset: e6b5c3aff85c Author:jjg Date: 2012-02-24 10:40 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/e6b5c3aff85c 7137836: tidy up Names.java Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/util/Names.java

Re: Re: Changeset 5052 a589a8dbde79 question

2012-02-24 Thread Christopher Meyer
Hi Seán, you're absolutely right. That's the thing I missed I wasn't aware of the fact that indexOf deals with ASCII format chars. The fix seems to be absolutely ok. In any case, a smart solution to safe operation calls! Sorry for the confusion. Regards, Chris On Friday 24 February 2012 1

Re: Changeset 5052 a589a8dbde79 question

2012-02-24 Thread Seán Coffey
hold on, the indexOf test will match with those ASCII format chars. i.e "/.\56/.\56/.\56/etc/passwd".indexOf("..") returns 1. Is the fix still ok then ?christopher.me...@rub.de regards, Sean On 24/02/12 14:09, Seán Coffey wrote: thanks for raising this point Chris. we certainly don't want a

Re: Changeset 5052 a589a8dbde79 question

2012-02-24 Thread Seán Coffey
thanks for raising this point Chris. we certainly don't want any windows for such an attack. I'll revisit this. regards, Sean. On 24/02/12 13:31, Christopher Meyer wrote: Hi, please correct me if I'm wrong, but the Changeset 5052 in ZoneInfoFile could maybe draw an unexpected SideChannel at Sy

Changeset 5052 a589a8dbde79 question

2012-02-24 Thread Christopher Meyer
Hi, please correct me if I'm wrong, but the Changeset 5052 in ZoneInfoFile could maybe draw an unexpected SideChannel at System.err. Please have a look at the following: TimeZone tzExistent = TimeZone.getTimeZone("/.\56/.\56/.\56/etc/passwd"); will walk the following path: java.util.TimeZone: pu

hg: jdk8/tl/jdk: 7144488: Infinite recursion for some equals tests in Collections

2012-02-24 Thread sean . coffey
Changeset: 0a350fb8b174 Author:coffeys Date: 2012-02-24 09:17 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0a350fb8b174 7144488: Infinite recursion for some equals tests in Collections Reviewed-by: alanb, dholmes, mduigou ! src/share/classes/java/util/Collections.java + te

hg: jdk8/tl/jdk: 7133138: Improve io performance around timezone lookups

2012-02-24 Thread sean . coffey
Changeset: a589a8dbde79 Author:coffeys Date: 2012-02-24 09:10 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a589a8dbde79 7133138: Improve io performance around timezone lookups Reviewed-by: okutsu ! make/tools/src/build/tools/javazic/Mappings.java ! src/share/classes/sun/ut