Re: JDK 8 Review Request for 6854712 (JEP 124), 6637288 and 7126011

2012-05-22 Thread Xuelei Fan
C1. flexibility of the API, maybe too later It may be too later, but I was wondering we may be able to consider the CertPathBuilder/CertPathValidator spec changes a little more. There are two types of cert path checker, one is specified by PKIXParameters.addCertPathChecker() explicit; the other o

Re: code review request: 7162687: enhance KDC server availability detection

2012-05-22 Thread Weijun Wang
On 05/23/2012 09:25 AM, Valerie (Yu-Ching) Peng wrote: The source changes look fine. The re-trying receive() part seems not useful, but if you want to be conservative, that's fine with me too. What is the following change for? @compile -XDignore.symbol.file MaxRetries.java With this line,

Re: code review request: 7162687: enhance KDC server availability detection

2012-05-22 Thread Valerie (Yu-Ching) Peng
The source changes look fine. The re-trying receive() part seems not useful, but if you want to be conservative, that's fine with me too. What is the following change for? @compile -XDignore.symbol.file MaxRetries.java BTW, there is typo on line 43, "tp" should be "to" PortUnreachableExc

Re: JDK 8 Review Request for 6854712 (JEP 124), 6637288 and 7126011

2012-05-22 Thread David Schlosnagle
On Tue, May 22, 2012 at 12:09 PM, Sean Mullan wrote: > Can you please review my changes for 6854712 (JEP 124). It also includes > fixes for a couple of other CRs: 6637288 and 7126011. Other reviewers are > welcome too. > > The webrev: > http://cr.openjdk.java.net/~mullan/webrevs/6854712_6637288_71

hg: jdk8/tl/langtools: 7157798: Add 6 test scenarios for testing inheritance of multiple same-name methods from mulitple interfaces

2012-05-22 Thread james . holmlund
Changeset: f5dbd6895994 Author:jjh Date: 2012-05-21 16:10 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f5dbd6895994 7157798: Add 6 test scenarios for testing inheritance of multiple same-name methods from mulitple interfaces Reviewed-by: mcimadamore Contributed-by: s

Re: RFR: 7169257: Fix for 6424631 only partially ported to JDK 7 & JDK 8

2012-05-22 Thread Seán Coffey
Ok, so I went off today to set up the initial manual unit testcase supplied with 6424631 report. It turns out that 6424631 should no longer be reproducible in 7u or later due to CR 7093090 changes (Reduce synchronization in java.security.Policy.getPolicyNoCheck) The 7093090 changes which went

JDK 8 Review Request for 6854712 (JEP 124), 6637288 and 7126011

2012-05-22 Thread Sean Mullan
Vinnie, Can you please review my changes for 6854712 (JEP 124). It also includes fixes for a couple of other CRs: 6637288 and 7126011. Other reviewers are welcome too. The webrev: http://cr.openjdk.java.net/~mullan/webrevs/6854712_6637288_7126011/webrev.00/ The CRs: http://bugs.sun.com/bug