hg: jdk8/tl/langtools: 2 new changesets

Changeset: 7bebe17ff323 Author:mcimadamore Date: 2013-03-28 11:38 + URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7bebe17ff323 8010469: Bad assertion in LambdaToMethod Summary: Add assertion in LambdaToMethod.serializedLambdaName Reviewed-by: jjg !

Re: code review request: 8010125: keytool -importkeystore could create a pkcs12 keystore with different storepass and keypass

Hello Max, That fix looks fine. Thanks. On 26 Mar 2013, at 23:29, Weijun Wang wrote: http://cr.openjdk.java.net/~weijun/8010125/webrev.00/ Thanks Max

hg: jdk8/tl/jdk: 8010125: keytool -importkeystore could create a pkcs12 keystore with different storepass and keypass

Changeset: a87fac00915e Author:weijun Date: 2013-03-28 20:27 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a87fac00915e 8010125: keytool -importkeystore could create a pkcs12 keystore with different storepass and keypass Reviewed-by: vinnie !

Re: code review request: 7171982 Cipher getParameters() throws RuntimeException: Cannot find SunJCE provider

Hello Tony, Your changes look fine. Thanks. On 22 Mar 2013, at 18:57, Anthony Scarpino wrote: Hi all, I need a code review for below webrev. The changes are to have SunJCE call itself, using it's current instance, for checking such things as parameters, instead of searching through

Re: hg: jdk8/tl/jdk: 8001642: Add OptionalT, OptionalDouble, OptionalInt, OptionalLong

Has the optional classes been verified to serialize/deserialize correctly? They are not serializable. Finally, are these utilities critical to some other part JDK 8 that they were pushed out now as opposed to JDK 9? They are part of the libraries being added by JSR-335 / Project

hg: jdk8/tl/langtools: 8006346: doclint should make allowance for headers generated by standard doclet

Changeset: 991f11e13598 Author:jjg Date: 2013-03-28 10:49 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/991f11e13598 8006346: doclint should make allowance for headers generated by standard doclet Reviewed-by: mcimadamore !

hg: jdk8/tl/jdk: 8010309: Improve PlatformLogger.isLoggable performance by direct mapping from an integer to Level

Changeset: e433ed08b733 Author:mchung Date: 2013-03-28 13:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e433ed08b733 8010309: Improve PlatformLogger.isLoggable performance by direct mapping from an integer to Level Reviewed-by: mchung Contributed-by:

simple code review request: 8001596

Hi all, I have a very simple code review request. It's a typo bug. 8001596 Incorrect condition check in PBKDF2KeyImpl.JAVA https://jbs.oracle.com/bugs/browse/JDK-8001596 http://cr.openjdk.java.net/~mullan/webrevs/ascarpin/8001596/webrev.01/ thanks Tony

Re: code review request: 7171982 Cipher getParameters() throws RuntimeException: Cannot find SunJCE provider

(Vinnie, what do you think about the SunJCE item below?) On 3/22/2013 11:57 AM, Anthony Scarpino wrote: Hi all, I need a code review for below webrev. The changes are to have SunJCE call itself, using it's current instance, for checking such things as parameters, instead of searching through

Re: simple code review request: 8001596

Just realized, there are no regression tests here. Simplest is to probably do as much setup as you can, then java.security.Security.removeProvider(SunJCE), then issue the calls that call into these changes. They should all pass in the new version, and fail in the old. Brad On 3/28/2013

Re: code review request: 7171982 Cipher getParameters() throws RuntimeException: Cannot find SunJCE provider

(Whoops, was working on two reviews with two related comments, and reversed the emails). Just realized, there are no regression tests here. Simplest is to probably do as much setup as you can, then java.security.Security.removeProvider(SunJCE), then issue the calls that call into these

Re: simple code review request: 8001596

There is no regression test. I created one which relies on reflection, which is one way to test this problem. Feel free to create another, but that one is ready to go. Please see the attachment in the bug, and you'll probably want to update the copyright date. Brad On 3/28/2013 2:29

Re: simple code review request: 8001596

I had left the regression test out of this as it was a typo rather than a code logic issue or something someone could rebroken. Are you ok if this goes back without a test? Tony On 03/28/2013 02:46 PM, Brad Wetmore wrote: There is no regression test. I created one which relies on

hg: jdk8/tl/jdk: 8010991: Enable test/javax/script/GetInterfaceTest.java again

Changeset: 811c771acf65 Author:sundar Date: 2013-03-28 14:36 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/811c771acf65 8010991: Enable test/javax/script/GetInterfaceTest.java again Reviewed-by: lagergren, hannesw ! test/javax/script/GetInterfaceTest.java

Re: simple code review request: 8001596

Minor typos that don't affect program execution (comments/javadoc) are ok to not do unit tests, but even through this is a typo, I think this still needs a test. Brad On 3/28/2013 2:51 PM, Anthony Scarpino wrote: I had left the regression test out of this as it was a typo rather than a code

Re: code review request: 7171982 Cipher getParameters() throws RuntimeException: Cannot find SunJCE provider

On 03/28/2013 02:34 PM, Brad Wetmore wrote: (Vinnie, what do you think about the SunJCE item below?) On 3/22/2013 11:57 AM, Anthony Scarpino wrote: Hi all, I need a code review for below webrev. The changes are to have SunJCE call itself, using it's current instance, for checking such things

Review Request 8007035: Deprecate SecurityManager.checkMemberAccess

Sean, John, Joe, Can you review this fix todeprecatesthe |SecurityManager.checkMemberAccess| method as proposed in http://openjdk.java.net/jeps/176? Webrev at: http://cr.openjdk.java.net/~mchung/jdk8/webrevs/8007035/webrev.00 Specdiff: