Re: [8] Review Request for 8007292 : Add JavaFX internal packages to package.access

2013-10-08 Thread David Holmes
Hi Sean, Not a full review. On 9/10/2013 5:52 AM, Sean Mullan wrote: Please review the fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-8007292 This bug requires build changes and a new build tool to add additional restricted packages to the java.security file which are

Re: [8] 8008171: Refactor KeyStore.DomainLoadStoreParameter as a standalone class

2013-10-08 Thread Weijun Wang
The code change looks fine. Do we need a CCC for it? Thanks Max p.s. I would use the bugs.openjdk.java.net URL. On 10/9/13 2:14 AM, Vincent Ryan wrote: Please review the following change - it's a simple re-factoring to promote a nested class to a stand-alone class: Bug: http://bugs.sun.com/b

hg: jdk8/tl/jdk: 7180557: InetAddress.getLocalHost throws UnknownHostException on java7u5 on OSX webbugs

2013-10-08 Thread rob . mckenna
Changeset: f1e31376f419 Author:robm Date: 2013-10-09 00:10 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f1e31376f419 7180557: InetAddress.getLocalHost throws UnknownHostException on java7u5 on OSX webbugs Reviewed-by: chegar, dsamersoff ! src/solaris/native/java/net/Inet4

Correction. Re: Creating an EC Public Key using Named Curves

2013-10-08 Thread Anders Rundgren
Pardon me. It was actually BC 1.45 which screw-up, not JDK 7. Anyway, the bottom line (for me as developer...) is that BC and JDK 7 are incompatible at the src level. thanx Anders On 2013-10-08 17:41, Vincent Ryan wrote: > Currently, there is no public API for named curves. > > However you can

Re: Creating an EC Public Key using Named Curves

2013-10-08 Thread Michael StJohns
At 03:44 PM 10/8/2013, Michael StJohns wrote: This fails using bouncy castle. There is no "EC" factory for AlgorithmParameters for BC 1.49. Mike >I'm going to try out this construct on BouncyCastle and see if it works for >their curve tables. > > > However you can generate named c

[8] Review Request for 8007292 : Add JavaFX internal packages to package.access

2013-10-08 Thread Sean Mullan
Please review the fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-8007292 This bug requires build changes and a new build tool to add additional restricted packages to the java.security file which are not part of OpenJDK. These packages are only added when doing a build i

Re: Creating an EC Public Key using Named Curves

2013-10-08 Thread Anders Rundgren
On 2013-10-08 17:41, Vincent Ryan wrote: > Currently, there is no public API for named curves. > > However you can generate named curves using the SunEC provider and the > ECParameterSpec class. > For example, > > AlgorithmParameters parameters = > AlgorithmParameters.getInstance("EC",

Re: Creating an EC Public Key using Named Curves

2013-10-08 Thread Michael StJohns
*sigh* I need to read emails a lot more closely. Ignore this - for some reason I was reading this as the key pair generation stuff rather than the parameter generation stuff. I'm going to try out this construct on BouncyCastle and see if it works for their curve tables. Mike At 03:14 PM 1

Re: Creating an EC Public Key using Named Curves

2013-10-08 Thread Michael StJohns
At 01:38 PM 10/8/2013, Vincent Ryan wrote: >On 8 Oct 2013, at 17:56, Michael StJohns wrote: > >> I use this construct a lot, but there are a number of cases (e.g. where I'm >> trying to take an EC key and turn it into a structure to send to a smart >> card) where what I really need is to be able

Re: [8] 8008171: Refactor KeyStore.DomainLoadStoreParameter as a standalone class

2013-10-08 Thread Sean Mullan
Looks good to me. --Sean On 10/08/2013 02:14 PM, Vincent Ryan wrote: Please review the following change - it's a simple re-factoring to promote a nested class to a stand-alone class: Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008171 Webrev: http://cr.openjdk.java.net/~vinnie/800

hg: jdk8/tl/jaxp: 2 new changesets

2013-10-08 Thread michael . fang
Changeset: dbecbb685503 Author:mfang Date: 2013-10-08 09:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/dbecbb685503 8025215: jdk8 l10n resource file translation update 4 Reviewed-by: joehw, yhuang ! src/com/sun/org/apache/xalan/internal/res/XSLTErrorResources_de.java !

[8] 8008171: Refactor KeyStore.DomainLoadStoreParameter as a standalone class

2013-10-08 Thread Vincent Ryan
Please review the following change - it's a simple re-factoring to promote a nested class to a stand-alone class: Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8008171 Webrev: http://cr.openjdk.java.net/~vinnie/8008171/webrev.00/ Thanks.

Re: Creating an EC Public Key using Named Curves

2013-10-08 Thread Vincent Ryan
On 8 Oct 2013, at 17:56, Michael StJohns wrote: > I use this construct a lot, but there are a number of cases (e.g. where I'm > trying to take an EC key and turn it into a structure to send to a smart > card) where what I really need is to be able to produce an EllipticCurve > (actually ECPara

Re: Creating an EC Public Key using Named Curves

2013-10-08 Thread Michael StJohns
I use this construct a lot, but there are a number of cases (e.g. where I'm trying to take an EC key and turn it into a structure to send to a smart card) where what I really need is to be able to produce an EllipticCurve (actually ECParamaterSpec) from a name. I started looking at why ECGenP

Re: Creating an EC Public Key using Named Curves

2013-10-08 Thread Vincent Ryan
Currently, there is no public API for named curves. However you can generate named curves using the SunEC provider and the ECParameterSpec class. For example, AlgorithmParameters parameters = AlgorithmParameters.getInstance("EC", "SunEC"); parameters.init(new ECGenParameterSpec(

hg: jdk8/tl/nashorn: 6 new changesets

2013-10-08 Thread sundararajan . athijegannathan
Changeset: 6345d08fd5de Author:hannesw Date: 2013-10-08 11:55 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/6345d08fd5de 8025213: Assignment marks variable as defined too early Reviewed-by: jlaskey, lagergren, sundar ! src/jdk/nashorn/internal/codegen/Attr.java + test/s

Creating an EC Public Key using Named Curves

2013-10-08 Thread Anders Rundgren
If you have the X and Y points and the name of a public key you can create a ECPublicKey using BouncyCastle. I cannot find any counterpart in JDK 7. What am I missing? BC: return KeyFactory.getInstance ("EC").generatePublic (new ECPublicKeySpec (new ECPoint (x, y), new ECNamedCurveSpec (name,.

hg: jdk8/tl/jdk: 8024788: (fs) Files.readAllBytes uses FileChannel which may not be supported by all providers

2013-10-08 Thread alan . bateman
Changeset: 95bb56c61276 Author:alanb Date: 2013-10-08 10:49 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/95bb56c61276 8024788: (fs) Files.readAllBytes uses FileChannel which may not be supported by all providers Reviewed-by: chegar ! src/share/classes/java/nio/file/Files.

hg: jdk8/tl/jdk: 8025136: SplittableRandom enchancements

2013-10-08 Thread paul . sandoz
Changeset: b90dcd1a71bf Author:psandoz Date: 2013-10-08 11:17 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b90dcd1a71bf 8025136: SplittableRandom enchancements Reviewed-by: psandoz, martin Contributed-by: Doug Lea , Guy Steele ! src/share/classes/java/util/Random.java !