Re: Security Policy with denying rules

2014-02-04 Thread Sean Mullan
Hi Ondrej, Thanks for sharing the information about your project. If you have a copy of the book "Inside Java 2 Platform Security" [1], there is a section (5.1.5) discussing the rationale for not including support for "negative" permissions in the Java Security model. The section talks about

Re: Fwd: [9] RFR 8028727: warnings from b116 for jdk.src.share.native.sun.security.ec: JNI pending exceptions

2014-02-04 Thread Vincent Ryan
Thanks Alan. In this case, each call to GetByteArrayRegion is preceded by a call to GetArrayLength so passing an array index that is out of bounds cannot occur. On 04/02/2014 16:39, Alan Bateman wrote: On 04/02/2014 16:31, Vincent Ryan wrote: : Please review this patch for better handling of

Re: Fwd: [9] RFR 8028727: warnings from b116 for jdk.src.share.native.sun.security.ec: JNI pending exceptions

2014-02-04 Thread Alan Bateman
On 04/02/2014 16:31, Vincent Ryan wrote: : Please review this patch for better handling of JNI pending exceptions in the ECC native code: Webrev: http://cr.openjdk.java.net/~vinnie/8028727/webrev.00/ The patch examines the return code from JNI calls to check whether an exception is already pe

Re: 8031586: Check jdk/src/*/native/com/sun/security/auth/module for pending JNI exceptions

2014-02-04 Thread Chris Hegarty
As far as the source changes are concerned, then they look good to me. -Chris. On 02/04/2014 03:02 PM, Alan Bateman wrote: The native methods for the JDK-specific API to JAAS don't handle handle errors and JNI exceptions everywhere. I'd like to fix some of these with the following patch: http

[9] RFR 8028727: warnings from b116 for jdk.src.share.native.sun.security.ec: JNI pending exceptions

2014-02-04 Thread Vincent Ryan
Please review this patch for better handling of JNI pending exceptions in the ECC native code: Webrev: http://cr.openjdk.java.net/~vinnie/8028727/webrev.00/ The patch examines the return code from JNI calls to check whether an exception is already pending. If so then it cleans up and returns

Re: Review Request for 9000142: PlatformPCSC.java loading unversioned native shared library

2014-02-04 Thread Andrew Hughes
- Original Message - > > Won't this change break systems which don't have libpcsclite.so.1? > Changes like this need to be thought through. What happens when > libpcsclite.so.2 comes out? > As for API changes, shouldn't there be some compatibility requirement on > APIs as libpcsclite.so ev

8031586: Check jdk/src/*/native/com/sun/security/auth/module for pending JNI exceptions

2014-02-04 Thread Alan Bateman
The native methods for the JDK-specific API to JAAS don't handle handle errors and JNI exceptions everywhere. I'd like to fix some of these with the following patch: http://cr.openjdk.java.net/~alanb/8031586/webrev/ A couple of things to note: - The existing code throws IllegalArgumentExcep