Re: apple.security.KeychainStore does not load private key (when called from javaws)

2014-08-21 Thread Florian Bruckner (3kraft)
Hi Sean, the OCA has been approved - what are the next steps? With best regards, Florian On 05.08.14 21:47, Sean Mullan wrote: This seems like a reasonable change to me. In order to proceed with accepting your patch, you will first need to sign an OCA. See step 0 of

Re: apple.security.KeychainStore does not load private key (when called from javaws)

2014-08-21 Thread Vincent Ryan
Hello Florian, I can sponsor this changeset and attribute the fix to you. On 21 Aug 2014, at 09:52, Florian Bruckner (3kraft) florian.bruck...@3kraft.com wrote: Hi Sean, the OCA has been approved - what are the next steps? With best regards, Florian On 05.08.14 21:47, Sean Mullan

Re: Replace concat String to append in StringBuilder parameters

2014-08-21 Thread Wang Weijun
I filed a bug at https://bugs.openjdk.java.net/browse/JDK-8038277 Webrev in 3 parts at http://cr.openjdk.java.net/~weijun/8038277/client/webrev.00 http://cr.openjdk.java.net/~weijun/8038277/core/webrev.00/ http://cr.openjdk.java.net/~weijun/8038277/extra/webrev.00/ --Max On Aug

Re: Replace concat String to append in StringBuilder parameters

2014-08-21 Thread Andrej Golovnin
https://bugs.openjdk.java.net/browse/JDK-8038277 This is not the right bug report. The subject of this bug report is Improve the bootstrap performance of carets keystore. http://cr.openjdk.java.net/~weijun/8038277/client/webrev.00 TABs are still used for indentation. I looked only

Re: Replace concat String to append in StringBuilder parameters

2014-08-21 Thread Wang Weijun
On Aug 21, 2014, at 21:18, Andrej Golovnin andrej.golov...@gmail.com wrote: https://bugs.openjdk.java.net/browse/JDK-8038277 This is not the right bug report. The subject of this bug report is Improve the bootstrap performance of carets keystore. Oh, my mistake, it should be

Re: Replace concat String to append in StringBuilder parameters

2014-08-21 Thread Wang Weijun
I also see a lot of .toString() and String.valueOf() calls. $ cat string_concat_updated.patch | perl -ne 'print if /^\+ .*append.*(String\.valueOf|\.toString\(\))/' | wc 62 2104626 Wrapped lines not indented correctly in

Re: apple.security.KeychainStore does not load private key (when called from javaws)

2014-08-21 Thread Florian Bruckner (3kraft)
Hi Vincent, excellent - thanks for your support - what are the next steps for me to do? regards, Florian On 21.08.14 11:28, Vincent Ryan wrote: Hello Florian, I can sponsor this changeset and attribute the fix to you. On 21 Aug 2014, at 09:52, Florian Bruckner (3kraft)

Re: RFR J8050281: New permission tests for JEP 140

2014-08-21 Thread Amanda Jiang
Hi Sean, Thank you for reviewing this. I have improved codes by your suggestions. New webrev link: http://cr.openjdk.java.net/~tyan/amandaj/8050281/webrev.02/ Thanks, Amanda On 8/19/14 10:13 AM, Sean Mullan wrote: On 08/06/2014 06:25 PM, Amanda Jiang wrote: Sorry, wrong webrev link, it

Re: [9] request for review: 8055207: keystore and truststore debug output could be much better

2014-08-21 Thread Seán Coffey
Looks good Vinnie. Thanks for handling this. One more comment from me.. I recently worked with a group who were reading the verbose security messages when trying to debug an SSL connection issue. They weren't sure if two-way SSL authentication was set up between the server and client. Could

[Update] Re: RFR 6562449: LoginContext does not all allow overloading of login method in LoginModule

2014-08-21 Thread Jamil Nimeh
One more update, with Max's nits addressed: http://cr.openjdk.java.net/~weijun/6562449/webrev.03 --Jamil On 08/20/2014 02:38 PM, Jamil Nimeh wrote: Hello everyone, This is an updated review that addresses comments from the original webrev.

Re: [Update] Re: RFR 6562449: LoginContext does not all allow overloading of login method in LoginModule

2014-08-21 Thread Wang Weijun
Code change looks fine, but you will need to translate the file path to new module style. There are also 2 useless imports: import java.util.LinkedList; import java.security.AccessController; --Max On Aug 22, 2014, at 9:12, Jamil Nimeh jamil.j.ni...@oracle.com wrote: One more update, with