Re: RFR(XXS) : 8057813: Alterations to jdk_security3 test target

2014-09-09 Thread Weijun Wang
I'd like other jgss/krb5-related tests also there: test/sun/security/krb5 \ test/sun/security/jgss \ test/com/sun/security/jgss \ test/javax/security/auth/kerberos \ Is that OK? Thanks Max On 9/10/2014 1:10, Seán Coffey wrote: On some recent JPRT test jobs, I'v

RFR JDK-8049432: Need new tests for testing TLS property jdk.tls.client.protocols with various protocols and values

2014-09-09 Thread zaiyao liu
Hi All, Please review the code change,the purpose of this fix is to address following: -Sets the property jdk.tls.client.protocols to one of this protocols:SSLv3,TLSv1,TLSv1,TLSv1.1,TLSv1.2 and TLSV(invalid) or removes this property (if any),then validates the default, supported and current

Re: RFR(XXS) : 8057813: Alterations to jdk_security3 test target

2014-09-09 Thread Xuelei Fan
Good idea and look fine to me. Thanks, Xuelei On 9/10/2014 1:10 AM, Seán Coffey wrote: > On some recent JPRT test jobs, I've noticed that the jdk_security3 test > target is taking 40+ mins on some systems. Looking closer at test times, > I see that sun/security/krb5 tests alone can take ~15-16 mi

Please review CR 8049021 Add smartcardio tests with APDU buffer

2014-09-09 Thread Amanda Jiang
Hello, Please help to review the changeset below, new tests are added for javax.smartcardio.CommandAPDU, javax.smartcardio.ResponseAPDU and javax.smartcardio.TerminalFactorySpi. Bug - https://bugs.openjdk.java.net/browse/JDK-8049021 Webrev - http://cr.openjdk.java.net/~tyan/ama

Re: RFR(XXS) : 8057813: Alterations to jdk_security3 test target

2014-09-09 Thread Bradford Wetmore
I'm not an expert in the JPRT/makefiles for test, but looks good. Brad On 9/9/2014 11:45 AM, Sean Mullan wrote: This seems like a good idea to me. Looks ok to me. --Sean On 09/09/2014 01:10 PM, Seán Coffey wrote: On some recent JPRT test jobs, I've noticed that the jdk_security3 test target

Re: RFR 8042900: Allow com.sun.security.jgss to be in different module than org.ietf.jgss

2014-09-09 Thread Valerie Peng
Sure, fine with me. Thanks, Valerie On 9/9/2014 3:53 AM, Wang Weijun wrote: On Sep 9, 2014, at 18:45, Wang Weijun wrote: 1) line 364: move it inside the if-block? Seems no value calling xstatus() when x is null. Correct. 2) line 401: move it inside the if-block? Since if x is null, then

Re: RFR(XXS) : 8057813: Alterations to jdk_security3 test target

2014-09-09 Thread Sean Mullan
This seems like a good idea to me. Looks ok to me. --Sean On 09/09/2014 01:10 PM, Seán Coffey wrote: On some recent JPRT test jobs, I've noticed that the jdk_security3 test target is taking 40+ mins on some systems. Looking closer at test times, I see that sun/security/krb5 tests alone can take

RFR(XXS) : 8057813: Alterations to jdk_security3 test target

2014-09-09 Thread Seán Coffey
On some recent JPRT test jobs, I've noticed that the jdk_security3 test target is taking 40+ mins on some systems. Looking closer at test times, I see that sun/security/krb5 tests alone can take ~15-16 mins to run. I'd like to separate those tests out into their own test target (jdk_security4)

Re: RFR 8042900: Allow com.sun.security.jgss to be in different module than org.ietf.jgss

2014-09-09 Thread Wang Weijun
On Sep 9, 2014, at 18:45, Wang Weijun wrote: >> >> 1) line 364: move it inside the if-block? Seems no value calling xstatus() >> when x is null. > > Correct. > >> 2) line 401: move it inside the if-block? Since if x is null, then there is >> no output following this println() call. > > No b

Re: RFR 8042900: Allow com.sun.security.jgss to be in different module than org.ietf.jgss

2014-09-09 Thread Wang Weijun
On Sep 9, 2014, at 6:25, Valerie Peng wrote: > Max, > > Mostly look fine. Just some comments, questions (see below): > > > 1) line 71 - 76 was done in Krb5Context.java. Is it really necessary to move > it here? I don't see a reason to. You are right. I thought KerberosCredMessage is a com.s