Re: PING 2: [7u80] Request for review for CR 4963723: Implement SHA-224

2014-12-24 Thread dalibor.to...@oracle.com
Can you elaborate on 'this and a couple of other patches' - is that supposed to be all of the corresponding JEP 130? Some part of it? Considering that the JEP 130 has legal and docs implications that imply more work having to be done than just back porting a couple of change sets, I think you

Re: Request for review : 8032573 - CertificateFactory.getInstance("X.509").generateCertificates(InputStream) does not throw CertificateException for invalid input

2014-12-24 Thread Jamil Nimeh
Hi Mala, the backport looks good to me. Only one nit: I think the comment "no crls provided" in X509Factory.java:461 should be removed since you have the corrected comment in there. For what it's worth I'm not an approved reviewer on the census yet so you might need someone else to give the o

Re: PING 2: [7u80] Request for review for CR 4963723: Implement SHA-224

2014-12-24 Thread Andrew Hughes
- Original Message - > Considering that the issue was a P3 RFE rather than a high priority bug fix, > it's not clear to me why it would be necessary to backport it into 7u80, at > the end point in the release cycle. > I don't have anything to do with the assignment of such priorities. >

Re: RFR: JDK-8047769 SecureRandom should be more frugal with file descriptors

2014-12-24 Thread Peter Levart
Hi Brad, Thanks for looking into this. Here's updated webrev: http://cr.openjdk.java.net/~plevart/jdk9-dev/FileInputStreamPool.8047769/webrev.02/ ...and answers are inline... On 12/23/2014 02:30 AM, Bradford Wetmore wrote: Hi Peter, Looks like you have a committer status, will you be pushin