Hi Jason,
Just a few comments:
* DOMSignatureMethod
- If setParameter throws an exception, I think we should fallback and
try the old code. This will allow 3rd party JCE providers to continue to
work until they update their implementations to support the new
ParameterSpec.
* DSA,
This is a P2 test bug impacting continuous integration:
http://cr.openjdk.java.net/~wetmore/8069038/webrev.00
A recent change missed updating one of the tests.
Pretty straight forward, also corrected one typo.
I don't see this test in the JDK 8 workspace, it's apparently only a 9
thing.
Xuelei/Sean looked at this already (below).
Brad
On 1/23/2015 5:04 AM, Sean Mullan wrote:
On 01/23/2015 02:21 AM, Bradford Wetmore wrote:
JPRT passed. Off to bed.
The fix looks fine to me.
--Sean
On 1/22/2015 10:02 PM, Xuelei Fan wrote:
Looks fine to me.
Thanks,
Xuelei
On
Looks good to me.
--Sean
On 01/22/2015 09:33 AM, Wang Weijun wrote:
Hi All
Please review the code change at
http://cr.openjdk.java.net/~weijun/8055045/webrev.00/
The old code has an error is the value is a single or '.
Thanks
Max
Hi Sean,
Here is a new webrev with changes addressing all of your comments:
http://cr.openjdk.java.net/~juh/8042967/01/
Thanks,
Jason
On 01/23/2015 10:21 AM, Sean Mullan wrote:
Hi Jason,
Just a few comments:
* DOMSignatureMethod
- If setParameter throws an exception, I think we should
Hi Max,
Please see inline.
On 01/23/2015 05:18 AM, Wang Weijun wrote:
I have updated the webrev, updateJar() method does the following:
- creates a new jar file (destJarFilename)
- puts files which are specified in files parameter to destJarFilename
- copies files from srcJarFilename to
Looks good to me Sean.
Good to see additional logging in this area.
-Chris.
On 22/01/15 15:21, Seán Coffey wrote:
Looking for a review around this issue that came in as a reported
performance regression in NTLM proxy authentication. It turned out that
HttpsClients were being discarded after
