[9] RFR: 8048622: Enhance tests for PKCS11 keystores with NSS

2015-08-21 Thread Artem Smotrakov
Hello, Please review a couple of changes for PKCS11 tests: - Added a new test which checks that a keystore can't be loaded with incorrect password, found https://bugs.openjdk.java.net/browse/JDK-8134232 - Added a check that a trusted entry can be removedfrom keystore - Updated existing tests

Re: RFR 8048357: PKCS basic tests

2015-08-21 Thread Weijun Wang
PKCS10AttrOrder.java: - Why not inline revAttributes(), prov() and constructMap()? They are only used once. Putting the content into the main method is more clear. - You can create separate method for the while look checks. The 2 look identical. PKCS10AttributeReader.java: - Is it OK to in