PKCS10AttrOrder.java:
- Why not inline revAttributes(), prov() and constructMap()? They are
only used once. Putting the content into the main method is more clear.
- You can create separate method for the while look checks. The 2 look
identical.
PKCS10AttributeReader.java:
- Is it OK to indent the data in the comment to multiple levels?
- Again, initMap() not necessary.
PKCS7VerifyTest.java:
- Not sure what this is for. The 1st and 2nd argument of the @run line
are the same?
SignerOrder.java:
- Comment on what derString1 and derString1 are.
- What do you expect verifs1.length and verifs2.length to be? Will you
also check it?
PKCS8Test.java:
- Typo: s/recieved/received/g
Thanks
Max
On 08/21/2015 07:11 AM, Amanda Jiang wrote:
Hi All,
Please be free to review new tests for conformance testing of PKCS.
bug: https://bugs.openjdk.java.net/browse/JDK-8048357
webrev: http://cr.openjdk.java.net/~amjiang/8048357/webrev.01/
Thanks,
Amanda
