RE: RFR JDK-8074931: Additional tests for CertPath API

2015-09-14 Thread Frank Yuan
Thank you, Sean Best Regards Frank -Original Message- From: Sean Mullan [mailto:sean.mul...@oracle.com] Sent: Tuesday, September 15, 2015 2:59 AM To: Frank Yuan ; security-dev@openjdk.java.net Subject: Re: RFR JDK-8074931: Additional tests for CertPath API These tests look fine to me.

Re: [9] RFR: 8048356: SecureRandom default provider tests

2015-09-14 Thread Bradford Wetmore
I might also suggest grabbing a byte from the various implementations to ensure they return working implementations. You should also include a comment which mentions that this is an implementation-specific test for the Oracle & stock OpenJDK implementations, and that other implementations migh

Re: RFR JDK-8074931: Additional tests for CertPath API

2015-09-14 Thread Sean Mullan
These tests look fine to me. --Sean On 09/02/2015 03:54 AM, Frank Yuan wrote: Hi Security developers I have a security test bug https://bugs.openjdk.java.net/browse/JDK-8074931, which is to add more coverage for CertPath and X509CertSelector in jdk repo. Would you like to review this patch ht

Re: [9] RFR: 8048622: Enhance tests for PKCS11 keystores with NSS

2015-09-14 Thread Vincent Ryan
Your fix looks fine. Thanks. > On 21 Aug 2015, at 21:34, Artem Smotrakov wrote: > > Hello, > > Please review a couple of changes for PKCS11 tests: > - Added a new test which checks that a keystore can't be loaded with > incorrect password, > found https://bugs.openjdk.java.net/browse/JDK-813

Re: [9] RFR: 8134232: KeyStore.load() throws an IOException with a wrong cause in case of wrong password

2015-09-14 Thread Vincent Ryan
Your fix looks fine Artem. Thanks. > On 11 Sep 2015, at 12:46, Artem Smotrakov wrote: > > Hello, > > Please review this for 9. > > According to [1], KeyStore.load(InputStream, char[]) method should throw an > IOException, and the cause of the IOException should be an > UnrecoverableKeyExcep