Re: RFR 8050427 LoginContext tests to cover JDK-4703361

Looks fine. I'm glad you also fix the trailing whitespaces. Thanks Max On 09/24/2015 10:11 AM, Amanda Jiang wrote: Hi Max, Thanks for your suggestions! Two places were fixed and I also edited codes a little bit to make test clear. Please check latest webrev: http://cr.openjdk.java.net/~amjian

Re: RFR JDK-8075286: Additional tests for signature algorithm OIDs and transformation string

Valerie, Thanks for your review. Best regards, John Jiang On 2015/9/24 3:51, Valerie Peng wrote: Updated webrev looks fine. Thanks, Valerie On 9/22/2015 10:21 PM, John Jiang wrote: Hi Valerie, Thanks for your comments. Please review the updated patch at http://cr.openjdk.java.net/~fyuan/jji

Re: RFR 8050427 LoginContext tests to cover JDK-4703361

Hi Max, Thanks for your suggestions! Two places were fixed and I also edited codes a little bit to make test clear. Please check latest webrev: http://cr.openjdk.java.net/~amjiang/8050427/webrev.03/ Thanks, Amanda On 9/22/15, 6:45 PM, Weijun Wang wrote: OK, the code is much easier to under

Re: [9] RFR 8137068: Tests added in JDK-8048604 fail to compile

Looks fine to me. Xuelei On 9/24/2015 9:26 AM, Valerie Peng wrote: > Max or Xuelei, > > Would either of you be able to review this quickly? There are some > problems with the test co-location fix that I integrated. > Just one-line fix in 2 tests. > > Webrev: http://cr.openjdk.java.net/~valeriep

[9] RFR 8137068: Tests added in JDK-8048604 fail to compile

Max or Xuelei, Would either of you be able to review this quickly? There are some problems with the test co-location fix that I integrated. Just one-line fix in 2 tests. Webrev: http://cr.openjdk.java.net/~valeriep/8137068/webrev.00/ Thanks, Valerie

Re: RFR JDK-8075286: Additional tests for signature algorithm OIDs and transformation string

Updated webrev looks fine. Thanks, Valerie On 9/22/2015 10:21 PM, John Jiang wrote: Hi Valerie, Thanks for your comments. Please review the updated patch at http://cr.openjdk.java.net/~fyuan/jjiang/8075286/webrev.01/ Best regards, John Jiang On 2015/9/12 7:50, Valerie Peng wrote: Mostly a

Re: RFR for JDK-8048604 : Tests for strong crypto ciphers

The updated webrev looks good. Valerie On 9/23/2015 9:50 AM, Tristan Yan wrote: Thanks Valerie, I fixed with new version, please review it again. http://cr.openjdk.java.net/~tyan/8048604/webrev.03/ Tristan On Sep 22, 2015, at 4:30 PM, V

Re: RFR for JDK-8048604 : Tests for strong crypto ciphers

Thanks Valerie, I fixed with new version, please review it again. http://cr.openjdk.java.net/~tyan/8048604/webrev.03/ Tristan > On Sep 22, 2015, at 4:30 PM, Valerie Peng wrote: > > Hi, Tristan, > > The updated webrev addressed most of my pr

Re: Brainpool curves

+1 for this. On 2015-09-17 19:53, Sean Mullan wrote: On 08/19/2015 05:48 PM, Jiri Stary wrote: Hello, do you plan to support brainpool curves for TLS in Java 9 (RFC 7027) ? There is no plan to support it in 9. There is an open RFE for supporting brainpool in JCE: https://bugs.openjdk.java.n

Re: TLS ALPN Proposal v5

Hi, On Wed, Sep 23, 2015 at 7:04 AM, Bradford Wetmore wrote: > >> This new proposal still requires that ciphers are sorted in a way that >> matches the ApplicationProtocol order. >> Would be nice if, along with the HTTP/2 blacklist, there is a HTTP/2 >> comparator that sorts ciphers putting the b