On 5/13/2016 3:00 AM, Martin Buchholz wrote:
> I have a new simpler webrev following your suggestion:
> http://cr.openjdk.java.net/~martin/webrevs/openjdk8/AlgorithmId-get-race/
Looks fine to me.
Thanks,
Xuelei
> Old one available at
> http://cr.openjdk.java.net/~martin/webrevs/openjdk8/Algorithm
Hi Anthony!
A few minor comments:
*AlgorithmChecker.java*
It would be more consistent to use {@code ...} tags in place of
...
*DisabledAlgorithmConstraints.java*
275 Matcher dmatch = denyAfterPattern.matcher(entry);
296 } else if (dmatch.matches()) {
It might be a bit more efficient to
Looks fine to me.
--Sean
On 5/12/16 3:11 PM, joe darcy wrote:
Hello,
The test
sun/security/mscapi/ShortRSAKey1024.sh
has been seen to fail with some frequency on windows. Until JDK-8153948
is addressed, the test should be problem listed.
Please review the patch below which does this.
Thank
Looks good to me.
Thanks,
Valerie
On 5/11/2016 2:33 PM, Rajan Halade wrote:
Please provide your review of patch to refactor SignatureTest. This
test now runs all signature algorithms with key generated once
resulting in saving 75% of execution time.
Bug: https://bugs.openjdk.java.net/browse/J
Hello,
The test
sun/security/mscapi/ShortRSAKey1024.sh
has been seen to fail with some frequency on windows. Until JDK-8153948
is addressed, the test should be problem listed.
Please review the patch below which does this.
Thanks,
-Joe
diff -r b14b89e259ac test/ProblemList.txt
--- a/test/
I've updated the webrev to at:
http://cr.openjdk.java.net/~ascarpino/8154005/webrev.01/
Comments addressed below...
On 05/11/2016 04:55 PM, e...@zusammenkunft.net wrote:
Hello,
In AlgorithmChecker the Javadoc seems to not follow "@param name
desc" format (in two places). Also it should most
Hi Jamil,
Thanks for the review. Good catch on the formatting typo. I have fixed it.
Removed some of the casting that you mentioned also.
As for only free'ing context upon non-zero return value, it's more for
allowing the java objects to be used again without re-initialization.
When an error/ex
Hi Tony,
Thanks for the review.
I have deleted line 161 of UcryptoProvider.java as that's the intention.
As for ucrypto_version enhancement, it's not that critical for this. I
will note it in another ucrypto bug and we can do it there.
Hmm, the internal operations of SHA-3 are already operatin
I have a new simpler webrev following your suggestion:
http://cr.openjdk.java.net/~martin/webrevs/openjdk8/AlgorithmId-get-race/
Old one available at
http://cr.openjdk.java.net/~martin/webrevs/openjdk8/AlgorithmId-get-race.0/
On Wed, May 11, 2016 at 11:41 PM, Xuelei Fan wrote:
> Hi Martin,
>
> If
On 5/12/2016 10:38 AM, Anthony Scarpino wrote:
On 05/04/2016 07:08 PM, Valerie Peng wrote:
Hi,
Can someone help reviewing the changes for SHA-3?
The result has been validated against the NIST test vectors (for
BYTE-ONLY impls, i.g. input which are multiples of bytes).
The feature complete da
On 05/04/2016 07:08 PM, Valerie Peng wrote:
Hi,
Can someone help reviewing the changes for SHA-3?
The result has been validated against the NIST test vectors (for
BYTE-ONLY impls, i.g. input which are multiples of bytes).
The feature complete date is coming up in a week or two. So, if this can
Hi,
the API this improvement depends on was updated to reflect more clearly
that this
is taking a privileged action:
https://bugs.openjdk.java.net/browse/JDK-8155775
Here's the updated webrev:
http://cr.openjdk.java.net/~redestad/8155039/webrev.01/
Thanks!
/Claes
On 2016-04-25 19:28, Cla
On 12/05/2016 12:40, Seán Coffey wrote:
> Logged https://bugs.openjdk.java.net/browse/JDK-8156841
>
> Regards,
> Sean.
Many thanks,
Mark
>
> On 10/05/2016 14:51, Mark Thomas wrote:
>> Hi,
>>
>> While working my way through Tomcat's memory leak protection / detection
>> / fixing code, I have
Logged https://bugs.openjdk.java.net/browse/JDK-8156841
Regards,
Sean.
On 10/05/2016 14:51, Mark Thomas wrote:
Hi,
While working my way through Tomcat's memory leak protection / detection
/ fixing code, I have found an issue that remains unresolved in the
latest JDK 9 source.
The poller threa
14 matches
Mail list logo
