RFR 8141411: keytool can wrongly parse the start date value given by the -startdate option

Please review the fix for this embarrassing bug: http://cr.openjdk.java.net/~weijun/8141411/webrev.00 Thanks Max

Re: RFR 8163303: Remove identity scope information from jarsigner -verbose output

The change of L10n resource files looks good from L10n perspective. Thanks, Leo On 08/08/2016 03:28 PM, Weijun Wang wrote: Hi All Please review the code change at http://cr.openjdk.java.net/~weijun/8163303/webrev.00 I removed the "@SuppressWarnings("deprecation")" at the beginning. I thin

Re: RFR: 8164052 Fix legal notices in JDK tests

CC security-dev. The security part looks fine to me. Thanks, Xuelei On 8/16/2016 2:39 AM, Alexandre (Shura) Iline wrote: > Hi, > > Please review this bulk update of JDK test sources which is fixing legal > notices formatting and content. > > http://cr.openjdk.java.net/~shurailine/8164052/webr

Re: [9] RFR: 8162484: javax/net/ssl/Stapling/SSLSocketWithStapling.java test fails intermittently with "Address already in use" error

Looks fine to me. Thanks, Xuelei On 8/16/2016 1:31 AM, Artem Smotrakov wrote: > Hi Xuelei, > > Makes sense to me, I removed those 1 second delays > > http://cr.openjdk.java.net/~asmotrak/8162484/webrev.03/ > > Artem > > > On 08/12/2016 06:17 PM, Xuelei Fan wrote: >> It's a nice find of the p

Re: [jdk9] RFR: 8163896: Finalizing one key of a KeyPair invalidates the other key

Thank you Vincent for review! With kind regards, Ivan On 15.08.2016 19:13, Vincent Ryan wrote: Thanks Ivan. Your fix looks good. On 13 Aug 2016, at 02:15, Ivan Gerasimov wrote: Hello! It was noticed, that SunMSCAPI implementation of a KeyPair has a problem: The public and the private ke

Re: [9] RFR: 8162484: javax/net/ssl/Stapling/SSLSocketWithStapling.java test fails intermittently with "Address already in use" error

Hi Xuelei, Makes sense to me, I removed those 1 second delays http://cr.openjdk.java.net/~asmotrak/8162484/webrev.03/ Artem On 08/12/2016 06:17 PM, Xuelei Fan wrote: It's a nice find of the port reuse issues. This update will turn into expected connection failure into reading/writing interr

Re: [jdk9] RFR: 8163896: Finalizing one key of a KeyPair invalidates the other key

Thanks Ivan. Your fix looks good. > On 13 Aug 2016, at 02:15, Ivan Gerasimov wrote: > > Hello! > > It was noticed, that SunMSCAPI implementation of a KeyPair has a problem: The > public and the private keys share the same native handles. > > As the result, when one of the keys is finalized,

Re: [jdk9] RFR: 8163896: Finalizing one key of a KeyPair invalidates the other key

Thank you Seán for review! It's a good point about making the testcase more generic; I'll modify it as you suggest. With kind regards, Ivan On 15.08.2016 13:04, Seán Coffey wrote: Not sure how you end up finding such issues Ivan! The fix looks good. One suggestion on the testcase. Could you

Re: [jdk9] RFR: 8163896: Finalizing one key of a KeyPair invalidates the other key

Not sure how you end up finding such issues Ivan! The fix looks good. One suggestion on the testcase. Could you make it more generic ? i.e. don't just test the MSCAPI provider. Let's cycle through all providers available for KeyPairGenerator and ensure no other provider suffers (or introduces)

[9] RFR: 8153146 & 8087144 for sun/security/krb5/auto/MaxRetries.java

Hi, Please review the patch for 2 issues on "sun/security/krb5/auto/MaxRetries.java". JBS: https://bugs.openjdk.java.net/browse/JDK-8153146 https://bugs.openjdk.java.net/browse/JDK-8087144 Webrev: http://cr.openjdk.java.net/~ssahoo/8087144/webrev.00/ Description: MaxRetries