Re: RFR 8164533: [TEST_BUG] sun/security/ssl/SSLSocketImpl/CloseSocket.java failed with "Error while cleaning up threads after test"

On 8/26/2016 2:52, Artem Smotrakov wrote: My point is that it's better to run tests which don't modify the default JSSE configuration in agent VM. It would speed up test execution. Another benefit of this is that if the test still fails it might reveal a real bug. --Max

Re: RFR: 8061842: Package jurisdiction policy files as something other than JAR

Can you add a new @run line which is the getNameCount()==1 but getParent() != policyPath case? + * @run main/othervm TestUnlimited /unlimited exception No other comment. On 8/26/2016 6:56, Bradford Wetmore wrote: Last call: http://cr.openjdk.java.net/~wetmore/8061842/webrev.03/ Thanks

Re: RFR 8074838: Resolve disabled warnings for libj2pkcs11

Looks ok to me... I had to look at the C declaration one twice. Too much Java, not enough C lately. Brad On 8/25/2016 2:20 PM, Anthony Scarpino wrote: Hi, Can I get a review of this change to remove the warning suppression and fix the minor compiler issues that it was hiding in the

Re: RFR: 8061842: Package jurisdiction policy files as something other than JAR

Last call: http://cr.openjdk.java.net/~wetmore/8061842/webrev.03/ Changes from .02: added null check for cryptoPolicyProperty renamed javaHomePolicyPath tweaked exception wording "files in" added test for empty string (""). On 8/24/2016 6:22 PM, Weijun Wang wrote: +Path

RFR 8074838: Resolve disabled warnings for libj2pkcs11

Hi, Can I get a review of this change to remove the warning suppression and fix the minor compiler issues that it was hiding in the pkcs11 wrapper library. http://cr.openjdk.java.net/~ascarpino/8074838/webrev/ thanks Tony

Re: RFR: 8150158: Update bugs.sun.com references to bugs.java.com

Looks fine to me. Tony On 08/25/2016 12:55 PM, Sean Mullan wrote: Real trivial fix, just updating obsolete bug URLs in code comments. bug: https://bugs.openjdk.java.net/browse/JDK-8150158 $ hg diff --nodates -a -U 1 diff -r 9c7eb3e1799f

RFR: 8150158: Update bugs.sun.com references to bugs.java.com

Real trivial fix, just updating obsolete bug URLs in code comments. bug: https://bugs.openjdk.java.net/browse/JDK-8150158 $ hg diff --nodates -a -U 1 diff -r 9c7eb3e1799f src/java.xml.crypto/share/classes/com/sun/org/apache/xml/internal/security/algorithms/implementations/IntegrityHmac.java

Re: RFR 8164533: [TEST_BUG] sun/security/ssl/SSLSocketImpl/CloseSocket.java failed with "Error while cleaning up threads after test"

Sure Xuelei, I read https://docs.oracle.com/javase/8/docs/technotes/guides/security/jsse/JSSERefGuide.html#InstallationAndCustomization If I understand correctly, the most settings can be done via system/security properties. But there may be some other ways like setDefaultHostnameVerifier(),

Re: RFR 8164533: [TEST_BUG] sun/security/ssl/SSLSocketImpl/CloseSocket.java failed with "Error while cleaning up threads after test"

> On Aug 26, 2016, at 1:33 AM, Artem Smotrakov > wrote: > > Hi Xuelei, > > >> On 08/25/2016 10:26 AM, Xuelei Fan wrote: >> >>> On Aug 26, 2016, at 12:43 AM, Artem Smotrakov >>> wrote: >>> >>> Hi Xuelei, >>> >>> I am not sure why

Re: RFR 8164533: [TEST_BUG] sun/security/ssl/SSLSocketImpl/CloseSocket.java failed with "Error while cleaning up threads after test"

Hi Xuelei, On 08/25/2016 10:26 AM, Xuelei Fan wrote: On Aug 26, 2016, at 12:43 AM, Artem Smotrakov wrote: Hi Xuelei, I am not sure why you think it's too strong to follow to it. To me it's pretty easy to see if a test calls System.setProperty() or

Re: RFR 8164533: [TEST_BUG] sun/security/ssl/SSLSocketImpl/CloseSocket.java failed with "Error while cleaning up threads after test"

> On Aug 26, 2016, at 12:43 AM, Artem Smotrakov > wrote: > > Hi Xuelei, > > I am not sure why you think it's too strong to follow to it. To me it's > pretty easy to see if a test calls System.setProperty() or > Security.setProperty() methods which modify default

Re: RFR 8164533: [TEST_BUG] sun/security/ssl/SSLSocketImpl/CloseSocket.java failed with "Error while cleaning up threads after test"

Hi Xuelei, I am not sure why you think it's too strong to follow to it. To me it's pretty easy to see if a test calls System.setProperty() or Security.setProperty() methods which modify default JSSE configuration. Is there any other way to modify default JSSE configuration, so that it can't

Re: RFR 8164533: [TEST_BUG] sun/security/ssl/SSLSocketImpl/CloseSocket.java failed with "Error while cleaning up threads after test"

Just a quick reply. 1. The close is necessary. 2. Run in othervm is safer. Please see my comments in other replies. If you still have questions, I will reply with more details tomorrow when I work on a PC. Xuelei > On Aug 25, 2016, at 11:00 PM, Svetlana Nikandrova >

Re: RFR 8164533: [TEST_BUG] sun/security/ssl/SSLSocketImpl/CloseSocket.java failed with "Error while cleaning up threads after test"

Hi Artem, Xuelei, thank you for your comments. Please see inline. On 25.08.2016 4:10, Xuelei Fan wrote: On 8/25/2016 3:55 AM, Artem Smotrakov wrote: Hi Svetlana, Thank you for cleaning up this test. I have a couple of comments (mostly about the original test). 1. I see that the test tries

Re: RFR: 8151893: Add security property to configure XML Signature secure validation mode

On 8/25/2016 10:14 PM, Sean Mullan wrote: On 08/25/2016 09:47 AM, Xuelei Fan wrote: http://cr.openjdk.java.net/~mullan/webrevs/8151893/webrev.01/ Looks fine to me except the following minor comment. java.security - 818 # AlgConstraint 819 # "disallowAlg" Uri ... 829 #

Re: RFR: 8151893: Add security property to configure XML Signature secure validation mode

On 08/25/2016 09:47 AM, Xuelei Fan wrote: http://cr.openjdk.java.net/~mullan/webrevs/8151893/webrev.01/ Looks fine to me except the following minor comment. java.security - 818 # AlgConstraint 819 # "disallowAlg" Uri ... 829 # For AlgConstraint, Uri is the algorithm

Re: RFR: 8061842: Package jurisdiction policy files as something other than JAR

Looks good Brad. One comment : You might hit an NPE here but I guess the Exception handling in the parent call would handle it : JceSecurity.java : 254 if (Paths.get(cryptoPolicyProperty).getNameCount() != 1) { Maybe add a null check to be cleaner ? I missed the

Re: RFR: 8151893: Add security property to configure XML Signature secure validation mode

>> http://cr.openjdk.java.net/~mullan/webrevs/8151893/webrev.01/ Looks fine to me except the following minor comment. java.security - 818 # AlgConstraint 819 # "disallowAlg" Uri ... 829 # For AlgConstraint, Uri is the algorithm URI String that is not allowed. The

Re: RFR: 8151893: Add security property to configure XML Signature secure validation mode

On 08/24/2016 10:25 PM, Xuelei Fan wrote: On 8/25/2016 7:57 AM, Sean Mullan wrote: I posted an updated webrev: http://cr.openjdk.java.net/~mullan/webrevs/8151893/webrev.0 I guess the link should be: http://cr.openjdk.java.net/~mullan/webrevs/8151893/webrev.01/ Yes, thanks. --Sean

Re: RFR 8164533: [TEST_BUG] sun/security/ssl/SSLSocketImpl/CloseSocket.java failed with "Error while cleaning up threads after test"

On 8/25/2016 2:06 PM, Weijun Wang wrote: I think Artem is correct here. All those tests that modify static fields should run in othervm mode, so that *each* runs in its *own* VM. All other tests, which make no such modifications, can share the *same* VM using agentvm. It's too strong to

Re: RFR 8164533: [TEST_BUG] sun/security/ssl/SSLSocketImpl/CloseSocket.java failed with "Error while cleaning up threads after test"

I think Artem is correct here. All those tests that modify static fields should run in othervm mode, so that *each* runs in its *own* VM. All other tests, which make no such modifications, can share the *same* VM using agentvm. On 8/25/2016 13:31, Xuelei Fan wrote: On 8/25/2016 12:31 PM,