Your fix looks fine to me.
Thanks.
> On 20 Oct 2016, at 05:21, Wang Weijun wrote:
>
> Please review this test change:
>
> diff --git a/test/sun/security/tools/jarsigner/TsacertOptionTest.java
> b/test/sun/security/tools/jarsigner/TsacertOptionTest.java
> --- a/test/sun/security/tools/jarsigner
Looks good. Thank you for the quick fix!
(I'm not an official reviewer.)
Thanks,
Amy
On 10/20/16 12:21 PM, Wang Weijun wrote:
Please review this test change:
diff --git a/test/sun/security/tools/jarsigner/TsacertOptionTest.java
b/test/sun/security/tools/jarsigner/TsacertOptionTest.java
--- a
Please review this test change:
diff --git a/test/sun/security/tools/jarsigner/TsacertOptionTest.java
b/test/sun/security/tools/jarsigner/TsacertOptionTest.java
--- a/test/sun/security/tools/jarsigner/TsacertOptionTest.java
+++ b/test/sun/security/tools/jarsigner/TsacertOptionTest.java
@@ -31,6 +
Please review the code change at
http://cr.openjdk.java.net/~weijun/8168127/webrev.00/
Two changes:
1. npath2 is considered in equals and hashCode of FilePermission, so 2 objects
with different npath2 can be added to a map and different entries.
2. special name for newPermUsingAltPath and n
Looks good.
> On Oct 19, 2016, at 8:07 PM, Wang Weijun wrote:
>
> Updated at
>
> http://cr.openjdk.java.net/~weijun/8163304/webrev.02/
>
> changes to webrev.01 is at
>
> http://cr.openjdk.java.net/~weijun/8163304/webrev.02/interdiff.patch.html
>
> Thanks
> Max
>
Updated at
http://cr.openjdk.java.net/~weijun/8163304/webrev.02/
changes to webrev.01 is at
http://cr.openjdk.java.net/~weijun/8163304/webrev.02/interdiff.patch.html
Thanks
Max
> Am Wed, 19 Oct 2016 16:13:24 -0400
> schrieb Sean Mullan <
> sean.mullan at oracle.com
> >:
>
> >
> 150 "The jar will be treated as unsigned, because it
>
> >
> is signed with a weak algorithm that is now disabled.\n\nRe-run
>
> >
> jarsigner with the -verbose option for mor
> On Oct 20, 2016, at 4:13 AM, Sean Mullan wrote:
>
> * Main.java
>
> 98 private static final DisabledAlgorithmConstraints SIGN_CHECK =
> 99 new DisabledAlgorithmConstraints(
> 100 DisabledAlgorithmConstraints.PROPERTY_CERTPATH_DISABLED_ALGS);
>
> This should be changed to PR
Am Wed, 19 Oct 2016 16:13:24 -0400
schrieb Sean Mullan :
> 150 "The jar will be treated as unsigned, because it
> is signed with a weak algorithm that is now disabled.\n\nRe-run
> jarsigner with the -verbose option for more details."},
I also wondered: what if there are multiple s
* Main.java
98 private static final DisabledAlgorithmConstraints SIGN_CHECK =
99 new DisabledAlgorithmConstraints(
100
DisabledAlgorithmConstraints.PROPERTY_CERTPATH_DISABLED_ALGS);
This should be changed to PROPERTY_JAR_DISABLED_ALGS now that the fix
for 8167594 is in 9.
Looks good.
--Sean
On 10/19/2016 01:42 PM, Anthony Scarpino wrote:
Hi,
I need a simple review of adding MD5 to the jdk.jar.disabledAlgorithms
security property. It's really a one line change, the comments got
moved to a different location in the file which makes it look bigger.
http://cr.ope
Hi,
I need a simple review of adding MD5 to the jdk.jar.disabledAlgorithms
security property. It's really a one line change, the comments got
moved to a different location in the file which makes it look bigger.
http://cr.openjdk.java.net/~ascarpino/8167591/webrev/
Tony
Please review the code change at
http://cr.openjdk.java.net/~weijun/8163304/webrev.01/
With this change, "jarsigner -verify -verbose" will print out how a jar was
signed.
For example, a jar which was signed and timestamped with many weak algorithms
will show
- Signed by "CN=old"
Digest
13 matches
Mail list logo
