Re: Code Review Request JDK-8170329 New SSLSocket testing template

2016-12-05 Thread Xuelei Fan
New webrev: http://cr.openjdk.java.net/~xuelei/8170329/webrev.01/ On 12/5/2016 10:16 AM, Artem Smotrakov wrote: On 12/02/2016 09:48 PM, Xue-Lei Fan wrote: - Exceptions are printed out in startServer/startClient methods, it doesn't look necessary to use suppressed exceptions and initCause

TLS session cache access (for FTP clients with data connection session reuse)

2016-12-05 Thread Bernd Eckenfels
With FTP/TLS there is a risk that data connections are guessed by attackers and there is no binding of the login credentials on the control connection and the data connection. Some FTP servers implement protection about this by requiring the data connection to resume the cached TLS session from th

Re: [9] RFR JDK-8157529 : Remove intermittent key from javax/net/ssl/DTLS/CipherSuite.java

2016-12-05 Thread Artem Smotrakov
Looks good to me. Artem On 11/30/2016 10:29 PM, Tim Du wrote: Hi , Would you help to review the path for "8157529:Remove intermittent key from javax/net/ssl/DTLS/CipherSuite.java" , the intermittently failed issue was fixed by JDK-8167680 , '@key intermittent ' can be removed.Thanks. JBS

Re: RFR[9] JDK-8170523: Some PKCS11 test cases are ignored with security manager

2016-12-05 Thread Sean Mullan
Looks good, but don't forget to add a noreg-self label to the bug. --Sean On 12/4/16 9:29 PM, John Jiang wrote: Hi Sean, Thanks for your comments. Please take a look at the new wevrev: http://cr.openjdk.java.net/~jjiang/8170523/webrev.01/ Best regards, John Jiang On 2016/12/3 5:02, Sean Mull

Re: Code Review Request JDK-8170329 New SSLSocket testing template

2016-12-05 Thread Artem Smotrakov
Hi Xuelei, Please see inline. On 12/02/2016 09:48 PM, Xue-Lei Fan wrote: - Exceptions are printed out in startServer/startClient methods, it doesn't look necessary to use suppressed exceptions and initCause() method. What was wrong with the code in runTest() method? The code in runTest() m

Re: RFR: 8170157/8169335: Unlimited Cryptography Policy Changes

2016-12-05 Thread Seán Coffey
looks good. You'll need to run the new CryptoPolicyFallback.java testcase in othervm mode. Regards, Sean. On 02/12/16 23:50, Bradford Wetmore wrote: Hi, I need reviewers for these related bugs: https://bugs.openjdk.java.net/browse/JDK-8170157 Enable unlimited cryptographic policy by default

Re: RFR: 8170157/8169335: Unlimited Cryptography Policy Changes

2016-12-05 Thread Erik Joelsson
Looks good. /Erik On 2016-12-03 00:50, Bradford Wetmore wrote: Hi, I need reviewers for these related bugs: https://bugs.openjdk.java.net/browse/JDK-8170157 Enable unlimited cryptographic policy by default in OracleJDK https://bugs.openjdk.java.net/browse/JDK-8169335 Add a crypto policy fa